From: Steve French <smfrench@gmail.com>
To: CIFS <linux-cifs@vger.kernel.org>
Subject: Ksmbd and max credits
Date: Thu, 14 Oct 2021 00:02:54 -0500 [thread overview]
Message-ID: <CAH2r5ms_S9WsLNnQ=AYE7Ykss5+VCfeFtL01VVqt6tp=CY5sRw@mail.gmail.com> (raw)
Thinking about the patch "ksmbd: improve credits management"
(https://github.com/smfrench/smb3-kernel/commit/bf8acc9e10e21c28452dfa067a7d31e6067104b1)
Hyunchul noted in the description:
"Windows server 2016 or later grant up to 8192 credits to clients at once."
I noticed that SMB2_MAX_CREDITS is defined as 8192 in
fs/ksmbd/smb2pdu.h. Isn't this a little low, although I see Samba
default to it as well.
Was thinking that that is roughly equivalent to 64 8MB writes, or 128
4MB writes. Although Samba defaults to 8192 max credits as well, for
Samba it is configurable (via "smb2 max credits" in smb.conf).
Should it be configurable? What do more current Windows servers
default to as the max?
--
Thanks,
Steve
next reply other threads:[~2021-10-14 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 5:02 Steve French [this message]
2021-10-14 21:58 ` Ksmbd and max credits Hyunchul Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5ms_S9WsLNnQ=AYE7Ykss5+VCfeFtL01VVqt6tp=CY5sRw@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.