All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hyunchul Lee <hyc.lee@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: Ksmbd and max credits
Date: Fri, 15 Oct 2021 06:58:11 +0900	[thread overview]
Message-ID: <CANFS6bbzu+OjJKaTVnvDS7GogzCzhD=jVMPoQC2xjcFx-STWhg@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5ms_S9WsLNnQ=AYE7Ykss5+VCfeFtL01VVqt6tp=CY5sRw@mail.gmail.com>

2021년 10월 14일 (목) 오후 2:03, Steve French <smfrench@gmail.com>님이 작성:
>
> Thinking about the patch "ksmbd: improve credits management"
> (https://github.com/smfrench/smb3-kernel/commit/bf8acc9e10e21c28452dfa067a7d31e6067104b1)
>
> Hyunchul noted in the description:
> "Windows server 2016 or later grant up to 8192 credits to clients at once."
>
> I noticed that SMB2_MAX_CREDITS is defined as 8192 in
> fs/ksmbd/smb2pdu.h.  Isn't this a little low, although I see Samba
> default to it as well.
>
> Was thinking that that is roughly equivalent to 64 8MB writes, or 128
> 4MB writes.   Although Samba defaults to 8192 max credits as well, for
> Samba it is configurable (via "smb2 max credits" in smb.conf).
> Should it be configurable?  What do more current Windows servers
> default to as the max?
>

According to MS-SMB2, the maximum credit limit is configurable, but
the default maximum credit limit in Windows Server 2022 is also 8192.

It looks good if it can be configurable, but I can't find out the possible range
of values.
And there is a description, "You should never need to set this parameter"
about "smb2 max credits in smb.conf" in the Samba manual.

>
> --
> Thanks,
>
> Steve



-- 
Thanks,
Hyunchul

      reply	other threads:[~2021-10-14 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  5:02 Ksmbd and max credits Steve French
2021-10-14 21:58 ` Hyunchul Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANFS6bbzu+OjJKaTVnvDS7GogzCzhD=jVMPoQC2xjcFx-STWhg@mail.gmail.com' \
    --to=hyc.lee@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.