[GIT] SMB3 Fixes

[GIT] SMB3 Fixes

[Steve French]

Three cifs/smb3 fixes - including two for stable

Please pull the following changes since commit
19ac4474203863a8141663d73d5976fe25464bfd:

  Merge tag 'ceph-for-4.11-rc9' of git://github.com/ceph/ceph-client
(2017-04-27 11:38:05 -0700)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to a6f74e80f271b19ea709cbda55e8eb67e9ffccf2:

  cifs: don't check for failure from mempool_alloc() (2017-04-28 07:56:33 -0500)

----------------------------------------------------------------
NeilBrown (1):
      cifs: don't check for failure from mempool_alloc()

Sachin Prabhu (2):
      Fix match_prepath()
      Do not return number of bytes written for ioctl CIFS_IOC_COPYCHUNK_FILE

 fs/cifs/connect.c       | 14 ++++++--------
 fs/cifs/ioctl.c         |  3 ++-
 fs/cifs/misc.c          | 14 +++++---------
 fs/cifs/smb2transport.c | 30 +++++++++++++-----------------
 fs/cifs/transport.c     | 32 ++++++++++++++------------------
 5 files changed, 40 insertions(+), 53 deletions(-)

-- 
Thanks,

Steve

Re: [GIT] SMB3 fixes

[Linus Torvalds]

On Fri, Jul 7, 2017 at 4:13 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> Also let me know if you want me to change how I do signed tags - since I added
> one for this pull request.

Well, you may have added one, but you don't actually indicate it:

>   git://git.samba.org/sfrench/cifs-2.6.git for-next

That "for-next" is not a signed tag.

I do see a signed tag that is named tags/cifs-bug-fixes-for-4.13 and
points to that same commit, so I'll pull that one instead, but please
make your pull requests actually use the tag itself so that I don't
have to go grep for it..

It would also be good to see a few signatures on your public key, but
it seems to be very recent and I guess that will happen over time..

But I've pulled this thing.

As to:

> Another set, which moves the default dialect up from cifs to smb3, and
> improves set ACL and chmod support is still being reviewed, and I will
> try to have that ready next week"

..things are supposed to be ready by the merge window, and if that
thing turns out to be big and scary (or if I just end up being
stressed out about merging) I may not end up pulling it.

                Linus

[GIT] SMB3 fixes

[Steve French]

First set of CIFS/SMB3 fixes for the merge window.  Also improves
POSIX character
mapping for SMB3.

Another set, which moves the default dialect up from cifs to smb3, and improves
set ACL and chmod support is still being reviewed, and I will try to have that
ready next week.

Also let me know if you want me to change how I do signed tags - since I added
one for this pull request.

Please pull the following changes since commit
6f7da290413ba713f0cdd9ff1a2a9bb129ef4f6c:

  Linux 4.12 (2017-07-02 16:07:02 -0700)

are available in the git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to 966681c9f029afd5decee069b7658bb58ad0a863:

  CIFS: fix circular locking dependency (2017-07-05 20:08:39 -0500)

----------------------------------------------------------------
Arnd Bergmann (1):
      cifs: hide unused functions

Aurélien Aptel (1):
      CIFS: add CONFIG_CIFS_DEBUG_KEYS to dump encryption keys

Björn JACKE (1):
      CIFS: add SFM mapping for 0x01-0x1F

Colin Ian King (1):
      cifs: set oparms.create_options rather than or'ing in
CREATE_OPEN_BACKUP_INTENT

Jeff Layton (1):
      cifs: set mapping error when page writeback fails in writepage
or launder_pages

Long Li (1):
      cifs: Do not modify mid entry after submitting I/O in cifs_call_async

Rabin Vincent (1):
      CIFS: fix circular locking dependency

Shirish Pargaonkar (2):
      cifs: prototype declaration and definition for smb 2 - 3 and
cifsacl mount options
      cifs: Use smb 2 - 3 and cifsacl mount options getacl functions

Steve French (1):
      SMB3: Enable encryption for SMB3.1.1

 fs/cifs/Kconfig         |   9 ++++
 fs/cifs/cifs_unicode.c  |   8 ++++
 fs/cifs/file.c          |  16 ++++---
 fs/cifs/smb2ops.c       | 119 +++++++++++++++++++++++++++++++++++++++++++++++-
 fs/cifs/smb2pdu.c       |  52 ++++++++++++++++-----
 fs/cifs/smb2proto.h     |   3 ++
 fs/cifs/smb2transport.c |  28 ++++++++++--
 fs/cifs/transport.c     |   7 ++-
 8 files changed, 218 insertions(+), 24 deletions(-)

-- 
Thanks,

Steve

[GIT] SMB3 Fixes

[Steve French]

The following includes various fixes for stable for CIFS/SMB3 especially
for better interoperability for SMB3 to Macs. It also includes Pavel's
improvements to SMB3 async i/o support (which is much faster now).

Please pull the following changes since commit
204f144c9fcac355843412b6ba1150086488a208:

  Merge branch 'work.compat' of
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs (2017-05-02
11:54:26 -0700)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to 85435d7a15294f9f7ef23469e6aaf7c5dfcc54f0:

  CIFS: add misssing SFM mapping for doublequote (2017-05-05 08:33:44 -0500)

----------------------------------------------------------------
Björn Jacke (2):
      CIFS: fix mapping of SFM_SPACE and SFM_PERIOD
      CIFS: add misssing SFM mapping for doublequote

Dan Carpenter (1):
      cifs: small underflow in cnvrtDosUnixTm()

Daniel N Pettersson (1):
      cifs: fix IPv6 link local, with scope id, address parsing

David Disseldorp (3):
      cifs: fix leak in FSCTL_ENUM_SNAPS response handling
      cifs: fix CIFS_ENUMERATE_SNAPSHOTS oops
      cifs: fix CIFS_IOC_GET_MNT_INFO oops

Pavel Shilovsky (3):
      CIFS: Add asynchronous context to support kernel AIO
      CIFS: Add asynchronous read support through kernel AIO
      CIFS: Add asynchronous write support through kernel AIO

Rabin Vincent (1):
      CIFS: fix oplock break deadlocks

Steve French (2):
      Set unicode flag on cifs echo request to avoid Mac error
      SMB3: Work around mount failure when using SMB3 dialect to Macs

 fs/cifs/cifs_unicode.c |   6 +
 fs/cifs/cifs_unicode.h |   5 +-
 fs/cifs/cifsfs.c       |  15 ++-
 fs/cifs/cifsglob.h     |  20 +++
 fs/cifs/cifsproto.h    |   3 +
 fs/cifs/cifssmb.c      |   3 +
 fs/cifs/connect.c      |   9 +-
 fs/cifs/file.c         | 357 ++++++++++++++++++++++++++++++++++++-------------
 fs/cifs/ioctl.c        |   4 +
 fs/cifs/misc.c         | 122 ++++++++++++++++-
 fs/cifs/netmisc.c      |   6 +-
 fs/cifs/smb2misc.c     |   5 +-
 fs/cifs/smb2ops.c      |   1 +
 fs/cifs/smb2pdu.c      |  14 +-
 14 files changed, 465 insertions(+), 105 deletions(-)

-- 
Thanks,

Steve

[GIT] SMB3 fixes

[Steve French]

As promised, here is the remaining set of cifs/smb3 fixes for stable
(and a fix for one regression) now that they have had additional
review and testing.  Please pull the following changes since commit
c08e611b7d0169b513e3b4515ffd51ac7f37f22c:

  Merge branch 'linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
(2017-04-10 09:37:43 -0700)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to 67dbea2ce6873f8ba57988ba3e608e8bf61c347f:

  CIFS: Fix SMB3 mount without specifying a security mechanism
(2017-04-13 10:03:26 -0500)

----------------------------------------------------------------
Germano Percossi (3):
      CIFS: reconnect thread reschedule itself
      CIFS: remove bad_network_name flag
      CIFS: store results of cifs_reopen_file to avoid infinite wait

Mark Syms (1):
      CIFS: handle guest access errors to Windows shares

Pavel Shilovsky (2):
      CIFS: Fix null pointer deref during read resp processing
      CIFS: Fix SMB3 mount without specifying a security mechanism

 fs/cifs/cifsglob.h  |  1 -
 fs/cifs/cifsproto.h |  3 +--
 fs/cifs/cifssmb.c   | 15 ++++++++-------
 fs/cifs/connect.c   |  3 +++
 fs/cifs/file.c      |  6 +++---
 fs/cifs/smb2ops.c   |  4 ++--
 fs/cifs/smb2pdu.c   | 19 ++++++++++++-------
 7 files changed, 29 insertions(+), 22 deletions(-)

-- 
Thanks,

Steve

[GIT] SMB3 Fixes

[Steve French]

Some small bug fixes as well as SMB2.1/SMB3 enablement for
DFS (global namespace) which previously was only enabled for CIFS.

Please pull the following changes since commit
6053dc981449718d90a429933e99b441e1adaea6:

  Merge tag 'arm64-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux (2017-03-01
10:32:30 -0800)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to ef65aaede23f75977af56a8c330bb9be8c6e125c:

  smb2: Enforce sec= mount option (2017-03-02 23:13:37 -0600)

----------------------------------------------------------------
Aurelien Aptel (7):
      CIFS: move DFS response parsing out of SMB1 code
      CIFS: add build_path_from_dentry_optional_prefix()
      CIFS: add use_ipc flag to SMB2_ioctl()
      CIFS: let ses->ipc_tid hold smb2 TreeIds
      CIFS: set signing flag in SMB2+ TreeConnect if needed
      CIFS: use DFS pathnames in SMB2+ Create requests
      CIFS: implement get_dfs_refer for SMB2+

Pavel Shilovsky (1):
      CIFS: Fix possible use after free in demultiplex thread

Sachin Prabhu (1):
      smb2: Enforce sec= mount option

Steve French (1):
      CIFS: Fix sparse warnings

 fs/cifs/cifs_dfs_ref.c |   4 +-
 fs/cifs/cifs_unicode.h |   6 +-
 fs/cifs/cifsglob.h     |   5 +-
 fs/cifs/cifspdu.h      |  16 +++--
 fs/cifs/cifsproto.h    |   9 +++
 fs/cifs/cifssmb.c      | 119 ++----------------------------------
 fs/cifs/connect.c      |   3 +-
 fs/cifs/dir.c          |  13 +++-
 fs/cifs/misc.c         | 105 ++++++++++++++++++++++++++++++++
 fs/cifs/sess.c         |   4 +-
 fs/cifs/smb1ops.c      |   1 +
 fs/cifs/smb2file.c     |   3 +-
 fs/cifs/smb2ops.c      | 160 +++++++++++++++++++++++++++++++++++++++++++++----
 fs/cifs/smb2pdu.c      | 154 +++++++++++++++++++++++++++++++++++++++--------
 fs/cifs/smb2pdu.h      |   8 +++
 fs/cifs/smb2proto.h    |   5 +-
 16 files changed, 447 insertions(+), 168 deletions(-)

-- 
Thanks,

Steve

[GIT] SMB3 Fixes

[Steve French]

Please pull the following collection of CIFS/SMB3 fixes.  Includes a
couple bug fixes,  a few for improved debugging of cifs.ko and some
improvements to the way cifs does key generation.  I do have some
additional bug fixes I expect in the next week or two (to address a
problem found by xfstest, and some fixes for SMB3.11 dialect, and a
couple patches that just came in yesterday that I am reviewing).

The following changes since commit 7fdec82af6a9e190e53d07a1463d2a9ac49a8750:

  Merge tag 'xfs-for-linus-4.5' of
git://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs
(2016-01-13 21:15:18 -0800)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to 01b9b0b28626db4a47d7f48744d70abca9914ef1:

  cifs_dbg() outputs an uninitialized buffer in cifs_readdir()
(2016-01-14 14:45:49 -0600)

----------------------------------------------------------------
Arnd Hannemann (1):
      Print IP address of unresponsive server

Jamie Bainbridge (1):
      cifs: Ratelimit kernel log messages

Rabin Vincent (1):
      cifs: fix race between call_async() and reconnect()

Ross Lagerwall (2):
      cifs: Check uniqueid for SMB2+ and return -ESTALE if necessary
      cifs: Allow using O_DIRECT with cache=loose

Steve French (2):
      cifs: Make echo interval tunable
      Prepare for encryption support (first part). Add decryption and
encryption key generation. Thanks to Metze for helping with this.

Vasily Averin (1):
      cifs_dbg() outputs an uninitialized buffer in cifs_readdir()

 fs/cifs/cifs_debug.c    |   2 +-
 fs/cifs/cifs_debug.h    |   9 ++---
 fs/cifs/cifsfs.c        |  17 ++++++++
 fs/cifs/cifsglob.h      |  16 ++++++--
 fs/cifs/cifsproto.h     |   5 ++-
 fs/cifs/connect.c       |  36 +++++++++++++----
 fs/cifs/inode.c         |  24 +++++++++++-
 fs/cifs/misc.c          |   2 +-
 fs/cifs/readdir.c       |   1 +
 fs/cifs/smb2misc.c      |  36 ++++++++++++++---
 fs/cifs/smb2ops.c       |  13 ++++--
 fs/cifs/smb2pdu.c       |  10 ++---
 fs/cifs/smb2pdu.h       |   8 ++--
 fs/cifs/smb2proto.h     |   3 +-
 fs/cifs/smb2transport.c | 102 +++++++++++++++++++++++++++++++++++++++++++++---
 fs/cifs/transport.c     |   6 ++-
 16 files changed, 238 insertions(+), 52 deletions(-)

-- 
Thanks,

Steve

Re: [GIT] SMB3 Fixes

[Steve French]

On Fri, Nov 13, 2015 at 6:43 PM, Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> So I pulled this, but:
>
> On Fri, Nov 13, 2015 at 1:24 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>
>> I will have some additional patches for SMB3 encryption and SMB3.1.1
>> signing (important security features), and also for improving SMB3
>> persistent handle reconnection (setting ChannelSequence number e.g.)
>> that I am still working on but wanted to get this set in since they
>> can stand alone.
>
> So anything you intend to send this merge window and are still working
> on had better be really obvious and small, or clearly bug-fixes.
>
> It's Friday afternoon here, the merge window closes this weekend, and
> it's much too late to still be working on new features that you expect
> to get merged.

Understood.

I would like to get the security improvements in (at least SMB3.1.1 signing),
and they are close to ready but probably can't get the final patch
reviewed in time for Sunday.
The signing patch is about 150 lines of code, but needs one additional
patch and it probably won't be reviewed in time.

-- 
Thanks,

Steve

Re: [GIT] SMB3 Fixes

[Linus Torvalds]

So I pulled this, but:

On Fri, Nov 13, 2015 at 1:24 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> I will have some additional patches for SMB3 encryption and SMB3.1.1
> signing (important security features), and also for improving SMB3
> persistent handle reconnection (setting ChannelSequence number e.g.)
> that I am still working on but wanted to get this set in since they
> can stand alone.

So anything you intend to send this merge window and are still working
on had better be really obvious and small, or clearly bug-fixes.

It's Friday afternoon here, the merge window closes this weekend, and
it's much too late to still be working on new features that you expect
to get merged.

                        Linus

[GIT] SMB3 Fixes

[Steve French]

A collection of SMB3 patches adding some reliability features
(persistent and resilient handles) and improving SMB3 copy offload.
I will have some additional patches for SMB3 encryption and SMB3.1.1
signing (important security features), and also for improving SMB3
persistent handle reconnection (setting ChannelSequence number e.g.)
that I am still working on but wanted to get this set in since they
can stand alone.

Please pull the following changes since commit
523e13455ec9ec4457a5a1d24ff7132949742b70:

  Merge branch 'for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client
(2015-10-31 15:19:36 -0700)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to 7b52e2793a58af61b5d349c2c080437a437a4edb:

  Allow copy offload (CopyChunk) across shares (2015-11-09 09:28:48 -0600)

----------------------------------------------------------------
Steve French (7):
      Allow duplicate extents in SMB3 not just SMB3.1.1
      [SMB3] Add parsing for new mount option controlling persistent handles
      [SMB3] Enable checking for continuous availability and
persistent handle support
      [SMB3] Display persistenthandles in /proc/mounts for SMB3 shares
if enabled
      [SMB3] Send durable handle v2 contexts when use of persistent
handles required
      Add resilienthandles mount parm
      Allow copy offload (CopyChunk) across shares

 fs/cifs/cifsfs.c   |  16 ++-----
 fs/cifs/cifsglob.h |   8 +++-
 fs/cifs/connect.c  |  78 +++++++++++++++++++++++++++++++++
 fs/cifs/ioctl.c    |  11 +++--
 fs/cifs/smb2file.c |  19 +++++++++
 fs/cifs/smb2ops.c  |  10 ++---
 fs/cifs/smb2pdu.c  | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
 fs/cifs/smb2pdu.h  |  45 ++++++++++++++++++++
 fs/cifs/smbfsctl.h |   2 +-
 9 files changed, 287 insertions(+), 25 deletions(-)

-- 
Thanks,

Steve