[PATCH] cifs: remove unused variable ses_selected

[PATCH] cifs: remove unused variable ses_selected

[Muhammad Usama Anjum]

ses_selected is being declared and set at several places. It is not
being used. Remove it.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 fs/cifs/smb2pdu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 19c54b309e39..9a72c22bb189 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -3790,7 +3790,7 @@ void smb2_reconnect_server(struct work_struct *work)
 	struct cifs_tcon *tcon, *tcon2;
 	struct list_head tmp_list, tmp_ses_list;
 	bool tcon_exist = false, ses_exist = false;
-	bool tcon_selected = false, ses_selected = false;
+	bool tcon_selected = false;
 	int rc;
 	bool resched = false;
 
@@ -3807,7 +3807,7 @@ void smb2_reconnect_server(struct work_struct *work)
 	spin_lock(&cifs_tcp_ses_lock);
 	list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
 
-		tcon_selected = ses_selected = false;
+		tcon_selected = false;
 
 		list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
 			if (tcon->need_reconnect || tcon->need_reopen_files) {
@@ -3833,7 +3833,7 @@ void smb2_reconnect_server(struct work_struct *work)
 		spin_lock(&ses->chan_lock);
 		if (!tcon_selected && cifs_chan_needs_reconnect(ses, server)) {
 			list_add_tail(&ses->rlist, &tmp_ses_list);
-			ses_selected = ses_exist = true;
+			ses_exist = true;
 			ses->ses_count++;
 		}
 		spin_unlock(&ses->chan_lock);
-- 
2.30.2

Fwd: [PATCH] cifs: remove unused variable ses_selected

[Steve French]

Shyam,
How did you want to use this field? It is in your patch series but as
he notes it is unused.

---------- Forwarded message ---------
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
Date: Wed, Jan 5, 2022 at 3:38 AM
Subject: [PATCH] cifs: remove unused variable ses_selected
To: Steve French <sfrench@samba.org>, open list:COMMON INTERNET FILE
SYSTEM CLIENT (CIFS) <linux-cifs@vger.kernel.org>, moderated
list:COMMON INTERNET FILE SYSTEM CLIENT (CIFS)
<samba-technical@lists.samba.org>, open list
<linux-kernel@vger.kernel.org>
Cc: <usama.anjum@collabora.com>


ses_selected is being declared and set at several places. It is not
being used. Remove it.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 fs/cifs/smb2pdu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 19c54b309e39..9a72c22bb189 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -3790,7 +3790,7 @@ void smb2_reconnect_server(struct work_struct *work)
        struct cifs_tcon *tcon, *tcon2;
        struct list_head tmp_list, tmp_ses_list;
        bool tcon_exist = false, ses_exist = false;
-       bool tcon_selected = false, ses_selected = false;
+       bool tcon_selected = false;
        int rc;
        bool resched = false;

@@ -3807,7 +3807,7 @@ void smb2_reconnect_server(struct work_struct *work)
        spin_lock(&cifs_tcp_ses_lock);
        list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {

-               tcon_selected = ses_selected = false;
+               tcon_selected = false;

                list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
                        if (tcon->need_reconnect || tcon->need_reopen_files) {
@@ -3833,7 +3833,7 @@ void smb2_reconnect_server(struct work_struct *work)
                spin_lock(&ses->chan_lock);
                if (!tcon_selected && cifs_chan_needs_reconnect(ses, server)) {
                        list_add_tail(&ses->rlist, &tmp_ses_list);
-                       ses_selected = ses_exist = true;
+                       ses_exist = true;
                        ses->ses_count++;
                }
                spin_unlock(&ses->chan_lock);
--
2.30.2



-- 
Thanks,

Steve