[PATCH] automake: add -Werror to CFLAGS

[PATCH] automake: add -Werror to CFLAGS

[Jeff Layton]

With the recent patch to fix the warnings in asn1.c, cifs-utils now
builds without any warnings. Ban them henceforth by adding -Werror for
builds.

Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
---
 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 17ad8e1..d95142a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,4 @@
-AM_CFLAGS = -Wall -Wextra
+AM_CFLAGS = -Wall -Wextra -Werror
 ACLOCAL_AMFLAGS = -I aclocal
 
 root_sbindir = $(ROOTSBINDIR)
-- 
1.7.7.6

Re: [PATCH] automake: add -Werror to CFLAGS

[Steve French]

Good idea - thx

On Mon, Apr 16, 2012 at 1:13 PM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
> With the recent patch to fix the warnings in asn1.c, cifs-utils now
> builds without any warnings. Ban them henceforth by adding -Werror for
> builds.
>
> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> ---
>  Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 17ad8e1..d95142a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1,4 +1,4 @@
> -AM_CFLAGS = -Wall -Wextra
> +AM_CFLAGS = -Wall -Wextra -Werror
>  ACLOCAL_AMFLAGS = -I aclocal
>
>  root_sbindir = $(ROOTSBINDIR)
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve

Re: [PATCH] automake: add -Werror to CFLAGS

[Suresh Jayaraman]

On 04/17/2012 03:03 AM, Steve French wrote:
> Good idea - thx
> 
> On Mon, Apr 16, 2012 at 1:13 PM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
>> With the recent patch to fix the warnings in asn1.c, cifs-utils now
>> builds without any warnings. Ban them henceforth by adding -Werror for
>> builds.
>>
>> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>> ---
>>  Makefile.am |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 17ad8e1..d95142a 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -1,4 +1,4 @@
>> -AM_CFLAGS = -Wall -Wextra
>> +AM_CFLAGS = -Wall -Wextra -Werror
>>  ACLOCAL_AMFLAGS = -I aclocal

Any thoughts on making a similar change to the cifs kernel module
Makefile as well?

I see from the sources that some of arch/ code, a few drivers and perf
are already using it. Perf Makefile treats warnings as errors unless
directed not to and there is a flag to disable treating any warnings as
error (for e.g. by passing WERROR=0).


Suresh

Re: [PATCH] automake: add -Werror to CFLAGS

[Steve French]

On Tue, Apr 17, 2012 at 12:30 AM, Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org> wrote:
> On 04/17/2012 03:03 AM, Steve French wrote:
>> Good idea - thx
>>
>> On Mon, Apr 16, 2012 at 1:13 PM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
>>> With the recent patch to fix the warnings in asn1.c, cifs-utils now
>>> builds without any warnings. Ban them henceforth by adding -Werror for
>>> builds.
>>>
>>> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>>> ---
>>>  Makefile.am |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index 17ad8e1..d95142a 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -1,4 +1,4 @@
>>> -AM_CFLAGS = -Wall -Wextra
>>> +AM_CFLAGS = -Wall -Wextra -Werror
>>>  ACLOCAL_AMFLAGS = -I aclocal
>
> Any thoughts on making a similar change to the cifs kernel module
> Makefile as well?
>
> I see from the sources that some of arch/ code, a few drivers and perf
> are already using it. Perf Makefile treats warnings as errors unless
> directed not to and there is a flag to disable treating any warnings as
> error (for e.g. by passing WERROR=0).

For arch isn't this (PPC specific) flag triggered by config switch

           CONFIG_PPC_WERROR?


How do we see if it is set by default - I couldn't find it.

I like the idea of being strict about warnings, but worry that if
PPC is the only arch that does this, there may be problems
with compilers on some other arch



-- 
Thanks,

Steve

Re: [PATCH] automake: add -Werror to CFLAGS

[Suresh Jayaraman]

On 04/17/2012 08:58 PM, Steve French wrote:
> On Tue, Apr 17, 2012 at 12:30 AM, Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org> wrote:
>> On 04/17/2012 03:03 AM, Steve French wrote:
>>> Good idea - thx
>>>
>>> On Mon, Apr 16, 2012 at 1:13 PM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
>>>> With the recent patch to fix the warnings in asn1.c, cifs-utils now
>>>> builds without any warnings. Ban them henceforth by adding -Werror for
>>>> builds.
>>>>
>>>> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>>>> ---
>>>>  Makefile.am |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/Makefile.am b/Makefile.am
>>>> index 17ad8e1..d95142a 100644
>>>> --- a/Makefile.am
>>>> +++ b/Makefile.am
>>>> @@ -1,4 +1,4 @@
>>>> -AM_CFLAGS = -Wall -Wextra
>>>> +AM_CFLAGS = -Wall -Wextra -Werror
>>>>  ACLOCAL_AMFLAGS = -I aclocal
>>
>> Any thoughts on making a similar change to the cifs kernel module
>> Makefile as well?
>>
>> I see from the sources that some of arch/ code, a few drivers and perf
>> are already using it. Perf Makefile treats warnings as errors unless
>> directed not to and there is a flag to disable treating any warnings as
>> error (for e.g. by passing WERROR=0).
> 
> For arch isn't this (PPC specific) flag triggered by config switch
> 
>            CONFIG_PPC_WERROR?
> 

Oops, arch/ is perhaps not a good example. Perf seems to have a good
example.

> How do we see if it is set by default - I couldn't find it.

>From tools/perf/Makefile

...

# Treat warnings as errors unless directed not to
ifneq ($(WERROR),0)
        CFLAGS_WERROR := -Werror
endif

...

CFLAGS = -fno-omit-frame-pointer -ggdb3 -Wall -Wextra -std=gnu99
$(CFLAGS_WERROR) $(CFLAGS_OPTIMIZE) -D_FORTIFY_SOURCE=2
$(EXTRA_WARNINGS) $(EXTRA_CFLAGS)


Suresh

Re: [PATCH] automake: add -Werror to CFLAGS

[Jeff Layton]

On Mon, 16 Apr 2012 14:13:30 -0400
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:

> With the recent patch to fix the warnings in asn1.c, cifs-utils now
> builds without any warnings. Ban them henceforth by adding -Werror for
> builds.
> 
> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> ---
>  Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 17ad8e1..d95142a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1,4 +1,4 @@
> -AM_CFLAGS = -Wall -Wextra
> +AM_CFLAGS = -Wall -Wextra -Werror
>  ACLOCAL_AMFLAGS = -I aclocal
>  
>  root_sbindir = $(ROOTSBINDIR)

Merged...
-- 
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>