* [PATCH] cifs: use a different reconnect helper for non-cifsd threads
@ 2022-02-15 14:15 Shyam Prasad N
2022-02-15 19:06 ` Paulo Alcantara
0 siblings, 1 reply; 6+ messages in thread
From: Shyam Prasad N @ 2022-02-15 14:15 UTC (permalink / raw)
To: Steve French, CIFS, Paulo Alcantara
Hi Steve,
My patch last week was not sufficient to fix some of the buildbot
failures we saw recently.
Please review and use the following patch for new buildbot runs.
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
--
Regards,
Shyam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cifs: use a different reconnect helper for non-cifsd threads
2022-02-15 14:15 [PATCH] cifs: use a different reconnect helper for non-cifsd threads Shyam Prasad N
@ 2022-02-15 19:06 ` Paulo Alcantara
2022-02-15 19:37 ` Steve French
0 siblings, 1 reply; 6+ messages in thread
From: Paulo Alcantara @ 2022-02-15 19:06 UTC (permalink / raw)
To: Shyam Prasad N, Steve French, CIFS
Hi Shyam,
Shyam Prasad N <nspmangalore@gmail.com> writes:
> My patch last week was not sufficient to fix some of the buildbot
> failures we saw recently.
> Please review and use the following patch for new buildbot runs.
>
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
Patch looks good, however you missed these:
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 053cb449eb16..2e00cd58a8b5 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4416,7 +4416,7 @@ static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tco
*/
if (rc && server->current_fullpath != server->origin_fullpath) {
server->current_fullpath = server->origin_fullpath;
- cifs_reconnect(tcon->ses->server, true);
+ cifs_signal_cifsd_for_reconnect(server, true);
}
dfs_cache_free_tgts(tl);
diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
index ebe236b9d9f5..235aa1b395eb 100644
--- a/fs/cifs/netmisc.c
+++ b/fs/cifs/netmisc.c
@@ -896,7 +896,7 @@ map_and_check_smb_error(struct mid_q_entry *mid, bool logErr)
if (class == ERRSRV && code == ERRbaduid) {
cifs_dbg(FYI, "Server returned 0x%x, reconnecting session...\n",
code);
- cifs_reconnect(mid->server, false);
+ cifs_signal_cifsd_for_reconnect(mid->server, false);
}
}
With that, feel free to add:
Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cifs: use a different reconnect helper for non-cifsd threads
2022-02-15 19:06 ` Paulo Alcantara
@ 2022-02-15 19:37 ` Steve French
2022-02-16 0:41 ` Steve French
0 siblings, 1 reply; 6+ messages in thread
From: Steve French @ 2022-02-15 19:37 UTC (permalink / raw)
To: Paulo Alcantara; +Cc: Shyam Prasad N, CIFS
Updated and tentatively merged into cifs-2.6.git for-next and added acked-by
Shyam,
Let me know if any additional changes you see or feedback.
On Tue, Feb 15, 2022 at 1:06 PM Paulo Alcantara <pc@cjr.nz> wrote:
>
> Hi Shyam,
>
> Shyam Prasad N <nspmangalore@gmail.com> writes:
>
> > My patch last week was not sufficient to fix some of the buildbot
> > failures we saw recently.
> > Please review and use the following patch for new buildbot runs.
> >
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
>
> Patch looks good, however you missed these:
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 053cb449eb16..2e00cd58a8b5 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -4416,7 +4416,7 @@ static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tco
> */
> if (rc && server->current_fullpath != server->origin_fullpath) {
> server->current_fullpath = server->origin_fullpath;
> - cifs_reconnect(tcon->ses->server, true);
> + cifs_signal_cifsd_for_reconnect(server, true);
> }
>
> dfs_cache_free_tgts(tl);
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> index ebe236b9d9f5..235aa1b395eb 100644
> --- a/fs/cifs/netmisc.c
> +++ b/fs/cifs/netmisc.c
> @@ -896,7 +896,7 @@ map_and_check_smb_error(struct mid_q_entry *mid, bool logErr)
> if (class == ERRSRV && code == ERRbaduid) {
> cifs_dbg(FYI, "Server returned 0x%x, reconnecting session...\n",
> code);
> - cifs_reconnect(mid->server, false);
> + cifs_signal_cifsd_for_reconnect(mid->server, false);
> }
> }
>
> With that, feel free to add:
>
> Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cifs: use a different reconnect helper for non-cifsd threads
2022-02-15 19:37 ` Steve French
@ 2022-02-16 0:41 ` Steve French
[not found] ` <CANT5p=qHHCTT0EaQDiYediXNo5ATi1j_gZGhTW6+zyC5m6zY5g@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Steve French @ 2022-02-16 0:41 UTC (permalink / raw)
To: Paulo Alcantara; +Cc: Shyam Prasad N, CIFS
Looks like it passed multichannel buildbot tests with the patch
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/11/builds/180
On Tue, Feb 15, 2022 at 1:37 PM Steve French <smfrench@gmail.com> wrote:
>
> Updated and tentatively merged into cifs-2.6.git for-next and added acked-by
>
> Shyam,
> Let me know if any additional changes you see or feedback.
>
> On Tue, Feb 15, 2022 at 1:06 PM Paulo Alcantara <pc@cjr.nz> wrote:
> >
> > Hi Shyam,
> >
> > Shyam Prasad N <nspmangalore@gmail.com> writes:
> >
> > > My patch last week was not sufficient to fix some of the buildbot
> > > failures we saw recently.
> > > Please review and use the following patch for new buildbot runs.
> > >
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
> >
> > Patch looks good, however you missed these:
> >
> > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> > index 053cb449eb16..2e00cd58a8b5 100644
> > --- a/fs/cifs/connect.c
> > +++ b/fs/cifs/connect.c
> > @@ -4416,7 +4416,7 @@ static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tco
> > */
> > if (rc && server->current_fullpath != server->origin_fullpath) {
> > server->current_fullpath = server->origin_fullpath;
> > - cifs_reconnect(tcon->ses->server, true);
> > + cifs_signal_cifsd_for_reconnect(server, true);
> > }
> >
> > dfs_cache_free_tgts(tl);
> > diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> > index ebe236b9d9f5..235aa1b395eb 100644
> > --- a/fs/cifs/netmisc.c
> > +++ b/fs/cifs/netmisc.c
> > @@ -896,7 +896,7 @@ map_and_check_smb_error(struct mid_q_entry *mid, bool logErr)
> > if (class == ERRSRV && code == ERRbaduid) {
> > cifs_dbg(FYI, "Server returned 0x%x, reconnecting session...\n",
> > code);
> > - cifs_reconnect(mid->server, false);
> > + cifs_signal_cifsd_for_reconnect(mid->server, false);
> > }
> > }
> >
> > With that, feel free to add:
> >
> > Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
>
>
>
> --
> Thanks,
>
> Steve
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cifs: use a different reconnect helper for non-cifsd threads
[not found] ` <CANT5p=qHHCTT0EaQDiYediXNo5ATi1j_gZGhTW6+zyC5m6zY5g@mail.gmail.com>
@ 2022-02-16 3:02 ` Steve French
2022-02-16 15:33 ` Steve French
0 siblings, 1 reply; 6+ messages in thread
From: Steve French @ 2022-02-16 3:02 UTC (permalink / raw)
To: Shyam Prasad N; +Cc: Paulo Alcantara, CIFS
FYI - Running cifs-testing group on it now. Will run DFS tests next
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/903
$ git log --oneline v5.17-rc4..
5279203f772d (HEAD -> for-next, origin/for-next) cifs: use a different
reconnect helper for non-cifsd threads
0c6f4ebf8835 cifs: modefromsids must add an ACE for authenticated users
3d6cc9898efd cifs: fix double free race when mount fails in cifs_get_root()
26d3dadebbcb cifs: do not use uninitialized data in the owner/group sid
dd5a927e4118 cifs: fix set of group SID via NTSD xattrs
9405b5f8b20c smb3: fix snapshot mount option
On Tue, Feb 15, 2022 at 7:51 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Thanks for the review and update, Paulo.
>
> Steve, please run the DFS tests in buildbot as well.
>
> On Wed, 16 Feb, 2022, 06:11 Steve French, <smfrench@gmail.com> wrote:
>>
>> Looks like it passed multichannel buildbot tests with the patch
>>
>> http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/11/builds/180
>>
>> On Tue, Feb 15, 2022 at 1:37 PM Steve French <smfrench@gmail.com> wrote:
>> >
>> > Updated and tentatively merged into cifs-2.6.git for-next and added acked-by
>> >
>> > Shyam,
>> > Let me know if any additional changes you see or feedback.
>> >
>> > On Tue, Feb 15, 2022 at 1:06 PM Paulo Alcantara <pc@cjr.nz> wrote:
>> > >
>> > > Hi Shyam,
>> > >
>> > > Shyam Prasad N <nspmangalore@gmail.com> writes:
>> > >
>> > > > My patch last week was not sufficient to fix some of the buildbot
>> > > > failures we saw recently.
>> > > > Please review and use the following patch for new buildbot runs.
>> > > >
>> > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
>> > >
>> > > Patch looks good, however you missed these:
>> > >
>> > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>> > > index 053cb449eb16..2e00cd58a8b5 100644
>> > > --- a/fs/cifs/connect.c
>> > > +++ b/fs/cifs/connect.c
>> > > @@ -4416,7 +4416,7 @@ static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tco
>> > > */
>> > > if (rc && server->current_fullpath != server->origin_fullpath) {
>> > > server->current_fullpath = server->origin_fullpath;
>> > > - cifs_reconnect(tcon->ses->server, true);
>> > > + cifs_signal_cifsd_for_reconnect(server, true);
>> > > }
>> > >
>> > > dfs_cache_free_tgts(tl);
>> > > diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
>> > > index ebe236b9d9f5..235aa1b395eb 100644
>> > > --- a/fs/cifs/netmisc.c
>> > > +++ b/fs/cifs/netmisc.c
>> > > @@ -896,7 +896,7 @@ map_and_check_smb_error(struct mid_q_entry *mid, bool logErr)
>> > > if (class == ERRSRV && code == ERRbaduid) {
>> > > cifs_dbg(FYI, "Server returned 0x%x, reconnecting session...\n",
>> > > code);
>> > > - cifs_reconnect(mid->server, false);
>> > > + cifs_signal_cifsd_for_reconnect(mid->server, false);
>> > > }
>> > > }
>> > >
>> > > With that, feel free to add:
>> > >
>> > > Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
>> >
>> >
>> >
>> > --
>> > Thanks,
>> >
>> > Steve
>>
>>
>>
>> --
>> Thanks,
>>
>> Steve
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cifs: use a different reconnect helper for non-cifsd threads
2022-02-16 3:02 ` Steve French
@ 2022-02-16 15:33 ` Steve French
0 siblings, 0 replies; 6+ messages in thread
From: Steve French @ 2022-02-16 15:33 UTC (permalink / raw)
To: Shyam Prasad N; +Cc: Paulo Alcantara, CIFS
DFS reconnect tests for SMB3 and SMB3.1.1 failed with that patch
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/3/builds/192
On Tue, Feb 15, 2022 at 9:02 PM Steve French <smfrench@gmail.com> wrote:
>
> FYI - Running cifs-testing group on it now. Will run DFS tests next
>
> http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/903
>
> $ git log --oneline v5.17-rc4..
> 5279203f772d (HEAD -> for-next, origin/for-next) cifs: use a different
> reconnect helper for non-cifsd threads
> 0c6f4ebf8835 cifs: modefromsids must add an ACE for authenticated users
> 3d6cc9898efd cifs: fix double free race when mount fails in cifs_get_root()
> 26d3dadebbcb cifs: do not use uninitialized data in the owner/group sid
> dd5a927e4118 cifs: fix set of group SID via NTSD xattrs
> 9405b5f8b20c smb3: fix snapshot mount option
>
> On Tue, Feb 15, 2022 at 7:51 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > Thanks for the review and update, Paulo.
> >
> > Steve, please run the DFS tests in buildbot as well.
> >
> > On Wed, 16 Feb, 2022, 06:11 Steve French, <smfrench@gmail.com> wrote:
> >>
> >> Looks like it passed multichannel buildbot tests with the patch
> >>
> >> http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/11/builds/180
> >>
> >> On Tue, Feb 15, 2022 at 1:37 PM Steve French <smfrench@gmail.com> wrote:
> >> >
> >> > Updated and tentatively merged into cifs-2.6.git for-next and added acked-by
> >> >
> >> > Shyam,
> >> > Let me know if any additional changes you see or feedback.
> >> >
> >> > On Tue, Feb 15, 2022 at 1:06 PM Paulo Alcantara <pc@cjr.nz> wrote:
> >> > >
> >> > > Hi Shyam,
> >> > >
> >> > > Shyam Prasad N <nspmangalore@gmail.com> writes:
> >> > >
> >> > > > My patch last week was not sufficient to fix some of the buildbot
> >> > > > failures we saw recently.
> >> > > > Please review and use the following patch for new buildbot runs.
> >> > > >
> >> > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
> >> > >
> >> > > Patch looks good, however you missed these:
> >> > >
> >> > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> >> > > index 053cb449eb16..2e00cd58a8b5 100644
> >> > > --- a/fs/cifs/connect.c
> >> > > +++ b/fs/cifs/connect.c
> >> > > @@ -4416,7 +4416,7 @@ static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tco
> >> > > */
> >> > > if (rc && server->current_fullpath != server->origin_fullpath) {
> >> > > server->current_fullpath = server->origin_fullpath;
> >> > > - cifs_reconnect(tcon->ses->server, true);
> >> > > + cifs_signal_cifsd_for_reconnect(server, true);
> >> > > }
> >> > >
> >> > > dfs_cache_free_tgts(tl);
> >> > > diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> >> > > index ebe236b9d9f5..235aa1b395eb 100644
> >> > > --- a/fs/cifs/netmisc.c
> >> > > +++ b/fs/cifs/netmisc.c
> >> > > @@ -896,7 +896,7 @@ map_and_check_smb_error(struct mid_q_entry *mid, bool logErr)
> >> > > if (class == ERRSRV && code == ERRbaduid) {
> >> > > cifs_dbg(FYI, "Server returned 0x%x, reconnecting session...\n",
> >> > > code);
> >> > > - cifs_reconnect(mid->server, false);
> >> > > + cifs_signal_cifsd_for_reconnect(mid->server, false);
> >> > > }
> >> > > }
> >> > >
> >> > > With that, feel free to add:
> >> > >
> >> > > Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
> >> >
> >> >
> >> >
> >> > --
> >> > Thanks,
> >> >
> >> > Steve
> >>
> >>
> >>
> >> --
> >> Thanks,
> >>
> >> Steve
>
>
>
> --
> Thanks,
>
> Steve
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-16 15:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 14:15 [PATCH] cifs: use a different reconnect helper for non-cifsd threads Shyam Prasad N
2022-02-15 19:06 ` Paulo Alcantara
2022-02-15 19:37 ` Steve French
2022-02-16 0:41 ` Steve French
[not found] ` <CANT5p=qHHCTT0EaQDiYediXNo5ATi1j_gZGhTW6+zyC5m6zY5g@mail.gmail.com>
2022-02-16 3:02 ` Steve French
2022-02-16 15:33 ` Steve French
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.