All of lore.kernel.org
 help / color / mirror / Atom feed
* enum conversion warnings
@ 2017-11-23  7:41 Nick Desaulniers
  2017-11-23  7:50   ` Nick Desaulniers
                   ` (4 more replies)
  0 siblings, 5 replies; 17+ messages in thread
From: Nick Desaulniers @ 2017-11-23  7:41 UTC (permalink / raw)
  To: rodrigo.vivi
  Cc: mika.kahola, paulo.r.zanoni, Matthias Kaehlcke,
	Linux Kernel Mailing List

pulling down tot, I'm seeing:

  CC [M]  drivers/gpu/drm/i915/intel_ddi.o
drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
from enumeration type 'enum port' to different enumeration type 'enum
intel_dpll_id' [-Werror,-Wenum-conversion]
        enum intel_dpll_id pll_id = port;
                           ~~~~~~   ^~~~

seems to be coming from commit 2952cd6fb4cc9 "drm/i915: Let's use more
enum intel_dpll_id pll_id."

That commit seems to be using enums instead of uints.  I think maybe
the final 2 hunks of that patch should be reverted?

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [PATCH] drm/i915: Avoid enum conversion warning
  2017-11-23  7:41 enum conversion warnings Nick Desaulniers
@ 2017-11-23  7:50   ` Nick Desaulniers
  2017-11-23  8:58 ` ✗ Fi.CI.BAT: failure for " Patchwork
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 17+ messages in thread
From: Nick Desaulniers @ 2017-11-23  7:50 UTC (permalink / raw)
  Cc: mika.kahola, paulo.r.zanoni, mka, Nick Desaulniers, Jani Nikula,
	Joonas Lahtinen, Rodrigo Vivi, David Airlie, intel-gfx,
	dri-devel, linux-kernel

Fixes the following enum conversion warning:

drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
from enumeration type 'enum port' to different enumeration type 'enum
intel_dpll_id' [-Werror,-Wenum-conversion]
        enum intel_dpll_id pll_id = port;
                           ~~~~~~   ^~~~

Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 933c18fd4258..f9de45316901 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1478,7 +1478,7 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 	enum port port = intel_ddi_get_encoder_port(encoder);
-	enum intel_dpll_id pll_id = port;
+	uint32_t pll_id = port;
 
 	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [PATCH] drm/i915: Avoid enum conversion warning
@ 2017-11-23  7:50   ` Nick Desaulniers
  0 siblings, 0 replies; 17+ messages in thread
From: Nick Desaulniers @ 2017-11-23  7:50 UTC (permalink / raw)
  Cc: paulo.r.zanoni, David Airlie, intel-gfx, Nick Desaulniers,
	linux-kernel, mka, dri-devel, Rodrigo Vivi

Fixes the following enum conversion warning:

drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
from enumeration type 'enum port' to different enumeration type 'enum
intel_dpll_id' [-Werror,-Wenum-conversion]
        enum intel_dpll_id pll_id = port;
                           ~~~~~~   ^~~~

Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 933c18fd4258..f9de45316901 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1478,7 +1478,7 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 	enum port port = intel_ddi_get_encoder_port(encoder);
-	enum intel_dpll_id pll_id = port;
+	uint32_t pll_id = port;
 
 	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
 
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Avoid enum conversion warning
  2017-11-23  7:50   ` Nick Desaulniers
@ 2017-11-23  7:59     ` Daniel Vetter
  -1 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2017-11-23  7:59 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: paulo.r.zanoni, David Airlie, intel-gfx, linux-kernel, mka,
	dri-devel, Rodrigo Vivi

On Wed, Nov 22, 2017 at 11:50:48PM -0800, Nick Desaulniers wrote:
> Fixes the following enum conversion warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
> from enumeration type 'enum port' to different enumeration type 'enum
> intel_dpll_id' [-Werror,-Wenum-conversion]
>         enum intel_dpll_id pll_id = port;
>                            ~~~~~~   ^~~~
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 933c18fd4258..f9de45316901 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1478,7 +1478,7 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
>  {
>  	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>  	enum port port = intel_ddi_get_encoder_port(encoder);
> -	enum intel_dpll_id pll_id = port;
> +	uint32_t pll_id = port;

Please do a cast instead of dropping the dpll enum annotation. Just
shutting up compilers doesn't really help anyone.
-Daniel
>  
>  	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
>  
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Avoid enum conversion warning
@ 2017-11-23  7:59     ` Daniel Vetter
  0 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2017-11-23  7:59 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: paulo.r.zanoni, David Airlie, intel-gfx, linux-kernel, dri-devel,
	mka, Rodrigo Vivi

On Wed, Nov 22, 2017 at 11:50:48PM -0800, Nick Desaulniers wrote:
> Fixes the following enum conversion warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
> from enumeration type 'enum port' to different enumeration type 'enum
> intel_dpll_id' [-Werror,-Wenum-conversion]
>         enum intel_dpll_id pll_id = port;
>                            ~~~~~~   ^~~~
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 933c18fd4258..f9de45316901 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1478,7 +1478,7 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
>  {
>  	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>  	enum port port = intel_ddi_get_encoder_port(encoder);
> -	enum intel_dpll_id pll_id = port;
> +	uint32_t pll_id = port;

Please do a cast instead of dropping the dpll enum annotation. Just
shutting up compilers doesn't really help anyone.
-Daniel
>  
>  	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
>  
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning
  2017-11-23  7:41 enum conversion warnings Nick Desaulniers
  2017-11-23  7:50   ` Nick Desaulniers
@ 2017-11-23  8:58 ` Patchwork
  2017-11-23 11:51   ` Arkadiusz Hiler
  2017-11-23 11:41 ` Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 17+ messages in thread
From: Patchwork @ 2017-11-23  8:58 UTC (permalink / raw)
  To: Nick Desaulniers; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid enum conversion warning
URL   : https://patchwork.freedesktop.org/series/34269/
State : failure

== Summary ==

commit ffa17d69cf53bd5af4d7e41900c3ba40f6656e31
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Nov 23 07:47:39 2017 +0000

    drm-tip: 2017y-11m-23d-07h-46m-50s UTC integration manifest

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning
  2017-11-23  7:41 enum conversion warnings Nick Desaulniers
  2017-11-23  7:50   ` Nick Desaulniers
  2017-11-23  8:58 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-11-23 11:41 ` Patchwork
  2017-11-23 14:12 ` Patchwork
  2017-11-27  3:52 ` ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2) Patchwork
  4 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-11-23 11:41 UTC (permalink / raw)
  To: Nick Desaulniers; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid enum conversion warning
URL   : https://patchwork.freedesktop.org/series/34269/
State : failure

== Summary ==

commit 606231c4d58188daa3a9a02ac6b95f42c4fcf267
Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Date:   Thu Nov 23 12:37:47 2017 +0200

    drm-tip: 2017y-11m-23d-10h-35m-48s UTC integration manifest

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: ✗ Fi.CI.BAT:  failure for drm/i915: Avoid enum conversion warning
  2017-11-23  8:58 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-11-23 11:51   ` Arkadiusz Hiler
  0 siblings, 0 replies; 17+ messages in thread
From: Arkadiusz Hiler @ 2017-11-23 11:51 UTC (permalink / raw)
  To: intel-gfx; +Cc: Nick Desaulniers

On Thu, Nov 23, 2017 at 08:58:47AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Avoid enum conversion warning
> URL   : https://patchwork.freedesktop.org/series/34269/
> State : failure
> 
> == Summary ==

This change does not apply cleanly on top of the commit below:

> commit ffa17d69cf53bd5af4d7e41900c3ba40f6656e31
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Thu Nov 23 07:47:39 2017 +0000
> 
>     drm-tip: 2017y-11m-23d-07h-46m-50s UTC integration manifest

Sorry for confusion.

Typical PEBKAC on my side where I used ">" instead of ">>" which
overwrote the message, instead of appending to it.

Should be fixed from now on.

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning
  2017-11-23  7:41 enum conversion warnings Nick Desaulniers
                   ` (2 preceding siblings ...)
  2017-11-23 11:41 ` Patchwork
@ 2017-11-23 14:12 ` Patchwork
  2017-11-27  3:52 ` ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2) Patchwork
  4 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-11-23 14:12 UTC (permalink / raw)
  To: Nick Desaulniers; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid enum conversion warning
URL   : https://patchwork.freedesktop.org/series/34269/
State : failure

== Summary ==

Applying: drm/i915: Avoid enum conversion warning
Using index info to reconstruct a base tree...
M	drivers/gpu/drm/i915/intel_ddi.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/intel_ddi.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/intel_ddi.c
Patch failed at 0001 drm/i915: Avoid enum conversion warning

Current HEAD:
commit 9d399f81694538228a539de9a908cdf9ef00f814
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date:   Thu Nov 23 12:29:07 2017 +0000

    drm-tip: 2017y-11m-23d-12h-28m-12s UTC integration manifest

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [PATCH v2] drm/i915: Avoid enum conversion warning
  2017-11-23  7:59     ` Daniel Vetter
@ 2017-11-27  3:49       ` Nick Desaulniers
  -1 siblings, 0 replies; 17+ messages in thread
From: Nick Desaulniers @ 2017-11-27  3:49 UTC (permalink / raw)
  Cc: mika.kahola, paulo.r.zanoni, mka, daniel, Nick Desaulniers,
	Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
	intel-gfx, dri-devel, linux-kernel

Fixes the following enum conversion warning:

drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
from enumeration type 'enum port' to different enumeration type 'enum
intel_dpll_id' [-Werror,-Wenum-conversion]
        enum intel_dpll_id pll_id = port;
                           ~~~~~~   ^~~~

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 933c18fd4258..3c346c8cbf78 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1477,8 +1477,8 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
 				struct intel_crtc_state *pipe_config)
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
-	enum port port = intel_ddi_get_encoder_port(encoder);
-	enum intel_dpll_id pll_id = port;
+	enum intel_dpll_id pll_id =
+		(enum intel_dpll_id)intel_ddi_get_encoder_port(encoder);
 
 	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [PATCH v2] drm/i915: Avoid enum conversion warning
@ 2017-11-27  3:49       ` Nick Desaulniers
  0 siblings, 0 replies; 17+ messages in thread
From: Nick Desaulniers @ 2017-11-27  3:49 UTC (permalink / raw)
  Cc: paulo.r.zanoni, David Airlie, intel-gfx, Nick Desaulniers,
	linux-kernel, mka, dri-devel, Rodrigo Vivi

Fixes the following enum conversion warning:

drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
from enumeration type 'enum port' to different enumeration type 'enum
intel_dpll_id' [-Werror,-Wenum-conversion]
        enum intel_dpll_id pll_id = port;
                           ~~~~~~   ^~~~

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 933c18fd4258..3c346c8cbf78 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1477,8 +1477,8 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
 				struct intel_crtc_state *pipe_config)
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
-	enum port port = intel_ddi_get_encoder_port(encoder);
-	enum intel_dpll_id pll_id = port;
+	enum intel_dpll_id pll_id =
+		(enum intel_dpll_id)intel_ddi_get_encoder_port(encoder);
 
 	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
 
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2)
  2017-11-23  7:41 enum conversion warnings Nick Desaulniers
                   ` (3 preceding siblings ...)
  2017-11-23 14:12 ` Patchwork
@ 2017-11-27  3:52 ` Patchwork
  2017-11-27  4:40   ` Nick Desaulniers
  4 siblings, 1 reply; 17+ messages in thread
From: Patchwork @ 2017-11-27  3:52 UTC (permalink / raw)
  To: Nick Desaulniers; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid enum conversion warning (rev2)
URL   : https://patchwork.freedesktop.org/series/34269/
State : failure

== Summary ==

Applying: drm/i915: Avoid enum conversion warning
Using index info to reconstruct a base tree...
M	drivers/gpu/drm/i915/intel_ddi.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/intel_ddi.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/intel_ddi.c
Patch failed at 0001 drm/i915: Avoid enum conversion warning

Current HEAD:
commit 2ac27dcb0eb2b64104e890031705714051be9ef8
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sun Nov 26 19:47:42 2017 +0000

    drm-tip: 2017y-11m-26d-19h-47m-14s UTC integration manifest

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2)
  2017-11-27  3:52 ` ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2) Patchwork
@ 2017-11-27  4:40   ` Nick Desaulniers
  2017-11-27 10:26     ` Joonas Lahtinen
  0 siblings, 1 reply; 17+ messages in thread
From: Nick Desaulniers @ 2017-11-27  4:40 UTC (permalink / raw)
  To: intel-gfx

Do I need to be basing my patches on a different tree than Linus'?  In
general, how do people find what tree they should be basing their
patch off of?

On Sun, Nov 26, 2017 at 7:52 PM, Patchwork
<patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: Avoid enum conversion warning (rev2)
> URL   : https://patchwork.freedesktop.org/series/34269/
> State : failure
>
> == Summary ==
>
> Applying: drm/i915: Avoid enum conversion warning
> Using index info to reconstruct a base tree...
> M       drivers/gpu/drm/i915/intel_ddi.c
> Falling back to patching base and 3-way merge...
> Auto-merging drivers/gpu/drm/i915/intel_ddi.c
> CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/intel_ddi.c
> Patch failed at 0001 drm/i915: Avoid enum conversion warning
>
> Current HEAD:
> commit 2ac27dcb0eb2b64104e890031705714051be9ef8
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Sun Nov 26 19:47:42 2017 +0000
>
>     drm-tip: 2017y-11m-26d-19h-47m-14s UTC integration manifest
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH v2] drm/i915: Avoid enum conversion warning
  2017-11-27  3:49       ` Nick Desaulniers
@ 2017-11-27 10:21         ` Daniel Vetter
  -1 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2017-11-27 10:21 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: mika.kahola, paulo.r.zanoni, mka, daniel, Jani Nikula,
	Joonas Lahtinen, Rodrigo Vivi, David Airlie, intel-gfx,
	dri-devel, linux-kernel

On Sun, Nov 26, 2017 at 07:49:14PM -0800, Nick Desaulniers wrote:
> Fixes the following enum conversion warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
> from enumeration type 'enum port' to different enumeration type 'enum
> intel_dpll_id' [-Werror,-Wenum-conversion]
>         enum intel_dpll_id pll_id = port;
>                            ~~~~~~   ^~~~
> 
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>

This doesn't apply on latest drm-intel.git code anymore, we removed this.
Thanks anyway.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 933c18fd4258..3c346c8cbf78 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1477,8 +1477,8 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
>  				struct intel_crtc_state *pipe_config)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> -	enum port port = intel_ddi_get_encoder_port(encoder);
> -	enum intel_dpll_id pll_id = port;
> +	enum intel_dpll_id pll_id =
> +		(enum intel_dpll_id)intel_ddi_get_encoder_port(encoder);
>  
>  	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
>  
> -- 
> 2.14.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH v2] drm/i915: Avoid enum conversion warning
@ 2017-11-27 10:21         ` Daniel Vetter
  0 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2017-11-27 10:21 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: paulo.r.zanoni, mika.kahola, David Airlie, intel-gfx,
	Joonas Lahtinen, linux-kernel, mka, dri-devel, Rodrigo Vivi

On Sun, Nov 26, 2017 at 07:49:14PM -0800, Nick Desaulniers wrote:
> Fixes the following enum conversion warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion
> from enumeration type 'enum port' to different enumeration type 'enum
> intel_dpll_id' [-Werror,-Wenum-conversion]
>         enum intel_dpll_id pll_id = port;
>                            ~~~~~~   ^~~~
> 
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>

This doesn't apply on latest drm-intel.git code anymore, we removed this.
Thanks anyway.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 933c18fd4258..3c346c8cbf78 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1477,8 +1477,8 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder,
>  				struct intel_crtc_state *pipe_config)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> -	enum port port = intel_ddi_get_encoder_port(encoder);
> -	enum intel_dpll_id pll_id = port;
> +	enum intel_dpll_id pll_id =
> +		(enum intel_dpll_id)intel_ddi_get_encoder_port(encoder);
>  
>  	pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id);
>  
> -- 
> 2.14.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2)
  2017-11-27  4:40   ` Nick Desaulniers
@ 2017-11-27 10:26     ` Joonas Lahtinen
  2017-11-28  7:17       ` Nick Desaulniers
  0 siblings, 1 reply; 17+ messages in thread
From: Joonas Lahtinen @ 2017-11-27 10:26 UTC (permalink / raw)
  To: Nick Desaulniers, intel-gfx

On Sun, 2017-11-26 at 20:40 -0800, Nick Desaulniers wrote:
> Do I need to be basing my patches on a different tree than Linus'?  In
> general, how do people find what tree they should be basing their
> patch off of?

"T:" line from the MAINTAINERS entry would tell you that.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2)
  2017-11-27 10:26     ` Joonas Lahtinen
@ 2017-11-28  7:17       ` Nick Desaulniers
  0 siblings, 0 replies; 17+ messages in thread
From: Nick Desaulniers @ 2017-11-28  7:17 UTC (permalink / raw)
  To: Joonas Lahtinen; +Cc: intel-gfx

On Mon, Nov 27, 2017 at 2:26 AM, Joonas Lahtinen
<joonas.lahtinen@linux.intel.com> wrote:
> On Sun, 2017-11-26 at 20:40 -0800, Nick Desaulniers wrote:
>> In
>> general, how do people find what tree they should be basing their
>> patch off of?
>
> "T:" line from the MAINTAINERS entry would tell you that.

Nice, thanks!
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2017-11-28  7:17 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-23  7:41 enum conversion warnings Nick Desaulniers
2017-11-23  7:50 ` [PATCH] drm/i915: Avoid enum conversion warning Nick Desaulniers
2017-11-23  7:50   ` Nick Desaulniers
2017-11-23  7:59   ` [Intel-gfx] " Daniel Vetter
2017-11-23  7:59     ` Daniel Vetter
2017-11-27  3:49     ` [PATCH v2] " Nick Desaulniers
2017-11-27  3:49       ` Nick Desaulniers
2017-11-27 10:21       ` Daniel Vetter
2017-11-27 10:21         ` Daniel Vetter
2017-11-23  8:58 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-11-23 11:51   ` Arkadiusz Hiler
2017-11-23 11:41 ` Patchwork
2017-11-23 14:12 ` Patchwork
2017-11-27  3:52 ` ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning (rev2) Patchwork
2017-11-27  4:40   ` Nick Desaulniers
2017-11-27 10:26     ` Joonas Lahtinen
2017-11-28  7:17       ` Nick Desaulniers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.