[U-Boot] [PATCH 1/2] coreboot: only init usb if necessary

* [U-Boot] [PATCH 1/2] coreboot: only init usb if necessary
@ 2018-11-30  4:07 Bin Meng
  2018-11-30  4:07 ` [U-Boot] [PATCH 2/2] efi: payload: " Bin Meng
  2018-11-30  7:43 ` [U-Boot] [PATCH 1/2] coreboot: " Christian Gmeiner
  0 siblings, 2 replies; 6+ messages in thread
From: Bin Meng @ 2018-11-30  4:07 UTC (permalink / raw)
  To: u-boot

From: Thomas RIENOESSL <thomas.rienoessl@bachmann.info>

Up until now the call to initialize the USB subsystem was hardcoded
for U-Boot running as a coreboot payload. This was used to enable
the use of a USB keyboard in the U-Boot shell. However not all boards
might need this functionality. As initializing the USB subsystem can
take a considerable amount of time (several seconds on some boards),
we now initialize the USB subsystem only if U-Boot is configured to
use USB keyboards.

Signed-off-by: Thomas RIENOESSL <thomas.rienoessl@bachmann.info>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/cpu/coreboot/coreboot.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/cpu/coreboot/coreboot.c b/arch/x86/cpu/coreboot/coreboot.c
index aaf0d07..4c6ed0b 100644
--- a/arch/x86/cpu/coreboot/coreboot.c
+++ b/arch/x86/cpu/coreboot/coreboot.c
@@ -77,7 +77,8 @@ int last_stage_init(void)
 		timestamp_add_to_bootstage();
 
 	/* start usb so that usb keyboard can be used as input device */
-	usb_init();
+	if (CONFIG_IS_ENABLED(USB_KEYBOARD))
+		usb_init();
 
 	board_final_cleanup();
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread