From: Paul Moore <paul@paul-moore.com> To: Richard Guy Briggs <rgb@redhat.com> Cc: Linux-Audit Mailing List <linux-audit@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Eric Paris <eparis@parisplace.org> Subject: Re: [PATCH v2 1/2] audit: document /proc/PID/loginuid Date: Thu, 18 Mar 2021 15:05:39 -0400 [thread overview] Message-ID: <CAHC9VhQ-cUe9OyEAeMZA3EC4Qa0k2jQuixW-K3UkU01QgG_VXQ@mail.gmail.com> (raw) In-Reply-To: <fa3967b0c74e5497932f0f08c2e67bb5fdd9844b.1616008065.git.rgb@redhat.com> On Wed, Mar 17, 2021 at 9:51 PM Richard Guy Briggs <rgb@redhat.com> wrote: > > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle > loginuid through proc") > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com> > --- > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid > > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid > new file mode 100644 > index 000000000000..013bc1d74854 > --- /dev/null > +++ b/Documentation/ABI/stable/procfs-audit_loginuid > @@ -0,0 +1,15 @@ > +What: Audit Login UID > +Date: 2005-02-01 > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc") > +Contact: linux-audit@redhat.com > +Format: %u (u32) Existing examples seem to just use the printf format specifier, e.g. "%u", without the explicit type, e.g. "u32", which seems cleanest to me. I would suggest changing this to just "Format: %u" to better fit existing convention. > +Users: auditd, libaudit, audit-testsuite, login I didn't get an opportunity to reply to the previous thread before you sent this, but I really don't like listing specific userspace tools/libraries here. I recognize that you like the specificity, but I do not, and I fear that it will become invalid over time either due to deprecation of old packages or omission of new ones; the fact that we are just now adding an entry from 2005 shows how this area of Documentation can often be neglected. Please replace this with something like "audit and login applications" or something similar. -- paul moore www.paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com> To: Richard Guy Briggs <rgb@redhat.com> Cc: Eric Paris <eparis@parisplace.org>, Linux-Audit Mailing List <linux-audit@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 1/2] audit: document /proc/PID/loginuid Date: Thu, 18 Mar 2021 15:05:39 -0400 [thread overview] Message-ID: <CAHC9VhQ-cUe9OyEAeMZA3EC4Qa0k2jQuixW-K3UkU01QgG_VXQ@mail.gmail.com> (raw) In-Reply-To: <fa3967b0c74e5497932f0f08c2e67bb5fdd9844b.1616008065.git.rgb@redhat.com> On Wed, Mar 17, 2021 at 9:51 PM Richard Guy Briggs <rgb@redhat.com> wrote: > > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle > loginuid through proc") > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com> > --- > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid > > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid > new file mode 100644 > index 000000000000..013bc1d74854 > --- /dev/null > +++ b/Documentation/ABI/stable/procfs-audit_loginuid > @@ -0,0 +1,15 @@ > +What: Audit Login UID > +Date: 2005-02-01 > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc") > +Contact: linux-audit@redhat.com > +Format: %u (u32) Existing examples seem to just use the printf format specifier, e.g. "%u", without the explicit type, e.g. "u32", which seems cleanest to me. I would suggest changing this to just "Format: %u" to better fit existing convention. > +Users: auditd, libaudit, audit-testsuite, login I didn't get an opportunity to reply to the previous thread before you sent this, but I really don't like listing specific userspace tools/libraries here. I recognize that you like the specificity, but I do not, and I fear that it will become invalid over time either due to deprecation of old packages or omission of new ones; the fact that we are just now adding an entry from 2005 shows how this area of Documentation can often be neglected. Please replace this with something like "audit and login applications" or something similar. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-03-18 19:06 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-18 1:50 [PATCH v2 0/2] audit: add documentation for /proc/PID/stable interfaces Richard Guy Briggs 2021-03-18 1:50 ` Richard Guy Briggs 2021-03-18 1:50 ` [PATCH v2 1/2] audit: document /proc/PID/loginuid Richard Guy Briggs 2021-03-18 1:50 ` Richard Guy Briggs 2021-03-18 19:05 ` Paul Moore [this message] 2021-03-18 19:05 ` Paul Moore 2021-03-18 1:50 ` [PATCH v2 2/2] audit: document /proc/PID/sessionid Richard Guy Briggs 2021-03-18 1:50 ` Richard Guy Briggs 2021-03-18 19:06 ` Paul Moore 2021-03-18 19:06 ` Paul Moore
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHC9VhQ-cUe9OyEAeMZA3EC4Qa0k2jQuixW-K3UkU01QgG_VXQ@mail.gmail.com \ --to=paul@paul-moore.com \ --cc=eparis@parisplace.org \ --cc=linux-audit@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rgb@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.