From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: casey.schaufler@intel.com, jmorris@namei.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
linux-audit@redhat.com, keescook@chromium.org,
john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp
Subject: Re: [PATCH v32 24/28] Audit: Add framework for auxiliary records
Date: Thu, 3 Mar 2022 17:43:22 -0500 [thread overview]
Message-ID: <CAHC9VhQ1J5jFTSJk-EFkdA-dbsjde7BoXJOX_2ZgL=usrpJ5Eg@mail.gmail.com> (raw)
In-Reply-To: <4e4ef3e2-ab41-12fd-5cd3-77abfc98c6a2@schaufler-ca.com>
On Thu, Mar 3, 2022 at 5:33 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
> On 3/3/2022 2:27 PM, Paul Moore wrote:
> > On Wed, Mar 2, 2022 at 5:32 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
> >> On 2/2/2022 3:53 PM, Casey Schaufler wrote:
> >>> Add a list for auxiliary record data to the audit_buffer structure.
> >>> Add the audit_stamp information to the audit_buffer as there's no
> >>> guarantee that there will be an audit_context containing the stamp
> >>> associated with the event. At audit_log_end() time create auxiliary
> >>> records (none are currently defined) as have been added to the list.
> >>>
> >>> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> >> I'm really hoping for either Acks or feedback on this approach.
> > The only callers that make use of this functionality in this patchset
> > is in kernel/audit*.c in patches 25/28 and 26/28, yes?
>
> Yes.
Thanks. I just wanted to make sure you weren't planning on any
additional callers in a future revision. I understand that things may
change, but I just wanted to make sure there wasn't already something
pending.
> I think that the container ID record could use it as well.
> I haven't looked deeply, but it should be usable for any aux record type.
Possibly, but I'm intentionally trying to keep that separated at this
stage as the ordering is uncertain. If/when both bits of
functionality land we can reconcile things as needed; it's all
internal implementation details so we don't have to worry too much
about changing it later.
--
paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: john.johansen@canonical.com, selinux@vger.kernel.org,
jmorris@namei.org, linux-security-module@vger.kernel.org,
linux-audit@redhat.com, casey.schaufler@intel.com
Subject: Re: [PATCH v32 24/28] Audit: Add framework for auxiliary records
Date: Thu, 3 Mar 2022 17:43:22 -0500 [thread overview]
Message-ID: <CAHC9VhQ1J5jFTSJk-EFkdA-dbsjde7BoXJOX_2ZgL=usrpJ5Eg@mail.gmail.com> (raw)
In-Reply-To: <4e4ef3e2-ab41-12fd-5cd3-77abfc98c6a2@schaufler-ca.com>
On Thu, Mar 3, 2022 at 5:33 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
> On 3/3/2022 2:27 PM, Paul Moore wrote:
> > On Wed, Mar 2, 2022 at 5:32 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
> >> On 2/2/2022 3:53 PM, Casey Schaufler wrote:
> >>> Add a list for auxiliary record data to the audit_buffer structure.
> >>> Add the audit_stamp information to the audit_buffer as there's no
> >>> guarantee that there will be an audit_context containing the stamp
> >>> associated with the event. At audit_log_end() time create auxiliary
> >>> records (none are currently defined) as have been added to the list.
> >>>
> >>> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> >> I'm really hoping for either Acks or feedback on this approach.
> > The only callers that make use of this functionality in this patchset
> > is in kernel/audit*.c in patches 25/28 and 26/28, yes?
>
> Yes.
Thanks. I just wanted to make sure you weren't planning on any
additional callers in a future revision. I understand that things may
change, but I just wanted to make sure there wasn't already something
pending.
> I think that the container ID record could use it as well.
> I haven't looked deeply, but it should be usable for any aux record type.
Possibly, but I'm intentionally trying to keep that separated at this
stage as the ordering is uncertain. If/when both bits of
functionality land we can reconcile things as needed; it's all
internal implementation details so we don't have to worry too much
about changing it later.
--
paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2022-03-03 22:43 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220202235323.23929-1-casey.ref@schaufler-ca.com>
2022-02-02 23:52 ` [PATCH v32 00/28] LSM: Module stacking for AppArmor Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 01/28] integrity: disassociate ima_filter_rule from security_audit_rule Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 02/28] LSM: Infrastructure management of the sock security Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 03/28] LSM: Add the lsmblob data structure Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-03-04 10:48 ` Mickaël Salaün
2022-03-04 10:48 ` Mickaël Salaün
2022-03-04 19:14 ` Casey Schaufler
2022-03-04 19:14 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 04/28] LSM: provide lsm name and id slot mappings Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 05/28] IMA: avoid label collisions with stacked LSMs Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-22 23:20 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 06/28] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 07/28] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 08/28] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 09/28] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 10/28] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 11/28] LSM: Use lsmblob in security_current_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 12/28] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 13/28] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-03 5:23 ` kernel test robot
2022-02-03 5:23 ` kernel test robot
2022-02-03 14:07 ` kernel test robot
2022-02-02 23:53 ` [PATCH v32 14/28] LSM: Specify which LSM to display Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 15/28] LSM: Ensure the correct LSM context releaser Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 16/28] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 17/28] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 18/28] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 19/28] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 20/28] binder: Pass LSM identifier for confirmation Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 21/28] LSM: Extend security_secid_to_secctx to include module selection Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 22/28] Audit: Keep multiple LSM data in audit_names Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 23/28] Audit: Create audit_stamp structure Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 24/28] Audit: Add framework for auxiliary records Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-03 6:34 ` kernel test robot
2022-02-03 22:33 ` [RFC PATCH] Audit: __audit_log_end() can be static kernel test robot
2022-02-04 1:30 ` [PATCH v32 24/28] Audit: Add framework for auxiliary records kernel test robot
2022-03-02 22:32 ` Casey Schaufler
2022-03-02 22:32 ` Casey Schaufler
2022-03-03 22:27 ` Paul Moore
2022-03-03 22:27 ` Paul Moore
2022-03-03 22:33 ` Casey Schaufler
2022-03-03 22:33 ` Casey Schaufler
2022-03-03 22:43 ` Paul Moore [this message]
2022-03-03 22:43 ` Paul Moore
2022-03-03 22:55 ` Casey Schaufler
2022-03-03 22:55 ` Casey Schaufler
2022-03-03 23:36 ` Paul Moore
2022-03-03 23:36 ` Paul Moore
2022-03-04 2:13 ` Casey Schaufler
2022-03-04 2:13 ` Casey Schaufler
2022-03-04 14:43 ` Paul Moore
2022-03-04 14:43 ` Paul Moore
2022-02-02 23:53 ` [PATCH v32 25/28] Audit: Add record for multiple task security contexts Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 26/28] Audit: Add record for multiple object " Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-03 5:23 ` kernel test robot
2022-02-03 5:43 ` kernel test robot
2022-03-03 23:36 ` Paul Moore
2022-03-03 23:36 ` Paul Moore
2022-03-04 1:26 ` Casey Schaufler
2022-03-04 1:26 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 27/28] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 28/28] AppArmor: Remove the exclusive flag Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhQ1J5jFTSJk-EFkdA-dbsjde7BoXJOX_2ZgL=usrpJ5Eg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=casey.schaufler@intel.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-audit@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.