From: Paul Moore <paul@paul-moore.com> To: Sven Schnelle <svens@linux.ibm.com> Cc: Eric Paris <eparis@redhat.com>, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] audit: add filterkey to special audit messages Date: Tue, 3 May 2022 12:57:21 -0400 [thread overview] Message-ID: <CAHC9VhQ44G1oXLHTf7FmqwzYBRNW=5EPHod1uMTLhaY3sK_Qeg@mail.gmail.com> (raw) In-Reply-To: <20220503090212.1322050-2-svens@linux.ibm.com> On Tue, May 3, 2022 at 5:02 AM Sven Schnelle <svens@linux.ibm.com> wrote: > > For automated filtering/testing it is useful to have the > filter key logged in the message. > > Signed-off-by: Sven Schnelle <svens@linux.ibm.com> > --- > kernel/auditsc.c | 1 + > 1 file changed, 1 insertion(+) The SOCKETCALL record, along with all of the others generated inside show_special(), are associated with a SYSCALL record which carries the "key=" field. As a general rule we try very hard not to duplicate fields across records in a single audit event. > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index c856893041c9..2e349660a56f 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -1508,6 +1508,7 @@ static void show_special(struct audit_context *context, int *call_panic) > audit_log_time(context, &ab); > break; > } > + audit_log_key(ab, context->filterkey); > audit_log_end(ab); > } > > -- > 2.32.0 -- paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com> To: Sven Schnelle <svens@linux.ibm.com> Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com> Subject: Re: [PATCH 2/2] audit: add filterkey to special audit messages Date: Tue, 3 May 2022 12:57:21 -0400 [thread overview] Message-ID: <CAHC9VhQ44G1oXLHTf7FmqwzYBRNW=5EPHod1uMTLhaY3sK_Qeg@mail.gmail.com> (raw) In-Reply-To: <20220503090212.1322050-2-svens@linux.ibm.com> On Tue, May 3, 2022 at 5:02 AM Sven Schnelle <svens@linux.ibm.com> wrote: > > For automated filtering/testing it is useful to have the > filter key logged in the message. > > Signed-off-by: Sven Schnelle <svens@linux.ibm.com> > --- > kernel/auditsc.c | 1 + > 1 file changed, 1 insertion(+) The SOCKETCALL record, along with all of the others generated inside show_special(), are associated with a SYSCALL record which carries the "key=" field. As a general rule we try very hard not to duplicate fields across records in a single audit event. > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index c856893041c9..2e349660a56f 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -1508,6 +1508,7 @@ static void show_special(struct audit_context *context, int *call_panic) > audit_log_time(context, &ab); > break; > } > + audit_log_key(ab, context->filterkey); > audit_log_end(ab); > } > > -- > 2.32.0 -- paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2022-05-03 16:57 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-03 9:02 [PATCH 1/2] audit: add call argument to socketcall auditing Sven Schnelle 2022-05-03 9:02 ` Sven Schnelle 2022-05-03 9:02 ` [PATCH 2/2] audit: add filterkey to special audit messages Sven Schnelle 2022-05-03 9:02 ` Sven Schnelle 2022-05-03 16:57 ` Paul Moore [this message] 2022-05-03 16:57 ` Paul Moore 2022-05-04 5:22 ` Sven Schnelle 2022-05-04 5:22 ` Sven Schnelle 2022-05-03 13:32 ` [PATCH 1/2] audit: add call argument to socketcall auditing kernel test robot 2022-05-03 13:32 ` kernel test robot 2022-05-03 13:32 ` kernel test robot 2022-05-03 13:32 ` kernel test robot 2022-05-03 14:04 ` kernel test robot 2022-05-03 14:04 ` kernel test robot 2022-05-03 16:07 ` Paul Moore 2022-05-03 16:07 ` Paul Moore 2022-05-03 17:16 ` Steve Grubb 2022-05-03 17:16 ` Steve Grubb
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHC9VhQ44G1oXLHTf7FmqwzYBRNW=5EPHod1uMTLhaY3sK_Qeg@mail.gmail.com' \ --to=paul@paul-moore.com \ --cc=eparis@redhat.com \ --cc=linux-audit@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=svens@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.