* [PATCH] security: hooks : Prevent security to persist in memory (PR #31)
@ 2017-04-23 0:53 Pirabarlen-Cheenaramen
2017-04-25 21:21 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Pirabarlen-Cheenaramen @ 2017-04-23 0:53 UTC (permalink / raw)
To: selinux
Signed-off-by: Pirabarlen-Cheenaramen <selven@hackers.mu>
---
security/selinux/hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index d98550a..9f82908 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -4944,7 +4944,7 @@ static int selinux_tun_dev_alloc_security(void **security)
static void selinux_tun_dev_free_security(void *security)
{
- kfree(security);
+ kzfree(security);
}
static int selinux_tun_dev_create(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] security: hooks : Prevent security to persist in memory (PR #31)
2017-04-23 0:53 [PATCH] security: hooks : Prevent security to persist in memory (PR #31) Pirabarlen-Cheenaramen
@ 2017-04-25 21:21 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2017-04-25 21:21 UTC (permalink / raw)
To: Pirabarlen-Cheenaramen; +Cc: selinux
On Sat, Apr 22, 2017 at 8:53 PM, Pirabarlen-Cheenaramen
<selven@hackers.mu> wrote:
> Signed-off-by: Pirabarlen-Cheenaramen <selven@hackers.mu>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index d98550a..9f82908 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -4944,7 +4944,7 @@ static int selinux_tun_dev_alloc_security(void **security)
>
> static void selinux_tun_dev_free_security(void *security)
> {
> - kfree(security);
> + kzfree(security);
As a general rule we don't zero out memory before free'ing it, you
need to provide some additional information as to why this is required
here.
> }
>
> static int selinux_tun_dev_create(void)
> --
> 1.9.1
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-25 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-23 0:53 [PATCH] security: hooks : Prevent security to persist in memory (PR #31) Pirabarlen-Cheenaramen
2017-04-25 21:21 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.