All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Shreenidhi Shedi <yesshedi@gmail.com>
Cc: eparis@redhat.com, linux-kernel@vger.kernel.org,
	linux-audit@redhat.com, Shreenidhi Shedi <sshedi@vmware.com>
Subject: Re: [PATCH 2/2] audit: fix most of the checkpatch.pl warnnings & errors
Date: Sun, 15 May 2022 19:44:23 -0400	[thread overview]
Message-ID: <CAHC9VhRPTV2sDdGgczLAN7dW+kkX06=1=Qas4QGztXtricBjag@mail.gmail.com> (raw)
In-Reply-To: <20220515073110.304193-2-sshedi@vmware.com>

On Sun, May 15, 2022 at 3:31 AM Shreenidhi Shedi <yesshedi@gmail.com> wrote:
>
> This commit fixes almost all styling issues reported by checkpatch.pl
> script.
>
> Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
> ---
>  kernel/audit.c | 205 ++++++++++++++++++++++++++++++-------------------
>  1 file changed, 127 insertions(+), 78 deletions(-)

Please don't send me patches like this unless you are an established
contributor to the audit subsystem, and even then I would strongly
encourage you to think long and hard before hitting send.

Most of this patch is just comment formatting churn, which is okay if
you are doing something else in a nearby section of code, but a +200
line patch of such changes is not okay.  The printk ratelimiting
changes are probably okay to submit in a separate patch, but I didn't
look at all of them.  Although some of the pr_cont() to pr_info()
conversions warrant a closer look.  The EXPORT_SYMBOL() relocations
are probably also okay is sent as a separate patch.

-- 
paul-moore.com

WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com>
To: Shreenidhi Shedi <yesshedi@gmail.com>
Cc: Shreenidhi Shedi <sshedi@vmware.com>,
	linux-audit@redhat.com, linux-kernel@vger.kernel.org,
	eparis@redhat.com
Subject: Re: [PATCH 2/2] audit: fix most of the checkpatch.pl warnnings & errors
Date: Sun, 15 May 2022 19:44:23 -0400	[thread overview]
Message-ID: <CAHC9VhRPTV2sDdGgczLAN7dW+kkX06=1=Qas4QGztXtricBjag@mail.gmail.com> (raw)
In-Reply-To: <20220515073110.304193-2-sshedi@vmware.com>

On Sun, May 15, 2022 at 3:31 AM Shreenidhi Shedi <yesshedi@gmail.com> wrote:
>
> This commit fixes almost all styling issues reported by checkpatch.pl
> script.
>
> Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
> ---
>  kernel/audit.c | 205 ++++++++++++++++++++++++++++++-------------------
>  1 file changed, 127 insertions(+), 78 deletions(-)

Please don't send me patches like this unless you are an established
contributor to the audit subsystem, and even then I would strongly
encourage you to think long and hard before hitting send.

Most of this patch is just comment formatting churn, which is okay if
you are doing something else in a nearby section of code, but a +200
line patch of such changes is not okay.  The printk ratelimiting
changes are probably okay to submit in a separate patch, but I didn't
look at all of them.  Although some of the pr_cont() to pr_info()
conversions warrant a closer look.  The EXPORT_SYMBOL() relocations
are probably also okay is sent as a separate patch.

-- 
paul-moore.com

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  reply	other threads:[~2022-05-15 23:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15  7:31 [PATCH 1/2] audit: remove redundant data_len check Shreenidhi Shedi
2022-05-15  7:31 ` Shreenidhi Shedi
2022-05-15  7:31 ` [PATCH 2/2] audit: fix most of the checkpatch.pl warnnings & errors Shreenidhi Shedi
2022-05-15  7:31   ` Shreenidhi Shedi
2022-05-15 23:44   ` Paul Moore [this message]
2022-05-15 23:44     ` Paul Moore
2022-05-15 23:35 ` [PATCH 1/2] audit: remove redundant data_len check Paul Moore
2022-05-15 23:35   ` Paul Moore
2022-06-07 20:01   ` Paul Moore
2022-06-07 20:01     ` Paul Moore
2022-06-08  8:43     ` Shreenidhi Shedi
2022-06-08  8:43       ` Shreenidhi Shedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHC9VhRPTV2sDdGgczLAN7dW+kkX06=1=Qas4QGztXtricBjag@mail.gmail.com' \
    --to=paul@paul-moore.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sshedi@vmware.com \
    --cc=yesshedi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.