* [PATCH v3] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND.
[not found] <[PATCH] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND.>
@ 2020-01-06 16:01 ` Ravi Kumar Siddojigari
2020-01-07 2:28 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: Ravi Kumar Siddojigari @ 2020-01-06 16:01 UTC (permalink / raw)
To: selinux; +Cc: Ravi Kumar Siddojigari
please find the updated patch based on the review comments
Move cache based pkey sid retrieval code which was added
with Commit "409dcf31" under CONFIG_SECURITY_INFINIBAND.
As its going to alloc a new cache which impacts
low ram devices which was enabled by default.
Suggested-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
---
security/selinux/Makefile | 4 +++-
security/selinux/include/ibpkey.h | 13 +++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index ccf950409384..2000f95fb197 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -6,7 +6,7 @@
obj-$(CONFIG_SECURITY_SELINUX) := selinux.o
selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \
- netnode.o netport.o ibpkey.o \
+ netnode.o netport.o \
ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \
ss/policydb.o ss/services.o ss/conditional.o ss/mls.o ss/status.o
@@ -14,6 +14,8 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
selinux-$(CONFIG_NETLABEL) += netlabel.o
+selinux-$(CONFIG_SECURITY_INFINIBAND) += ibpkey.o
+
ccflags-y := -I$(srctree)/security/selinux -I$(srctree)/security/selinux/include
$(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
diff --git a/security/selinux/include/ibpkey.h b/security/selinux/include/ibpkey.h
index a2ebe397bcb7..040b93cca486 100644
--- a/security/selinux/include/ibpkey.h
+++ b/security/selinux/include/ibpkey.h
@@ -14,8 +14,21 @@
#ifndef _SELINUX_IB_PKEY_H
#define _SELINUX_IB_PKEY_H
+#ifdef CONFIG_SECURITY_INFINIBAND
void sel_ib_pkey_flush(void);
int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid);
+#else
+
+static inline void sel_ib_pkey_flush(void) {
+ return;
+}
+
+static inline int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid) {
+ *sid = SECINITSID_UNLABELED;
+ return 0;
+}
Move cache based pkey sid retrieval code which was added
with Commit "409dcf31" under CONFIG_SECURITY_INFINIBAND.
As its going to alloc a new cache which impacts
low ram devices which was enabled by default.
Suggested-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
---
security/selinux/Makefile | 4 +++-
security/selinux/include/ibpkey.h | 13 +++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index ccf950409384..2000f95fb197 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -6,7 +6,7 @@
obj-$(CONFIG_SECURITY_SELINUX) := selinux.o
selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \
- netnode.o netport.o ibpkey.o \
+ netnode.o netport.o \
ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \
ss/policydb.o ss/services.o ss/conditional.o ss/mls.o ss/status.o
@@ -14,6 +14,8 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
selinux-$(CONFIG_NETLABEL) += netlabel.o
+selinux-$(CONFIG_SECURITY_INFINIBAND) += ibpkey.o
+
ccflags-y := -I$(srctree)/security/selinux -I$(srctree)/security/selinux/include
$(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
diff --git a/security/selinux/include/ibpkey.h b/security/selinux/include/ibpkey.h
index a2ebe397bcb7..040b93cca486 100644
--- a/security/selinux/include/ibpkey.h
+++ b/security/selinux/include/ibpkey.h
@@ -14,8 +14,21 @@
#ifndef _SELINUX_IB_PKEY_H
#define _SELINUX_IB_PKEY_H
+#ifdef CONFIG_SECURITY_INFINIBAND
void sel_ib_pkey_flush(void);
int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid);
+#else
+
+static inline void sel_ib_pkey_flush(void) {
+ return;
+}
+
+static inline int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid) {
+ *sid = SECINITSID_UNLABELED;
+ return 0;
+}
+#endif
+
#endif
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND.
2020-01-06 16:01 ` [PATCH v3] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND Ravi Kumar Siddojigari
@ 2020-01-07 2:28 ` Paul Moore
2020-01-07 15:21 ` Ravi Kumar Siddojigari
0 siblings, 1 reply; 4+ messages in thread
From: Paul Moore @ 2020-01-07 2:28 UTC (permalink / raw)
To: Ravi Kumar Siddojigari; +Cc: selinux
On Mon, Jan 6, 2020 at 11:03 AM Ravi Kumar Siddojigari
<rsiddoji@codeaurora.org> wrote:
> please find the updated patch based on the review comments
Hi Ravi,
I'm not sure how you are posting your patches to the list, but it is
causing the patches to be malformed; I am not able to merge this patch
in its current condition.
I believe Stephen already provided you some tips on posting patches,
but please also go and read the
"Documentation/process/submitting-patches.rst" which can be found in
the Linux Kernel sources. If you have any questions about how to
submit patches after reading that file please let me know.
-Paul
> Move cache based pkey sid retrieval code which was added
> with Commit "409dcf31" under CONFIG_SECURITY_INFINIBAND.
> As its going to alloc a new cache which impacts
> low ram devices which was enabled by default.
>
> Suggested-by: Paul Moore <paul@paul-moore.com>
> Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
> ---
> security/selinux/Makefile | 4 +++-
> security/selinux/include/ibpkey.h | 13 +++++++++++++
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/security/selinux/Makefile b/security/selinux/Makefile
> index ccf950409384..2000f95fb197 100644
> --- a/security/selinux/Makefile
> +++ b/security/selinux/Makefile
> @@ -6,7 +6,7 @@
> obj-$(CONFIG_SECURITY_SELINUX) := selinux.o
>
> selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \
> - netnode.o netport.o ibpkey.o \
> + netnode.o netport.o \
> ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \
> ss/policydb.o ss/services.o ss/conditional.o ss/mls.o ss/status.o
>
> @@ -14,6 +14,8 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
>
> selinux-$(CONFIG_NETLABEL) += netlabel.o
>
> +selinux-$(CONFIG_SECURITY_INFINIBAND) += ibpkey.o
> +
> ccflags-y := -I$(srctree)/security/selinux -I$(srctree)/security/selinux/include
>
> $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
> diff --git a/security/selinux/include/ibpkey.h b/security/selinux/include/ibpkey.h
> index a2ebe397bcb7..040b93cca486 100644
> --- a/security/selinux/include/ibpkey.h
> +++ b/security/selinux/include/ibpkey.h
> @@ -14,8 +14,21 @@
> #ifndef _SELINUX_IB_PKEY_H
> #define _SELINUX_IB_PKEY_H
>
> +#ifdef CONFIG_SECURITY_INFINIBAND
> void sel_ib_pkey_flush(void);
>
> int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid);
>
> +#else
> +
> +static inline void sel_ib_pkey_flush(void) {
> + return;
> +}
> +
> +static inline int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid) {
> + *sid = SECINITSID_UNLABELED;
> + return 0;
> +}
> Move cache based pkey sid retrieval code which was added
> with Commit "409dcf31" under CONFIG_SECURITY_INFINIBAND.
> As its going to alloc a new cache which impacts
> low ram devices which was enabled by default.
>
> Suggested-by: Paul Moore <paul@paul-moore.com>
> Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
> ---
> security/selinux/Makefile | 4 +++-
> security/selinux/include/ibpkey.h | 13 +++++++++++++
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/security/selinux/Makefile b/security/selinux/Makefile
> index ccf950409384..2000f95fb197 100644
> --- a/security/selinux/Makefile
> +++ b/security/selinux/Makefile
> @@ -6,7 +6,7 @@
> obj-$(CONFIG_SECURITY_SELINUX) := selinux.o
>
> selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \
> - netnode.o netport.o ibpkey.o \
> + netnode.o netport.o \
> ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \
> ss/policydb.o ss/services.o ss/conditional.o ss/mls.o ss/status.o
>
> @@ -14,6 +14,8 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
>
> selinux-$(CONFIG_NETLABEL) += netlabel.o
>
> +selinux-$(CONFIG_SECURITY_INFINIBAND) += ibpkey.o
> +
> ccflags-y := -I$(srctree)/security/selinux -I$(srctree)/security/selinux/include
>
> $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
> diff --git a/security/selinux/include/ibpkey.h b/security/selinux/include/ibpkey.h
> index a2ebe397bcb7..040b93cca486 100644
> --- a/security/selinux/include/ibpkey.h
> +++ b/security/selinux/include/ibpkey.h
> @@ -14,8 +14,21 @@
> #ifndef _SELINUX_IB_PKEY_H
> #define _SELINUX_IB_PKEY_H
>
> +#ifdef CONFIG_SECURITY_INFINIBAND
> void sel_ib_pkey_flush(void);
>
> int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid);
>
> +#else
> +
> +static inline void sel_ib_pkey_flush(void) {
> + return;
> +}
> +
> +static inline int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid) {
> + *sid = SECINITSID_UNLABELED;
> + return 0;
> +}
> +#endif
> +
> #endif
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND.
2020-01-07 2:28 ` Paul Moore
@ 2020-01-07 15:21 ` Ravi Kumar Siddojigari
2020-01-07 16:27 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: Ravi Kumar Siddojigari @ 2020-01-07 15:21 UTC (permalink / raw)
To: Paul Moore; +Cc: selinux
Move cache based pkey sid retrieval code which was added
with Commit "409dcf31" under CONFIG_SECURITY_INFINIBAND.
As its going to alloc a new cache which impacts
low ram devices which was enabled by default.
Suggested-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
---
security/selinux/Makefile | 4 +++-
security/selinux/include/ibpkey.h | 13 +++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index ccf950409384..2000f95fb197 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -6,7 +6,7 @@
obj-$(CONFIG_SECURITY_SELINUX) := selinux.o
selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \
- netnode.o netport.o ibpkey.o \
+ netnode.o netport.o \
ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \
ss/policydb.o ss/services.o ss/conditional.o ss/mls.o ss/status.o
@@ -14,6 +14,8 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
selinux-$(CONFIG_NETLABEL) += netlabel.o
+selinux-$(CONFIG_SECURITY_INFINIBAND) += ibpkey.o
+
ccflags-y := -I$(srctree)/security/selinux
-I$(srctree)/security/selinux/include
$(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
diff --git a/security/selinux/include/ibpkey.h
b/security/selinux/include/ibpkey.h
index a2ebe397bcb7..040b93cca486 100644
--- a/security/selinux/include/ibpkey.h
+++ b/security/selinux/include/ibpkey.h
@@ -14,8 +14,21 @@
#ifndef _SELINUX_IB_PKEY_H
#define _SELINUX_IB_PKEY_H
+#ifdef CONFIG_SECURITY_INFINIBAND
void sel_ib_pkey_flush(void);
int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid);
+#else
+
+static inline void sel_ib_pkey_flush(void) {
+ return;
+}
+
+static inline int sel_ib_pkey_sid(u64 subnet_prefix, u16 pkey, u32 *sid) {
+ *sid = SECINITSID_UNLABELED;
+ return 0;
+}
+#endif
+
#endif
--
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND.
2020-01-07 15:21 ` Ravi Kumar Siddojigari
@ 2020-01-07 16:27 ` Paul Moore
0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2020-01-07 16:27 UTC (permalink / raw)
To: Ravi Kumar Siddojigari; +Cc: selinux
On Tue, Jan 7, 2020 at 10:21 AM Ravi Kumar Siddojigari
<rsiddoji@codeaurora.org> wrote:
> Move cache based pkey sid retrieval code which was added
> with Commit "409dcf31" under CONFIG_SECURITY_INFINIBAND.
> As its going to alloc a new cache which impacts
> low ram devices which was enabled by default.
>
> Suggested-by: Paul Moore <paul@paul-moore.com>
> Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
> ---
> security/selinux/Makefile | 4 +++-
> security/selinux/include/ibpkey.h | 13 +++++++++++++
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/security/selinux/Makefile b/security/selinux/Makefile
> index ccf950409384..2000f95fb197 100644
> --- a/security/selinux/Makefile
> +++ b/security/selinux/Makefile
> @@ -6,7 +6,7 @@
> obj-$(CONFIG_SECURITY_SELINUX) := selinux.o
>
> selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \
> - netnode.o netport.o ibpkey.o \
> + netnode.o netport.o \
> ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \
> ss/policydb.o ss/services.o ss/conditional.o ss/mls.o ss/status.o
>
> @@ -14,6 +14,8 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
>
> selinux-$(CONFIG_NETLABEL) += netlabel.o
>
> +selinux-$(CONFIG_SECURITY_INFINIBAND) += ibpkey.o
> +
> ccflags-y := -I$(srctree)/security/selinux
> -I$(srctree)/security/selinux/include
It looks like your email client is wrapping lines (above) and causing
the patch to be malformed. The documentation that was mentioned
earlier has more information on how to send patches properly via
email, it also references a second document with more information on
email clients (Documentation/process/email-clients.rst).
At this point I would suggest that you send the patch just to yourself
first to verify that you can apply the patch directly from your email;
once you have that working you can try sending to the list again.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-07 16:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <[PATCH] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND.>
2020-01-06 16:01 ` [PATCH v3] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND Ravi Kumar Siddojigari
2020-01-07 2:28 ` Paul Moore
2020-01-07 15:21 ` Ravi Kumar Siddojigari
2020-01-07 16:27 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.