* [PATCH] ima: fix ima_delete_rules() kernel-doc warning
@ 2023-01-02 20:45 Randy Dunlap
2023-01-06 21:21 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-01-02 20:45 UTC (permalink / raw)
To: linux-security-module
Cc: Randy Dunlap, Mimi Zohar, Dmitry Kasatkin, linux-integrity,
Paul Moore, James Morris, Serge E. Hallyn
Use correct kernel-doc syntax in the function description to
prevent a kernel-doc warning:
security/integrity/ima/ima_policy.c:1964: warning: expecting prototype for ima_delete_rules() called to cleanup invalid in(). Prototype was for ima_delete_rules() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Cc: linux-integrity@vger.kernel.org
Cc: Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
---
security/integrity/ima/ima_policy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
--- a/security/integrity/ima/ima_policy.c
+++ b/security/integrity/ima/ima_policy.c
@@ -1955,7 +1955,8 @@ ssize_t ima_parse_add_rule(char *rule)
}
/**
- * ima_delete_rules() called to cleanup invalid in-flight policy.
+ * ima_delete_rules() - called to cleanup invalid in-flight policy.
+ *
* We don't need locking as we operate on the temp list, which is
* different from the active one. There is also only one user of
* ima_delete_rules() at a time.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ima: fix ima_delete_rules() kernel-doc warning
2023-01-02 20:45 [PATCH] ima: fix ima_delete_rules() kernel-doc warning Randy Dunlap
@ 2023-01-06 21:21 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2023-01-06 21:21 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-security-module, Mimi Zohar, Dmitry Kasatkin,
linux-integrity, James Morris, Serge E. Hallyn
On Mon, Jan 2, 2023 at 3:45 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Use correct kernel-doc syntax in the function description to
> prevent a kernel-doc warning:
>
> security/integrity/ima/ima_policy.c:1964: warning: expecting prototype for ima_delete_rules() called to cleanup invalid in(). Prototype was for ima_delete_rules() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
> Cc: linux-integrity@vger.kernel.org
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> ---
> security/integrity/ima/ima_policy.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Paul Moore <paul@paul-moore.com>
> diff -- a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -1955,7 +1955,8 @@ ssize_t ima_parse_add_rule(char *rule)
> }
>
> /**
> - * ima_delete_rules() called to cleanup invalid in-flight policy.
> + * ima_delete_rules() - called to cleanup invalid in-flight policy.
> + *
> * We don't need locking as we operate on the temp list, which is
> * different from the active one. There is also only one user of
> * ima_delete_rules() at a time.
--
paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-06 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-02 20:45 [PATCH] ima: fix ima_delete_rules() kernel-doc warning Randy Dunlap
2023-01-06 21:21 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.