From: Paul Moore <paul@paul-moore.com>
To: Florian Westphal <fw@strlen.de>
Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com,
Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH] audit: remove the audit freelist
Date: Wed, 30 Nov 2016 19:04:11 -0500 [thread overview]
Message-ID: <CAHC9VhTC+VJZNWE8bfxYEWazi4Kpk_sEwhzr6danM5ogE3G+LA@mail.gmail.com> (raw)
In-Reply-To: <1479215774-29810-1-git-send-email-fw@strlen.de>
On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal <fw@strlen.de> wrote:
> allows better debugging as freeing audit buffers now always honors slub
> debug hooks (e.g. object poisoning) and leak checker can detect the
> free operation.
>
> Removal also results in a small speedup (using
> single rule 'iptables -A INPUT -i lo -j AUDIT --type drop'):
>
> super_netperf 4 -H 127.0.0.1 -l 360 -t UDP_RR -- -R 1 -m 64
> Before:
> 294953
> After:
> 298013
>
> (alloc/free no longer serializes on spinlock, allocator can use percpu
> pool).
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> kernel/audit.c | 53 ++++++++---------------------------------------------
> 1 file changed, 8 insertions(+), 45 deletions(-)
Sorry for the delay, I was hoping to have some time to play around
with this and offer a more meaningful comment ... I've often wondered
about converting audit_buffer, and audit_context for that matter, over
to their own kmem_cache; have you considered that? Or was this
proposed due to simplicity?
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2016-12-01 0:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 13:16 [PATCH] audit: remove the audit freelist Florian Westphal
2016-11-29 16:12 ` Richard Guy Briggs
2016-11-29 17:24 ` Florian Westphal
2016-11-30 4:44 ` Richard Guy Briggs
2016-12-01 0:04 ` Paul Moore [this message]
2016-12-01 1:44 ` Florian Westphal
2016-12-02 0:02 ` Paul Moore
2016-12-02 0:09 ` Florian Westphal
2016-12-02 21:59 ` Paul Moore
2016-12-01 0:19 ` William Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhTC+VJZNWE8bfxYEWazi4Kpk_sEwhzr6danM5ogE3G+LA@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=eparis@redhat.com \
--cc=fw@strlen.de \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.