audit.c patch

audit.c patch

[Ameen Ali]

[-- Attachment #1.1: Type: text/plain, Size: 60 bytes --]

the following attachment which fix kernel code style issues

[-- Attachment #1.2: Type: text/html, Size: 92 bytes --]

[-- Attachment #2: 0001-audit.c-Code-clean-up.patch --]
[-- Type: text/x-patch, Size: 1460 bytes --]

From 84ddb5e562db579175079e567a1976444f78f213 Mon Sep 17 00:00:00 2001
From: Ameen Ali <ameenali023@gmail.com>
Date: Mon, 16 Feb 2015 22:00:12 +0200
Subject: [PATCH] audit.c : Code clean up

Fixed a coding style issue (unnecessary parentheses , unnecessary braces)

Signed-off-by: Ameen-Ali <Ameenali023@gmail.com>
---
 kernel/audit.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 72ab759..0607e12 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -663,7 +663,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
 	case AUDIT_MAKE_EQUIV:
 		/* Only support auditd and auditctl in initial pid namespace
 		 * for now. */
-		if ((task_active_pid_ns(current) != &init_pid_ns))
+		if (task_active_pid_ns(current) != &init_pid_ns)
 			return -EPERM;
 
 		if (!netlink_capable(skb, CAP_AUDIT_CONTROL))
@@ -1759,7 +1759,7 @@ void audit_log_name(struct audit_context *context, struct audit_names *n,
 	} else
 		audit_log_format(ab, " name=(null)");
 
-	if (n->ino != (unsigned long)-1) {
+	if (n->ino != (unsigned long)-1)
 		audit_log_format(ab, " inode=%lu"
 				 " dev=%02x:%02x mode=%#ho"
 				 " ouid=%u ogid=%u rdev=%02x:%02x",
@@ -1771,7 +1771,6 @@ void audit_log_name(struct audit_context *context, struct audit_names *n,
 				 from_kgid(&init_user_ns, n->gid),
 				 MAJOR(n->rdev),
 				 MINOR(n->rdev));
-	}
 	if (n->osid != 0) {
 		char *ctx = NULL;
 		u32 len;
-- 
2.1.0


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: audit.c patch

[Paul Moore]

On Mon, Feb 16, 2015 at 4:07 PM, Ameen Ali <ameenali023@gmail.com> wrote:
> the following attachment which fix kernel code style issues

Please read Documentation/SubmittingPatches in the kernel sources for
information on how to properly format and submit patches for
consideration.  Posting patches inline, and not as an attachment, is
very important.

-- 
paul moore
www.paul-moore.com