All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: Lucas Stach <l.stach@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	patchwork-lst@pengutronix.de, NXP Linux Team <linux-imx@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 00/11] i.MX8MM power domain support
Date: Sat, 3 Oct 2020 13:11:23 -0500	[thread overview]
Message-ID: <CAHCN7x+fYfxVUaAQjBBWJN4CJ6OL6KV+=vRpjVV2cW+ZVv9dPw@mail.gmail.com> (raw)
In-Reply-To: <ae0fcb5f-3df3-aebd-c239-6683438ce374@denx.de>

On Sat, Oct 3, 2020 at 1:08 PM Marek Vasut <marex@denx.de> wrote:
>
> On 10/3/20 8:01 PM, Adam Ford wrote:
> > On Wed, Sep 30, 2020 at 10:50 AM Lucas Stach <l.stach@pengutronix.de> wrote:
> >
> >> Hi all,
> >>
> >> this adds power domain support for the i.MX8MM to the existing GPCv2
> >> driver. It is not complete yet, as it is still missing the VPU and
> >> display power domains, as those require support for the BLK_CTL
> >> regions of the VPUMIX and DISPLAYMIX domains. A Linux driver for
> >> those regions on the i.MX8MP is currently under development and we
> >> plan to use this as a template for the i.MX8MM when the dust has
> >> settled. The changes in this series have been made with this in
> >> mind, so once the BLK_CTL driver exists it should be a matter of
> >> hooking things together via DT, with no further changes required on
> >> the GPCv2 driver side (famous last words).
> >>
> >> Special thanks to Marek Vasut who helped with testing and debugging
> >> of early versions of this code.
> >>
> >>
> > I fully support trying to get this done.  I tried to push something this
> > before, but I was turned down by someone at NXP [1].  I have both a Mini
> > and Nano board at my disposal, so if Nano support isn't there yet, and this
> > driver patch gets accepted, I'll gladly work to help and/or test
> > functionality.
> >
> > [1] - https://lkml.org/lkml/2020/4/30/540
>
> Note that the [1] is using poorly defined and buggy SMC interface to
> TFA, I agree with Lucas that is not the way to go for MX8M. This
> patchset is not using that SMC interface at all, but rather lets Linux
> do the power domain handling, which I think is much better.

I hope you're more successful in convincing NXP of that than Lucas and
I were before.  Our pleas fell on deaf ears.

adam

WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: devicetree <devicetree@vger.kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	patchwork-lst@pengutronix.de, Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH 00/11] i.MX8MM power domain support
Date: Sat, 3 Oct 2020 13:11:23 -0500	[thread overview]
Message-ID: <CAHCN7x+fYfxVUaAQjBBWJN4CJ6OL6KV+=vRpjVV2cW+ZVv9dPw@mail.gmail.com> (raw)
In-Reply-To: <ae0fcb5f-3df3-aebd-c239-6683438ce374@denx.de>

On Sat, Oct 3, 2020 at 1:08 PM Marek Vasut <marex@denx.de> wrote:
>
> On 10/3/20 8:01 PM, Adam Ford wrote:
> > On Wed, Sep 30, 2020 at 10:50 AM Lucas Stach <l.stach@pengutronix.de> wrote:
> >
> >> Hi all,
> >>
> >> this adds power domain support for the i.MX8MM to the existing GPCv2
> >> driver. It is not complete yet, as it is still missing the VPU and
> >> display power domains, as those require support for the BLK_CTL
> >> regions of the VPUMIX and DISPLAYMIX domains. A Linux driver for
> >> those regions on the i.MX8MP is currently under development and we
> >> plan to use this as a template for the i.MX8MM when the dust has
> >> settled. The changes in this series have been made with this in
> >> mind, so once the BLK_CTL driver exists it should be a matter of
> >> hooking things together via DT, with no further changes required on
> >> the GPCv2 driver side (famous last words).
> >>
> >> Special thanks to Marek Vasut who helped with testing and debugging
> >> of early versions of this code.
> >>
> >>
> > I fully support trying to get this done.  I tried to push something this
> > before, but I was turned down by someone at NXP [1].  I have both a Mini
> > and Nano board at my disposal, so if Nano support isn't there yet, and this
> > driver patch gets accepted, I'll gladly work to help and/or test
> > functionality.
> >
> > [1] - https://lkml.org/lkml/2020/4/30/540
>
> Note that the [1] is using poorly defined and buggy SMC interface to
> TFA, I agree with Lucas that is not the way to go for MX8M. This
> patchset is not using that SMC interface at all, but rather lets Linux
> do the power domain handling, which I think is much better.

I hope you're more successful in convincing NXP of that than Lucas and
I were before.  Our pleas fell on deaf ears.

adam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-03 18:11 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 15:49 [PATCH 00/11] i.MX8MM power domain support Lucas Stach
2020-09-30 15:49 ` Lucas Stach
2020-09-30 15:49 ` [PATCH 01/11] soc: imx: gpcv2: move to more ideomatic error handling in probe Lucas Stach
2020-09-30 15:49   ` Lucas Stach
2020-09-30 16:04   ` Marek Vasut
2020-09-30 16:04     ` Marek Vasut
2020-09-30 15:49 ` [PATCH 02/11] soc: imx: gpcv2: move domain mapping to domain driver probe Lucas Stach
2020-09-30 15:49   ` Lucas Stach
2020-09-30 16:07   ` Marek Vasut
2020-09-30 16:07     ` Marek Vasut
2020-09-30 15:49 ` [PATCH 03/11] soc: imx: gpcv2: split power up and power down sequence control Lucas Stach
2020-09-30 15:49   ` Lucas Stach
2020-09-30 16:10   ` Marek Vasut
2020-09-30 16:10     ` Marek Vasut
2020-09-30 15:49 ` [PATCH 04/11] soc: imx: gpcv2: wait for ADB400 handshake Lucas Stach
2020-09-30 15:49   ` Lucas Stach
2020-09-30 16:11   ` Marek Vasut
2020-09-30 16:11     ` Marek Vasut
2020-09-30 16:19     ` Lucas Stach
2020-09-30 16:19       ` Lucas Stach
2020-09-30 16:23       ` Marek Vasut
2020-09-30 16:23         ` Marek Vasut
2020-10-09  3:05         ` Jacky Bai
2020-10-09  3:05           ` Jacky Bai
2020-10-09  7:27           ` Marek Vasut
2020-10-09  7:27             ` Marek Vasut
2020-10-09  7:51             ` Jacky Bai
2020-10-09  7:51               ` Jacky Bai
2020-10-09  8:19               ` Marek Vasut
2020-10-09  8:19                 ` Marek Vasut
2020-09-30 15:50 ` [PATCH 05/11] soc: imx: gpcv2: add runtime PM support for power-domains Lucas Stach
2020-09-30 15:50   ` Lucas Stach
2020-09-30 16:14   ` Marek Vasut
2020-09-30 16:14     ` Marek Vasut
2020-09-30 16:20     ` Lucas Stach
2020-09-30 16:20       ` Lucas Stach
2020-09-30 15:50 ` [PATCH 06/11] soc: imx: gpcv2: allow domains without power-sequence control Lucas Stach
2020-09-30 15:50   ` Lucas Stach
2020-10-09  7:54   ` Jacky Bai
2020-10-09  7:54     ` Jacky Bai
2020-10-09  7:57     ` Jacky Bai
2020-10-09  7:57       ` Jacky Bai
2020-09-30 15:50 ` [PATCH 07/11] soc: imx: gpcv2: add support for optional resets Lucas Stach
2020-09-30 15:50   ` Lucas Stach
2020-09-30 16:15   ` Marek Vasut
2020-09-30 16:15     ` Marek Vasut
2020-09-30 16:23     ` Lucas Stach
2020-09-30 16:23       ` Lucas Stach
2020-09-30 16:30       ` Marek Vasut
2020-09-30 16:30         ` Marek Vasut
2020-09-30 16:34         ` Lucas Stach
2020-09-30 16:34           ` Lucas Stach
2020-09-30 16:38           ` Marek Vasut
2020-09-30 16:38             ` Marek Vasut
2020-10-01  8:59   ` Krzysztof Kozlowski
2020-10-01  8:59     ` Krzysztof Kozlowski
2020-10-06 19:42   ` Rob Herring
2020-10-06 19:42     ` Rob Herring
2020-09-30 15:50 ` [PATCH 08/11] dt-bindings: add defines for i.MX8MM power domains Lucas Stach
2020-09-30 15:50   ` Lucas Stach
2020-10-01  8:54   ` Krzysztof Kozlowski
2020-10-01  8:54     ` Krzysztof Kozlowski
2020-10-06 19:47   ` Rob Herring
2020-10-06 19:47     ` Rob Herring
2020-09-30 15:50 ` [PATCH 09/11] soc: imx: gpcv2: add support " Lucas Stach
2020-09-30 15:50   ` Lucas Stach
2020-09-30 16:18   ` Marek Vasut
2020-09-30 16:18     ` Marek Vasut
2020-09-30 15:50 ` [PATCH 10/11] arm64: dts: imx8mm: add GPC node and " Lucas Stach
2020-09-30 15:50   ` Lucas Stach
2020-09-30 16:20   ` Marek Vasut
2020-09-30 16:20     ` Marek Vasut
2020-10-01  8:51   ` Krzysztof Kozlowski
2020-10-01  8:51     ` Krzysztof Kozlowski
2020-10-23 13:22   ` Adam Ford
2020-10-23 13:22     ` Adam Ford
2020-10-23 14:39     ` Jacky Bai
2020-10-23 14:39       ` Jacky Bai
2020-10-26 10:56   ` Abel Vesa
2020-10-26 10:56     ` Abel Vesa
2020-10-26 11:01     ` Abel Vesa
2020-10-26 11:01       ` Abel Vesa
2020-10-26 11:13       ` Adam Ford
2020-10-26 11:13         ` Adam Ford
2020-10-26 11:02     ` Lucas Stach
2020-10-26 11:02       ` Lucas Stach
2020-09-30 15:50 ` [PATCH 11/11] arm64: dts: imx8mm: put USB controllers into power-domains Lucas Stach
2020-09-30 15:50   ` Lucas Stach
2020-10-01  7:46 ` [PATCH 00/11] i.MX8MM power domain support Frieder Schrempf
2020-10-01  7:46   ` Frieder Schrempf
2020-10-03 18:03 ` Adam Ford
2020-10-03 18:03   ` Adam Ford
     [not found] ` <CAHCN7xKjWEwQr9y0QLrR6KVT=ut=v=coqt4beAvrz1kQSGbX1g@mail.gmail.com>
2020-10-03 18:08   ` Marek Vasut
2020-10-03 18:08     ` Marek Vasut
2020-10-03 18:11     ` Adam Ford [this message]
2020-10-03 18:11       ` Adam Ford
2020-10-08 20:47 ` Adam Ford
2020-10-08 20:47   ` Adam Ford
2020-10-09  3:00 ` Jacky Bai
2020-10-09  3:00   ` Jacky Bai
2020-10-09 11:12   ` Lucas Stach
2020-10-09 11:12     ` Lucas Stach
2020-10-09 12:57     ` Adam Ford
2020-10-09 12:57       ` Adam Ford
2020-10-10  2:16     ` Jacky Bai
2020-10-10  2:16       ` Jacky Bai
2020-10-13 18:26       ` Lucas Stach
2020-10-13 18:26         ` Lucas Stach
2020-10-14  1:23         ` Peng Fan
2020-10-14  1:23           ` Peng Fan
2020-10-22  8:24           ` Lucas Stach
2020-10-22  8:24             ` Lucas Stach
2020-10-22 16:36             ` Fabio Estevam
2020-10-22 16:36               ` Fabio Estevam
2020-10-28 13:50             ` Peng Fan
2020-10-28 13:50               ` Peng Fan
2020-10-31 13:56               ` Adam Ford
2020-10-31 13:56                 ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHCN7x+fYfxVUaAQjBBWJN4CJ6OL6KV+=vRpjVV2cW+ZVv9dPw@mail.gmail.com' \
    --to=aford173@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=patchwork-lst@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.