All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Jacky Bai <ping.bai@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Angus Ainslie <angus@akkea.ca>,
	Alexandre Bailon <abailon@baylibre.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Abel Vesa <abel.vesa@nxp.com>,
	Saravana Kannan <saravanak@google.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	devicetree <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	Silvano Di Ninno <silvano.dininno@nxp.com>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Anson Huang <anson.huang@nxp.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
Date: Wed, 15 Jan 2020 14:09:32 -0600	[thread overview]
Message-ID: <CAHCN7xJc8yMe683wsB1e1TdE26FX1oMFT_i_hshkEECrJ52oHg@mail.gmail.com> (raw)
In-Reply-To: <VI1PR04MB7023DA37F366D4C770D7312EEE350@VI1PR04MB7023.eurprd04.prod.outlook.com>

On Mon, Jan 13, 2020 at 5:36 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 10.01.2020 20:34, Adam Ford wrote:
> > On Wed, Dec 18, 2019 at 10:42 AM Adam Ford <aford173@gmail.com
> > <mailto:aford173@gmail.com>> wrote:
> >      > > U-Boot booted and Linux booted, but I still get:
> >      > >
> >      > >     imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> >      > > firmware freq info: -19
> >      >
> >      > Which version of u-boot is that, upstream? I'm subscribed to uboot
> >      > mailing list and I see that imx8m support has its own separate issues
> >      > but my familiarity is limited :(
> >
> >     U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40
> >     -0600)
> >
> >      >
> >      > I've only ever tested with NXP uboot and the NXP version of mkimage:
> >      >
> >      >
> >     https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
> >     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Flog%2F%3Fh%3Dimx_v2019.04_4.19.35_1.1.0&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735473321&sdata=LhleGMcJzjiNsPbVxmPbvgRVMnl%2F2HxUqVYKcgCFiEg%3D&reserved=0>
> >      > https://source.codeaurora.org/external/imx/imx-mkimage/
> >     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-mkimage%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735483320&sdata=enJQ9hgVkIG7frJ9v6QBQAgJBL8j3hWB7RAKa8XhPaw%3D&reserved=0>
> >
> >     I will try your versions and see what happens.
> >
> >      > My bootloader prints the following BuildInfo:
> >      >    - ATF 70fa7bc
> >      >
> >      >    - U-Boot 2019.04-00019-g4d377539a119
> >      >
> >
> >     Thanks for your help.
> >
> >
> > I wanted to try again after everything was merged into linux-next.
> >
> > I am using the U-Boot master (as of 10 Jan 2020), with ATF from
> > 4.19.35_1.1.0 from Code Aurora.  I have tried your ATF, but I don't see
> > any change in behavior.  I have made the DDRC a module, but I still get
> > the same error message.
> >
> > [    2.204554] imx8m-ddrc-devfreq 3d400000.memory-controller: failed to
> > init firmware freq info: -19
> >
> > Is there something else I can try?
>
> Yes, the NXP branch of uboot from Code Aurora (my commit hash is above).
>
> I understand you want to use uboot and atf master, apparently they both
> need to be patched for this feature to work. It would still be
> interesting to validate.

I was able to get the 8MM to work with this new driver using the uboot
branch from Code Aurora.  Could you point me to what in U-Boot needs
to be pulled forward to the mainline?  I'd be willing to help if I
can.

Thanks for your help.

adam
>
> --
> Regards,
> Leonard

WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Peng Fan <peng.fan@nxp.com>,
	Jacky Bai <ping.bai@nxp.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Angus Ainslie <angus@akkea.ca>,
	Alexandre Bailon <abailon@baylibre.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	Abel Vesa <abel.vesa@nxp.com>,
	Saravana Kannan <saravanak@google.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	devicetree <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	Silvano Di Ninno <silvano.dininno@nxp.com>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Anson Huang <anson.huang@nxp.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
Date: Wed, 15 Jan 2020 14:09:32 -0600	[thread overview]
Message-ID: <CAHCN7xJc8yMe683wsB1e1TdE26FX1oMFT_i_hshkEECrJ52oHg@mail.gmail.com> (raw)
In-Reply-To: <VI1PR04MB7023DA37F366D4C770D7312EEE350@VI1PR04MB7023.eurprd04.prod.outlook.com>

On Mon, Jan 13, 2020 at 5:36 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 10.01.2020 20:34, Adam Ford wrote:
> > On Wed, Dec 18, 2019 at 10:42 AM Adam Ford <aford173@gmail.com
> > <mailto:aford173@gmail.com>> wrote:
> >      > > U-Boot booted and Linux booted, but I still get:
> >      > >
> >      > >     imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> >      > > firmware freq info: -19
> >      >
> >      > Which version of u-boot is that, upstream? I'm subscribed to uboot
> >      > mailing list and I see that imx8m support has its own separate issues
> >      > but my familiarity is limited :(
> >
> >     U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40
> >     -0600)
> >
> >      >
> >      > I've only ever tested with NXP uboot and the NXP version of mkimage:
> >      >
> >      >
> >     https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
> >     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Flog%2F%3Fh%3Dimx_v2019.04_4.19.35_1.1.0&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735473321&sdata=LhleGMcJzjiNsPbVxmPbvgRVMnl%2F2HxUqVYKcgCFiEg%3D&reserved=0>
> >      > https://source.codeaurora.org/external/imx/imx-mkimage/
> >     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-mkimage%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735483320&sdata=enJQ9hgVkIG7frJ9v6QBQAgJBL8j3hWB7RAKa8XhPaw%3D&reserved=0>
> >
> >     I will try your versions and see what happens.
> >
> >      > My bootloader prints the following BuildInfo:
> >      >    - ATF 70fa7bc
> >      >
> >      >    - U-Boot 2019.04-00019-g4d377539a119
> >      >
> >
> >     Thanks for your help.
> >
> >
> > I wanted to try again after everything was merged into linux-next.
> >
> > I am using the U-Boot master (as of 10 Jan 2020), with ATF from
> > 4.19.35_1.1.0 from Code Aurora.  I have tried your ATF, but I don't see
> > any change in behavior.  I have made the DDRC a module, but I still get
> > the same error message.
> >
> > [    2.204554] imx8m-ddrc-devfreq 3d400000.memory-controller: failed to
> > init firmware freq info: -19
> >
> > Is there something else I can try?
>
> Yes, the NXP branch of uboot from Code Aurora (my commit hash is above).
>
> I understand you want to use uboot and atf master, apparently they both
> need to be patched for this feature to work. It would still be
> interesting to validate.

I was able to get the 8MM to work with this new driver using the uboot
branch from Code Aurora.  Could you point me to what in U-Boot needs
to be pulled forward to the mainline?  I'd be willing to help if I
can.

Thanks for your help.

adam
>
> --
> Regards,
> Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-15 20:09 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
2019-11-22 21:44 ` Leonard Crestez
2019-11-22 21:45 ` [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
2019-11-22 21:45   ` Leonard Crestez
2019-11-25  1:25   ` Stephen Boyd
2019-12-09  1:15   ` Shawn Guo
2019-12-09  1:15     ` Shawn Guo
2019-11-22 21:45 ` [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE Leonard Crestez
2019-11-22 21:45   ` Leonard Crestez
2019-11-25  1:26   ` Stephen Boyd
2019-12-09  1:16   ` Shawn Guo
2019-12-09  1:16     ` Shawn Guo
2019-11-22 21:45 ` [PATCH v7 3/5] dt-bindings: memory: Add bindings for imx8m ddr controller Leonard Crestez
2019-11-22 21:45   ` Leonard Crestez
2019-11-22 21:45 ` [PATCH v7 4/5] PM / devfreq: Add dynamic scaling " Leonard Crestez
2019-11-22 21:45   ` Leonard Crestez
2019-11-24 23:59   ` Chanwoo Choi
2019-11-24 23:59     ` Chanwoo Choi
2019-11-26 19:44     ` Rob Herring
2019-11-26 19:44       ` Rob Herring
2019-11-26 23:25       ` Chanwoo Choi
2019-11-26 23:25         ` Chanwoo Choi
     [not found]   ` <CGME20191219230258epcas1p16ec64c3a06eafd9f0a3784d18541ce5c@epcas1p1.samsung.com>
2019-12-19 23:09     ` [v8 PATCH] " Chanwoo Choi
2019-12-19 23:10       ` Chanwoo Choi
2019-11-22 21:45 ` [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes Leonard Crestez
2019-11-22 21:45   ` Leonard Crestez
2019-11-28 14:43   ` Adam Ford
2019-11-28 14:43     ` Adam Ford
2019-11-29  5:33     ` Leonard Crestez
2019-11-29  5:33       ` Leonard Crestez
2019-12-09  1:34   ` Shawn Guo
2019-12-09  1:34     ` Shawn Guo
2019-12-18 13:35 ` [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Adam Ford
2019-12-18 13:35   ` Adam Ford
2019-12-18 14:44   ` Leonard Crestez
2019-12-18 14:44     ` Leonard Crestez
2019-12-18 15:05     ` Adam Ford
2019-12-18 15:05       ` Adam Ford
2019-12-18 15:16       ` Leonard Crestez
2019-12-18 15:16         ` Leonard Crestez
2019-12-18 15:37         ` Adam Ford
2019-12-18 15:37           ` Adam Ford
2019-12-18 16:22           ` Leonard Crestez
2019-12-18 16:22             ` Leonard Crestez
2019-12-18 16:42             ` Adam Ford
2019-12-18 16:42               ` Adam Ford
     [not found]               ` <CAHCN7xKjpN_XEGLj-1jMG5mBbF=su67k+10frheLt+L1XaR0-g@mail.gmail.com>
2020-01-13 23:36                 ` Leonard Crestez
2020-01-13 23:36                   ` Leonard Crestez
2020-01-15 20:09                   ` Adam Ford [this message]
2020-01-15 20:09                     ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHCN7xJc8yMe683wsB1e1TdE26FX1oMFT_i_hshkEECrJ52oHg@mail.gmail.com \
    --to=aford173@gmail.com \
    --cc=abailon@baylibre.com \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=angus@akkea.ca \
    --cc=anson.huang@nxp.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=georgi.djakov@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martink@posteo.de \
    --cc=mka@chromium.org \
    --cc=mturquette@baylibre.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=saravanak@google.com \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=silvano.dininno@nxp.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.