From: Adam Ford <aford173@gmail.com> To: Sekhar Nori <nsekhar@ti.com> Cc: Adam Ford <adam.ford@logicpd.com>, Kevin Hilman <khilman@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, arm-soc <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes Date: Thu, 10 May 2018 10:39:01 -0500 [thread overview] Message-ID: <CAHCN7xJnufoz10QTxKR4je=SW97PhLJYjhOWpDp-qg6JBf9QKA@mail.gmail.com> (raw) In-Reply-To: <7692ca00-3c9d-6e3e-12b6-f65d82f6fa95@ti.com> On Thu, May 10, 2018 at 10:19 AM, Sekhar Nori <nsekhar@ti.com> wrote: > On Thursday 10 May 2018 08:38 PM, Adam Ford wrote: >> On Thu, May 10, 2018 at 4:10 AM, Sekhar Nori <nsekhar@ti.com> wrote: >>> On Monday 07 May 2018 06:07 PM, Adam Ford wrote: >>>> Many node labels in the device tree (like serial0, serial1, etc) are being >>>> redefined, so let's modernize the device tree by using phandles to >>>> extend the existing nodes. This helps reduce the whitespace. >>>> >>>> Signed-off-by: Adam Ford <aford173@gmail.com> >>> >>> I applied this without the pmic changes. I am not convinced about those. >>> The tps node is already being referred to as phandle. I am not sure >>> referring to each individual regulator using phandle is needed. Other >>> files like am335x-evm.dts don't do it as well. >> >> I tested the regulator values and names after booting to see if the >> names and values matched the expected values. They did, so I am >> fairly confident it would have worked. > > Not doubting that. But I am not sure if thats the "norm". Do you see any > other device-tree file doing this? The omap3 boards do this. For example, the beagle-xm board includes the twl4030 files #include "twl4030.dtsi" #include "twl4030_omap3.dtsi" These files setup the PMIC regulators, but the beagle-xm modifies the PMIC settings phandles. &vaux2 { regulator-name = "usb_1v8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; }; I was trying to mimic this behavior when I did it for the da850-evm, however, it seems like a moot point we merge the tp6507x.dtsi contents into the da850-evm.dts. > >> >>> >>> Another thing is whether we really need the tp6507x.dtsi file. It does >>> not seem to contain much and also da850-evm.dts is the only file >>> including it. So it seems pretty pointless to me. >> >> Do you want me to do a patch that removes the tp6507x.dtsi file and >> just sets up the >> PMIC from scratch within the da850-evm file? > > I am fine with the plan, but not something urgent, IMO. I'm going to try and revisit the LCD again first, but I'll try to do them both this weekend if I can get some time. > >> >>> >>> Here is what I committed. >> >> Thank you. I think looks cleaner this way, and more consistent with >> many of the other platforms and boards. > > Yes. > > Thanks, > Sekhar Thank you, adam
WARNING: multiple messages have this Message-ID (diff)
From: aford173@gmail.com (Adam Ford) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes Date: Thu, 10 May 2018 10:39:01 -0500 [thread overview] Message-ID: <CAHCN7xJnufoz10QTxKR4je=SW97PhLJYjhOWpDp-qg6JBf9QKA@mail.gmail.com> (raw) In-Reply-To: <7692ca00-3c9d-6e3e-12b6-f65d82f6fa95@ti.com> On Thu, May 10, 2018 at 10:19 AM, Sekhar Nori <nsekhar@ti.com> wrote: > On Thursday 10 May 2018 08:38 PM, Adam Ford wrote: >> On Thu, May 10, 2018 at 4:10 AM, Sekhar Nori <nsekhar@ti.com> wrote: >>> On Monday 07 May 2018 06:07 PM, Adam Ford wrote: >>>> Many node labels in the device tree (like serial0, serial1, etc) are being >>>> redefined, so let's modernize the device tree by using phandles to >>>> extend the existing nodes. This helps reduce the whitespace. >>>> >>>> Signed-off-by: Adam Ford <aford173@gmail.com> >>> >>> I applied this without the pmic changes. I am not convinced about those. >>> The tps node is already being referred to as phandle. I am not sure >>> referring to each individual regulator using phandle is needed. Other >>> files like am335x-evm.dts don't do it as well. >> >> I tested the regulator values and names after booting to see if the >> names and values matched the expected values. They did, so I am >> fairly confident it would have worked. > > Not doubting that. But I am not sure if thats the "norm". Do you see any > other device-tree file doing this? The omap3 boards do this. For example, the beagle-xm board includes the twl4030 files #include "twl4030.dtsi" #include "twl4030_omap3.dtsi" These files setup the PMIC regulators, but the beagle-xm modifies the PMIC settings phandles. &vaux2 { regulator-name = "usb_1v8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; }; I was trying to mimic this behavior when I did it for the da850-evm, however, it seems like a moot point we merge the tp6507x.dtsi contents into the da850-evm.dts. > >> >>> >>> Another thing is whether we really need the tp6507x.dtsi file. It does >>> not seem to contain much and also da850-evm.dts is the only file >>> including it. So it seems pretty pointless to me. >> >> Do you want me to do a patch that removes the tp6507x.dtsi file and >> just sets up the >> PMIC from scratch within the da850-evm file? > > I am fine with the plan, but not something urgent, IMO. I'm going to try and revisit the LCD again first, but I'll try to do them both this weekend if I can get some time. > >> >>> >>> Here is what I committed. >> >> Thank you. I think looks cleaner this way, and more consistent with >> many of the other platforms and boards. > > Yes. > > Thanks, > Sekhar Thank you, adam
next prev parent reply other threads:[~2018-05-10 15:39 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-07 12:37 [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes Adam Ford 2018-05-07 12:37 ` Adam Ford 2018-05-10 9:10 ` Sekhar Nori 2018-05-10 9:10 ` Sekhar Nori 2018-05-10 9:10 ` Sekhar Nori 2018-05-10 15:08 ` Adam Ford 2018-05-10 15:08 ` Adam Ford 2018-05-10 15:19 ` Sekhar Nori 2018-05-10 15:19 ` Sekhar Nori 2018-05-10 15:19 ` Sekhar Nori 2018-05-10 15:39 ` Adam Ford [this message] 2018-05-10 15:39 ` Adam Ford
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHCN7xJnufoz10QTxKR4je=SW97PhLJYjhOWpDp-qg6JBf9QKA@mail.gmail.com' \ --to=aford173@gmail.com \ --cc=adam.ford@logicpd.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nsekhar@ti.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.