* [PATCH] stb0899: Fix slow and not locking DVB-S transponder(s) @ 2011-09-29 21:16 Lutz Sammer 2011-09-29 21:22 ` [PATCH v2] " Lutz Sammer 0 siblings, 1 reply; 10+ messages in thread From: Lutz Sammer @ 2011-09-29 21:16 UTC (permalink / raw) To: linux-media Another version of http://patchwork.linuxtv.org/patch/6307 http://patchwork.linuxtv.org/patch/6510 which was superseded or rejected, but it don't know why. In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS could read old (from previous search) status bits and the search fails on a good frequency. With the patch more transponder could be locked and locks about 2* faster. Signed-off-by: Lutz Sammer <johns98@gmx.net> --- drivers/media/dvb/frontends/stb0899_algo.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/fron tends/stb0899_algo.c index d70eee0..8eca419 100644 --- a/drivers/media/dvb/frontends/stb0899_algo.c +++ b/drivers/media/dvb/frontends/stb0899_algo.c @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899 _state *state) else dataTime = 500; + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop * / while (1) { /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP * / -- 1.7.6.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-09-29 21:16 [PATCH] stb0899: Fix slow and not locking DVB-S transponder(s) Lutz Sammer @ 2011-09-29 21:22 ` Lutz Sammer 2011-09-30 17:07 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 10+ messages in thread From: Lutz Sammer @ 2011-09-29 21:22 UTC (permalink / raw) To: linux-media Another version of http://patchwork.linuxtv.org/patch/6307 http://patchwork.linuxtv.org/patch/6510 which was superseded or rejected, but I don't know why. In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS could read old (from previous search) status bits and the search fails on a good frequency. With the patch more transponder could be locked and locks about 2* faster. Signed-off-by: Lutz Sammer <johns98@gmx.net> --- drivers/media/dvb/frontends/stb0899_algo.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c index d70eee0..8eca419 100644 --- a/drivers/media/dvb/frontends/stb0899_algo.c +++ b/drivers/media/dvb/frontends/stb0899_algo.c @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) else dataTime = 500; + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ while (1) { /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ -- 1.7.6.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-09-29 21:22 ` [PATCH v2] " Lutz Sammer @ 2011-09-30 17:07 ` Mauro Carvalho Chehab 2011-09-30 18:41 ` Lutz Sammer 0 siblings, 1 reply; 10+ messages in thread From: Mauro Carvalho Chehab @ 2011-09-30 17:07 UTC (permalink / raw) To: Lutz Sammer; +Cc: linux-media Em 29-09-2011 18:22, Lutz Sammer escreveu: > Another version of > http://patchwork.linuxtv.org/patch/6307 > http://patchwork.linuxtv.org/patch/6510 > which was superseded or rejected, but I don't know why. Probably because of the same reason of this patch [1]: patch -p1 -i patches/lmml_8023_v2_stb0899_fix_slow_and_not_locking_dvb_s_transponder_s.patch --dry-run -t -N patching file drivers/media/dvb/frontends/stb0899_algo.c Hunk #1 FAILED at 358. 1 out of 1 hunk FAILED -- saving rejects to file drivers/media/dvb/frontends/stb0899_algo.c.rej drivers/media/dvb/frontends/stb0899_algo.c | 1 + 1 file changed, 1 insertion(+) I'll mark this one as rejected, as it doesn't apply upstream[2]. [1] http://patchwork.linuxtv.org/patch/8023/ [2] at tree/branch: git://linuxtv.org/media_tree.git staging/for_v3.2 Please test if the changes made upstream to solve a similar trouble fixes your issue. If not, please rebase your patch on the top of it and resend. Thanks, Mauro > > In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS > could read old (from previous search) status bits and the search fails > on a good frequency. > > With the patch more transponder could be locked and locks about 2* faster. > > Signed-off-by: Lutz Sammer <johns98@gmx.net> > --- > drivers/media/dvb/frontends/stb0899_algo.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c > index d70eee0..8eca419 100644 > --- a/drivers/media/dvb/frontends/stb0899_algo.c > +++ b/drivers/media/dvb/frontends/stb0899_algo.c > @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) > else > dataTime = 500; > > + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ > stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ > while (1) { > /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-09-30 17:07 ` Mauro Carvalho Chehab @ 2011-09-30 18:41 ` Lutz Sammer 2011-09-30 18:58 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 10+ messages in thread From: Lutz Sammer @ 2011-09-30 18:41 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: linux-media [-- Attachment #1: Type: text/plain, Size: 2309 bytes --] On 09/30/11 19:07, Mauro Carvalho Chehab wrote: > Em 29-09-2011 18:22, Lutz Sammer escreveu: >> Another version of >> http://patchwork.linuxtv.org/patch/6307 >> http://patchwork.linuxtv.org/patch/6510 >> which was superseded or rejected, but I don't know why. > > Probably because of the same reason of this patch [1]: > > patch -p1 -i patches/lmml_8023_v2_stb0899_fix_slow_and_not_locking_dvb_s_transponder_s.patch --dry-run -t -N > patching file drivers/media/dvb/frontends/stb0899_algo.c > Hunk #1 FAILED at 358. > 1 out of 1 hunk FAILED -- saving rejects to file drivers/media/dvb/frontends/stb0899_algo.c.rej > drivers/media/dvb/frontends/stb0899_algo.c | 1 + > 1 file changed, 1 insertion(+) > > I'll mark this one as rejected, as it doesn't apply upstream[2]. > > [1] http://patchwork.linuxtv.org/patch/8023/ > [2] at tree/branch: git://linuxtv.org/media_tree.git staging/for_v3.2 > > Please test if the changes made upstream to solve a similar trouble fixes your issue. > If not, please rebase your patch on the top of it and resend. > > Thanks, > Mauro >> >> In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS >> could read old (from previous search) status bits and the search fails >> on a good frequency. >> >> With the patch more transponder could be locked and locks about 2* faster. >> >> Signed-off-by: Lutz Sammer<johns98@gmx.net> >> --- >> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c >> index d70eee0..8eca419 100644 >> --- a/drivers/media/dvb/frontends/stb0899_algo.c >> +++ b/drivers/media/dvb/frontends/stb0899_algo.c >> @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) >> else >> dataTime = 500; >> >> + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ >> stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ >> while (1) { >> /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ > > Sorry this fucking thunderbird eats the patches. I have followed the README.patches and installed thunderbird plugin. Johns [-- Attachment #2: 0001-stb0899-Fix-slow-and-not-locking-DVB-S-transponder-s.patch --] [-- Type: text/plain, Size: 581 bytes --] diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c index d70eee0..8eca419 100644 --- a/drivers/media/dvb/frontends/stb0899_algo.c +++ b/drivers/media/dvb/frontends/stb0899_algo.c @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) else dataTime = 500; + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ while (1) { /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-09-30 18:41 ` Lutz Sammer @ 2011-09-30 18:58 ` Mauro Carvalho Chehab 2011-10-06 18:56 ` Manu Abraham 0 siblings, 1 reply; 10+ messages in thread From: Mauro Carvalho Chehab @ 2011-09-30 18:58 UTC (permalink / raw) To: Manu Abraham; +Cc: Lutz Sammer, linux-media Em 30-09-2011 15:41, Lutz Sammer escreveu: > On 09/30/11 19:07, Mauro Carvalho Chehab wrote: >> Em 29-09-2011 18:22, Lutz Sammer escreveu: >>> Another version of >>> http://patchwork.linuxtv.org/patch/6307 >>> http://patchwork.linuxtv.org/patch/6510 >>> which was superseded or rejected, but I don't know why. >> >> Probably because of the same reason of this patch [1]: >> >> patch -p1 -i patches/lmml_8023_v2_stb0899_fix_slow_and_not_locking_dvb_s_transponder_s.patch --dry-run -t -N >> patching file drivers/media/dvb/frontends/stb0899_algo.c >> Hunk #1 FAILED at 358. >> 1 out of 1 hunk FAILED -- saving rejects to file drivers/media/dvb/frontends/stb0899_algo.c.rej >> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >> 1 file changed, 1 insertion(+) >> >> I'll mark this one as rejected, as it doesn't apply upstream[2]. >> >> [1] http://patchwork.linuxtv.org/patch/8023/ >> [2] at tree/branch: git://linuxtv.org/media_tree.git staging/for_v3.2 >> >> Please test if the changes made upstream to solve a similar trouble fixes your issue. >> If not, please rebase your patch on the top of it and resend. >> >> Thanks, >> Mauro >>> >>> In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS >>> could read old (from previous search) status bits and the search fails >>> on a good frequency. >>> >>> With the patch more transponder could be locked and locks about 2* faster. Manu, Could you please review this one-line patch? >>> >>> Signed-off-by: Lutz Sammer<johns98@gmx.net> >>> --- >>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c >>> index d70eee0..8eca419 100644 >>> --- a/drivers/media/dvb/frontends/stb0899_algo.c >>> +++ b/drivers/media/dvb/frontends/stb0899_algo.c >>> @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) >>> else >>> dataTime = 500; >>> >>> + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ >>> stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ >>> while (1) { >>> /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ Thanks! Mauro >> >> > > Sorry this fucking thunderbird eats the patches. I have followed the README.patches and > installed thunderbird plugin. Yes, thunderbird hates patches ;) > > Johns > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-09-30 18:58 ` Mauro Carvalho Chehab @ 2011-10-06 18:56 ` Manu Abraham 2011-10-07 17:01 ` Lutz Sammer 0 siblings, 1 reply; 10+ messages in thread From: Manu Abraham @ 2011-10-06 18:56 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Lutz Sammer, linux-media Mauro, comments in-line. On Sat, Oct 1, 2011 at 12:28 AM, Mauro Carvalho Chehab <mchehab@redhat.com> wrote: > Em 30-09-2011 15:41, Lutz Sammer escreveu: >> On 09/30/11 19:07, Mauro Carvalho Chehab wrote: >>> Em 29-09-2011 18:22, Lutz Sammer escreveu: >>>> Another version of >>>> http://patchwork.linuxtv.org/patch/6307 >>>> http://patchwork.linuxtv.org/patch/6510 >>>> which was superseded or rejected, but I don't know why. >>> >>> Probably because of the same reason of this patch [1]: >>> >>> patch -p1 -i patches/lmml_8023_v2_stb0899_fix_slow_and_not_locking_dvb_s_transponder_s.patch --dry-run -t -N >>> patching file drivers/media/dvb/frontends/stb0899_algo.c >>> Hunk #1 FAILED at 358. >>> 1 out of 1 hunk FAILED -- saving rejects to file drivers/media/dvb/frontends/stb0899_algo.c.rej >>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> I'll mark this one as rejected, as it doesn't apply upstream[2]. >>> >>> [1] http://patchwork.linuxtv.org/patch/8023/ >>> [2] at tree/branch: git://linuxtv.org/media_tree.git staging/for_v3.2 >>> >>> Please test if the changes made upstream to solve a similar trouble fixes your issue. >>> If not, please rebase your patch on the top of it and resend. >>> >>> Thanks, >>> Mauro >>>> >>>> In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS >>>> could read old (from previous search) status bits and the search fails >>>> on a good frequency. >>>> >>>> With the patch more transponder could be locked and locks about 2* faster. > > Manu, > > Could you please review this one-line patch? > > >>>> >>>> Signed-off-by: Lutz Sammer<johns98@gmx.net> >>>> --- >>>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c >>>> index d70eee0..8eca419 100644 >>>> --- a/drivers/media/dvb/frontends/stb0899_algo.c >>>> +++ b/drivers/media/dvb/frontends/stb0899_algo.c >>>> @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) >>>> else >>>> dataTime = 500; >>>> >>>> + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ >>>> stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ >>>> while (1) { >>>> /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ > Please add in these comments, in case you want to apply the change. I am neither for the patch, nor against it. - In fact, it doesn't hurt to read STATUS just before LOCK test. - I wasn't able to find any noticeable difference in LOCK acquisition. - Nowhere, I was able to find that reading VSTATUS, clears the Read-Only bits set by the onchip microcontroller. The above comment could be wrong at least, as far as I can say. But that said, if the change does really help (thinking of strange issues with some Silicon cuts) Acked-by: Manu Abraham <manu@linuxtv.org> Regards, Manu ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-10-06 18:56 ` Manu Abraham @ 2011-10-07 17:01 ` Lutz Sammer 2011-10-07 18:20 ` Manu Abraham 0 siblings, 1 reply; 10+ messages in thread From: Lutz Sammer @ 2011-10-07 17:01 UTC (permalink / raw) To: Manu Abraham; +Cc: Mauro Carvalho Chehab, linux-media On 10/06/11 20:56, Manu Abraham wrote: > Mauro, > > comments in-line. > > On Sat, Oct 1, 2011 at 12:28 AM, Mauro Carvalho Chehab > <mchehab@redhat.com> wrote: >> Em 30-09-2011 15:41, Lutz Sammer escreveu: >>> On 09/30/11 19:07, Mauro Carvalho Chehab wrote: >>>> Em 29-09-2011 18:22, Lutz Sammer escreveu: >>>>> Another version of >>>>> http://patchwork.linuxtv.org/patch/6307 >>>>> http://patchwork.linuxtv.org/patch/6510 >>>>> which was superseded or rejected, but I don't know why. >>>> >>>> Probably because of the same reason of this patch [1]: >>>> >>>> patch -p1 -i patches/lmml_8023_v2_stb0899_fix_slow_and_not_locking_dvb_s_transponder_s.patch --dry-run -t -N >>>> patching file drivers/media/dvb/frontends/stb0899_algo.c >>>> Hunk #1 FAILED at 358. >>>> 1 out of 1 hunk FAILED -- saving rejects to file drivers/media/dvb/frontends/stb0899_algo.c.rej >>>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> I'll mark this one as rejected, as it doesn't apply upstream[2]. >>>> >>>> [1] http://patchwork.linuxtv.org/patch/8023/ >>>> [2] at tree/branch: git://linuxtv.org/media_tree.git staging/for_v3.2 >>>> >>>> Please test if the changes made upstream to solve a similar trouble fixes your issue. >>>> If not, please rebase your patch on the top of it and resend. >>>> >>>> Thanks, >>>> Mauro >>>>> >>>>> In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS >>>>> could read old (from previous search) status bits and the search fails >>>>> on a good frequency. >>>>> >>>>> With the patch more transponder could be locked and locks about 2* faster. >> >> Manu, >> >> Could you please review this one-line patch? >> >> >>>>> >>>>> Signed-off-by: Lutz Sammer<johns98@gmx.net> >>>>> --- >>>>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c >>>>> index d70eee0..8eca419 100644 >>>>> --- a/drivers/media/dvb/frontends/stb0899_algo.c >>>>> +++ b/drivers/media/dvb/frontends/stb0899_algo.c >>>>> @@ -358,6 +358,7 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) >>>>> else >>>>> dataTime = 500; >>>>> >>>>> + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status bits */ >>>>> stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ >>>>> while (1) { >>>>> /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ >> > > Please add in these comments, in case you want to apply the change. I > am neither for the patch, nor against it. > > - In fact, it doesn't hurt to read STATUS just before LOCK test. > - I wasn't able to find any noticeable difference in LOCK acquisition. > - Nowhere, I was able to find that reading VSTATUS, clears the > Read-Only bits set by the onchip microcontroller. The above comment > could be wrong at least, as far as I can say. > > But that said, if the change does really help (thinking of strange > issues with some Silicon cuts) > > Acked-by: Manu Abraham<manu@linuxtv.org> > > Regards, > Manu > To be exact only the loop bit is reset by the read: kernel: [62791.427869] stb0899: vstatus 40 00 40 00 kernel: [62791.597609] stb0899: vstatus 00 00 18 18 Printed twice before and after the loop. I tested this with the tt-3600 and tt-3650. Johns ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-10-07 17:01 ` Lutz Sammer @ 2011-10-07 18:20 ` Manu Abraham 2011-10-07 20:11 ` [PATCH v3] " Lutz Sammer 0 siblings, 1 reply; 10+ messages in thread From: Manu Abraham @ 2011-10-07 18:20 UTC (permalink / raw) To: Lutz Sammer; +Cc: Mauro Carvalho Chehab, linux-media On Fri, Oct 7, 2011 at 10:31 PM, Lutz Sammer <johns98@gmx.net> wrote: > On 10/06/11 20:56, Manu Abraham wrote: >> >> Mauro, >> >> comments in-line. >> >> On Sat, Oct 1, 2011 at 12:28 AM, Mauro Carvalho Chehab >> <mchehab@redhat.com> wrote: >>> >>> Em 30-09-2011 15:41, Lutz Sammer escreveu: >>>> >>>> On 09/30/11 19:07, Mauro Carvalho Chehab wrote: >>>>> >>>>> Em 29-09-2011 18:22, Lutz Sammer escreveu: >>>>>> >>>>>> Another version of >>>>>> http://patchwork.linuxtv.org/patch/6307 >>>>>> http://patchwork.linuxtv.org/patch/6510 >>>>>> which was superseded or rejected, but I don't know why. >>>>> >>>>> Probably because of the same reason of this patch [1]: >>>>> >>>>> patch -p1 -i >>>>> patches/lmml_8023_v2_stb0899_fix_slow_and_not_locking_dvb_s_transponder_s.patch >>>>> --dry-run -t -N >>>>> patching file drivers/media/dvb/frontends/stb0899_algo.c >>>>> Hunk #1 FAILED at 358. >>>>> 1 out of 1 hunk FAILED -- saving rejects to file >>>>> drivers/media/dvb/frontends/stb0899_algo.c.rej >>>>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> I'll mark this one as rejected, as it doesn't apply upstream[2]. >>>>> >>>>> [1] http://patchwork.linuxtv.org/patch/8023/ >>>>> [2] at tree/branch: git://linuxtv.org/media_tree.git staging/for_v3.2 >>>>> >>>>> Please test if the changes made upstream to solve a similar trouble >>>>> fixes your issue. >>>>> If not, please rebase your patch on the top of it and resend. >>>>> >>>>> Thanks, >>>>> Mauro >>>>>> >>>>>> In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS >>>>>> could read old (from previous search) status bits and the search fails >>>>>> on a good frequency. >>>>>> >>>>>> With the patch more transponder could be locked and locks about 2* >>>>>> faster. >>> >>> Manu, >>> >>> Could you please review this one-line patch? >>> >>> >>>>>> >>>>>> Signed-off-by: Lutz Sammer<johns98@gmx.net> >>>>>> --- >>>>>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>>>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>>>> >>>>>> diff --git a/drivers/media/dvb/frontends/stb0899_algo.c >>>>>> b/drivers/media/dvb/frontends/stb0899_algo.c >>>>>> index d70eee0..8eca419 100644 >>>>>> --- a/drivers/media/dvb/frontends/stb0899_algo.c >>>>>> +++ b/drivers/media/dvb/frontends/stb0899_algo.c >>>>>> @@ -358,6 +358,7 @@ static enum stb0899_status >>>>>> stb0899_check_data(struct stb0899_state *state) >>>>>> else >>>>>> dataTime = 500; >>>>>> >>>>>> + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status >>>>>> bits */ >>>>>> stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force >>>>>> search loop */ >>>>>> while (1) { >>>>>> /* WARNING! VIT LOCKED has to be tested before >>>>>> VIT_END_LOOOP */ >>> >> >> Please add in these comments, in case you want to apply the change. I >> am neither for the patch, nor against it. >> >> - In fact, it doesn't hurt to read STATUS just before LOCK test. >> - I wasn't able to find any noticeable difference in LOCK acquisition. >> - Nowhere, I was able to find that reading VSTATUS, clears the >> Read-Only bits set by the onchip microcontroller. The above comment >> could be wrong at least, as far as I can say. >> >> But that said, if the change does really help (thinking of strange >> issues with some Silicon cuts) >> >> Acked-by: Manu Abraham<manu@linuxtv.org> >> >> Regards, >> Manu >> > > To be exact only the loop bit is reset by the read: > > kernel: [62791.427869] stb0899: vstatus 40 00 40 00 > kernel: [62791.597609] stb0899: vstatus 00 00 18 18 > > Printed twice before and after the loop. I tested this with the > tt-3600 and tt-3650. Ok, reading VSTATUS might force the VIT_END_LOOP to be refreshed (cached copy) in some cases where it probably never cleared due to some internal error. In fact, actually it should be automatically be cleared, surprised that it didn't. Can you please adjust the comment to state: Clear previous failed END_LOOPVIT ? Mauro, The following patch can be applied, with a modified comment similar to the above. Reviewed-by: Manu Abraham <manu@linuxtv.org> Thanks, Manu ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] stb0899: Fix slow and not locking DVB-S transponder(s) 2011-10-07 18:20 ` Manu Abraham @ 2011-10-07 20:11 ` Lutz Sammer 0 siblings, 0 replies; 10+ messages in thread From: Lutz Sammer @ 2011-10-07 20:11 UTC (permalink / raw) To: Manu Abraham; +Cc: Mauro Carvalho Chehab, linux-media [-- Attachment #1: Type: text/plain, Size: 4657 bytes --] On 10/07/11 20:20, Manu Abraham wrote: > On Fri, Oct 7, 2011 at 10:31 PM, Lutz Sammer<johns98@gmx.net> wrote: >> On 10/06/11 20:56, Manu Abraham wrote: >>> >>> Mauro, >>> >>> comments in-line. >>> >>> On Sat, Oct 1, 2011 at 12:28 AM, Mauro Carvalho Chehab >>> <mchehab@redhat.com> wrote: >>>> >>>> Em 30-09-2011 15:41, Lutz Sammer escreveu: >>>>> >>>>> On 09/30/11 19:07, Mauro Carvalho Chehab wrote: >>>>>> >>>>>> Em 29-09-2011 18:22, Lutz Sammer escreveu: >>>>>>> >>>>>>> Another version of >>>>>>> http://patchwork.linuxtv.org/patch/6307 >>>>>>> http://patchwork.linuxtv.org/patch/6510 >>>>>>> which was superseded or rejected, but I don't know why. >>>>>> >>>>>> Probably because of the same reason of this patch [1]: >>>>>> >>>>>> patch -p1 -i >>>>>> patches/lmml_8023_v2_stb0899_fix_slow_and_not_locking_dvb_s_transponder_s.patch >>>>>> --dry-run -t -N >>>>>> patching file drivers/media/dvb/frontends/stb0899_algo.c >>>>>> Hunk #1 FAILED at 358. >>>>>> 1 out of 1 hunk FAILED -- saving rejects to file >>>>>> drivers/media/dvb/frontends/stb0899_algo.c.rej >>>>>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>>>>> 1 file changed, 1 insertion(+) >>>>>> >>>>>> I'll mark this one as rejected, as it doesn't apply upstream[2]. >>>>>> >>>>>> [1] http://patchwork.linuxtv.org/patch/8023/ >>>>>> [2] at tree/branch: git://linuxtv.org/media_tree.git staging/for_v3.2 >>>>>> >>>>>> Please test if the changes made upstream to solve a similar trouble >>>>>> fixes your issue. >>>>>> If not, please rebase your patch on the top of it and resend. >>>>>> >>>>>> Thanks, >>>>>> Mauro >>>>>>> >>>>>>> In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS >>>>>>> could read old (from previous search) status bits and the search fails >>>>>>> on a good frequency. >>>>>>> >>>>>>> With the patch more transponder could be locked and locks about 2* >>>>>>> faster. >>>> >>>> Manu, >>>> >>>> Could you please review this one-line patch? >>>> >>>> >>>>>>> >>>>>>> Signed-off-by: Lutz Sammer<johns98@gmx.net> >>>>>>> --- >>>>>>> drivers/media/dvb/frontends/stb0899_algo.c | 1 + >>>>>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/media/dvb/frontends/stb0899_algo.c >>>>>>> b/drivers/media/dvb/frontends/stb0899_algo.c >>>>>>> index d70eee0..8eca419 100644 >>>>>>> --- a/drivers/media/dvb/frontends/stb0899_algo.c >>>>>>> +++ b/drivers/media/dvb/frontends/stb0899_algo.c >>>>>>> @@ -358,6 +358,7 @@ static enum stb0899_status >>>>>>> stb0899_check_data(struct stb0899_state *state) >>>>>>> else >>>>>>> dataTime = 500; >>>>>>> >>>>>>> + stb0899_read_reg(state, STB0899_VSTATUS); /* clear old status >>>>>>> bits */ >>>>>>> stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force >>>>>>> search loop */ >>>>>>> while (1) { >>>>>>> /* WARNING! VIT LOCKED has to be tested before >>>>>>> VIT_END_LOOOP */ >>>> >>> >>> Please add in these comments, in case you want to apply the change. I >>> am neither for the patch, nor against it. >>> >>> - In fact, it doesn't hurt to read STATUS just before LOCK test. >>> - I wasn't able to find any noticeable difference in LOCK acquisition. >>> - Nowhere, I was able to find that reading VSTATUS, clears the >>> Read-Only bits set by the onchip microcontroller. The above comment >>> could be wrong at least, as far as I can say. >>> >>> But that said, if the change does really help (thinking of strange >>> issues with some Silicon cuts) >>> >>> Acked-by: Manu Abraham<manu@linuxtv.org> >>> >>> Regards, >>> Manu >>> >> >> To be exact only the loop bit is reset by the read: >> >> kernel: [62791.427869] stb0899: vstatus 40 00 40 00 >> kernel: [62791.597609] stb0899: vstatus 00 00 18 18 >> >> Printed twice before and after the loop. I tested this with the >> tt-3600 and tt-3650. > > Ok, reading VSTATUS might force the VIT_END_LOOP to be refreshed > (cached copy) in some cases where it probably never cleared due to > some internal error. In fact, actually it should be automatically be > cleared, surprised that it didn't. > > Can you please adjust the comment to state: Clear previous failed END_LOOPVIT ? > > Mauro, > > The following patch can be applied, with a modified comment similar to > the above. > Reviewed-by: Manu Abraham<manu@linuxtv.org> > > Thanks, > Manu > In stb0899_status stb0899_check_data the first read of STB0899_VSTATUS could read old (from previous search) LOOP status bit and the search fails on a good frequency. With the patch more transponder could be locked and locks about 2* faster. Signed-off-by: Lutz Sammer<johns98@gmx.net> [-- Attachment #2: stb0899-Fix-slow-and-not-locking-DVB-S-transponders.patch --] [-- Type: text/plain, Size: 597 bytes --] diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c index d70eee0..117a569 100644 --- a/drivers/media/dvb/frontends/stb0899_algo.c +++ b/drivers/media/dvb/frontends/stb0899_algo.c @@ -358,6 +358,9 @@ static enum stb0899_status stb0899_check_data(struct stb0899_state *state) else dataTime = 500; + /* clear previous failed END_LOOPVIT */ + stb0899_read_reg(state, STB0899_VSTATUS); + stb0899_write_reg(state, STB0899_DSTATUS2, 0x00); /* force search loop */ while (1) { /* WARNING! VIT LOCKED has to be tested before VIT_END_LOOOP */ ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] stb0899: Fix slow and not locking DVB-S transponder(s)
@ 2011-09-30 15:01 Tuxoholic
0 siblings, 0 replies; 10+ messages in thread
From: Tuxoholic @ 2011-09-30 15:01 UTC (permalink / raw)
To: linux-media, abraham.manu, johns98
On Thu, 29 Sep 2011 23:22, Lutz Sammer wrote:
> With the patch more transponder could be locked and locks about 2* faster.
I second that, tested against vanilla kernel 3.0.1 with and w.o patch
and the Twinhan 1041.
Manu, you know there's sth wrong with the algo, so please review,
comment and ack - same goes for the Mantis Remote patch.
Thanks!
^ permalink raw reply [flat|nested] 10+ messages in threadend of thread, other threads:[~2011-10-07 20:11 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-09-29 21:16 [PATCH] stb0899: Fix slow and not locking DVB-S transponder(s) Lutz Sammer 2011-09-29 21:22 ` [PATCH v2] " Lutz Sammer 2011-09-30 17:07 ` Mauro Carvalho Chehab 2011-09-30 18:41 ` Lutz Sammer 2011-09-30 18:58 ` Mauro Carvalho Chehab 2011-10-06 18:56 ` Manu Abraham 2011-10-07 17:01 ` Lutz Sammer 2011-10-07 18:20 ` Manu Abraham 2011-10-07 20:11 ` [PATCH v3] " Lutz Sammer 2011-09-30 15:01 [PATCH v2] " Tuxoholic
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.