* [PATCH] git-gui--askpass: generalize the window title
@ 2016-02-01 12:11 Sebastian Schuberth
2016-02-12 9:26 ` Sebastian Schuberth
2017-03-07 15:48 ` [RESEND PATCH] " Sebastian Schuberth
0 siblings, 2 replies; 8+ messages in thread
From: Sebastian Schuberth @ 2016-02-01 12:11 UTC (permalink / raw)
To: git
From: Sebastian Schuberth <sschuberth@gmail.com>
git-gui--askpass is not only used for SSH authentication, but also for
HTTPS. In that context it is confusing to have a window title of
"OpenSSH". So generalize the title so that it also says which parent
process, i.e. Git, requires authentication.
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
git-gui/git-gui--askpass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
index 4277f30..1e5c325 100755
--- a/git-gui/git-gui--askpass
+++ b/git-gui/git-gui--askpass
@@ -60,7 +60,7 @@ proc finish {} {
set ::rc 0
}
-wm title . "OpenSSH"
+wm title . "Git Authentication"
tk::PlaceWindow .
vwait rc
exit $rc
--
https://github.com/git/git/pull/195
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] git-gui--askpass: generalize the window title
2016-02-01 12:11 [PATCH] git-gui--askpass: generalize the window title Sebastian Schuberth
@ 2016-02-12 9:26 ` Sebastian Schuberth
2017-03-07 15:48 ` [RESEND PATCH] " Sebastian Schuberth
1 sibling, 0 replies; 8+ messages in thread
From: Sebastian Schuberth @ 2016-02-12 9:26 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Shawn Pearce
On 01.02.2016 13:11, Sebastian Schuberth wrote:
> git-gui--askpass is not only used for SSH authentication, but also for
> HTTPS. In that context it is confusing to have a window title of
> "OpenSSH". So generalize the title so that it also says which parent
> process, i.e. Git, requires authentication.
>
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
I haven't seen this being picked up so far. Any comments?
--
Sebastian Schuberth
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND PATCH] git-gui--askpass: generalize the window title
2016-02-01 12:11 [PATCH] git-gui--askpass: generalize the window title Sebastian Schuberth
2016-02-12 9:26 ` Sebastian Schuberth
@ 2017-03-07 15:48 ` Sebastian Schuberth
2017-03-07 18:30 ` Stefan Beller
2017-04-27 6:38 ` [PATCH v2] git-gui--askpass: generalize the wording Sebastian Schuberth
1 sibling, 2 replies; 8+ messages in thread
From: Sebastian Schuberth @ 2017-03-07 15:48 UTC (permalink / raw)
To: git
git-gui--askpass is not only used for SSH authentication, but also for
HTTPS. In that context it is confusing to have a window title of
"OpenSSH". So generalize the title so that it also says which parent
process, i.e. Git, requires authentication.
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
git-gui/git-gui--askpass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
index 4277f30..1e5c3256 100755
--- a/git-gui/git-gui--askpass
+++ b/git-gui/git-gui--askpass
@@ -60,7 +60,7 @@ proc finish {} {
set ::rc 0
}
-wm title . "OpenSSH"
+wm title . "Git Authentication"
tk::PlaceWindow .
vwait rc
exit $rc
--
https://github.com/git/git/pull/195
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] git-gui--askpass: generalize the window title
2017-03-07 15:48 ` [RESEND PATCH] " Sebastian Schuberth
@ 2017-03-07 18:30 ` Stefan Beller
2017-03-07 18:40 ` Sebastian Schuberth
2017-04-27 6:38 ` [PATCH v2] git-gui--askpass: generalize the wording Sebastian Schuberth
1 sibling, 1 reply; 8+ messages in thread
From: Stefan Beller @ 2017-03-07 18:30 UTC (permalink / raw)
To: Sebastian Schuberth, Pat Thoyts; +Cc: git
https://public-inbox.org/git/xmqq60jz2xry.fsf@gitster.mtv.corp.google.com/
Although the following are included in git.git repository, they have their
own authoritative repository and maintainers:
- git-gui/ comes from git-gui project, maintained by Pat Thoyts:
git://repo.or.cz/git-gui.git
I cc'd Pat.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] git-gui--askpass: generalize the window title
2017-03-07 18:30 ` Stefan Beller
@ 2017-03-07 18:40 ` Sebastian Schuberth
0 siblings, 0 replies; 8+ messages in thread
From: Sebastian Schuberth @ 2017-03-07 18:40 UTC (permalink / raw)
To: Stefan Beller; +Cc: Pat Thoyts, git
On Tue, Mar 7, 2017 at 7:30 PM, Stefan Beller <sbeller@google.com> wrote:
> Although the following are included in git.git repository, they have their
> own authoritative repository and maintainers:
Thanks. I continuously get confused by this fact.
--
Sebastian Schuberth
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] git-gui--askpass: generalize the wording
2017-03-07 15:48 ` [RESEND PATCH] " Sebastian Schuberth
2017-03-07 18:30 ` Stefan Beller
@ 2017-04-27 6:38 ` Sebastian Schuberth
2017-04-27 9:19 ` Sebastian Schuberth
1 sibling, 1 reply; 8+ messages in thread
From: Sebastian Schuberth @ 2017-04-27 6:38 UTC (permalink / raw)
To: git
git-gui--askpass is not only used for SSH authentication, but also for
HTTPS. In that context it is confusing to only rfer to "OpenSSH", also
because another SSH client like PuTTY might be in use. So generalize
wording and also say which parent process, i.e. Git, requires
authentication.
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
git-gui/git-gui--askpass | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
index 4277f30..4e3f00d 100755
--- a/git-gui/git-gui--askpass
+++ b/git-gui/git-gui--askpass
@@ -2,7 +2,7 @@
# Tcl ignores the next line -*- tcl -*- \
exec wish "$0" -- "$@"
-# This is a trivial implementation of an SSH_ASKPASS handler.
+# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.
# Git-gui uses this script if none are already configured.
package require Tk
@@ -12,7 +12,7 @@ set yesno 0
set rc 255
if {$argc < 1} {
- set prompt "Enter your OpenSSH passphrase:"
+ set prompt "Enter your password / passphrase:"
} else {
set prompt [join $argv " "]
if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} {
@@ -60,7 +60,7 @@ proc finish {} {
set ::rc 0
}
-wm title . "OpenSSH"
+wm title . "Git Authentication"
tk::PlaceWindow .
vwait rc
exit $rc
--
https://github.com/git/git/pull/195
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] git-gui--askpass: generalize the wording
2017-04-27 6:38 ` [PATCH v2] git-gui--askpass: generalize the wording Sebastian Schuberth
@ 2017-04-27 9:19 ` Sebastian Schuberth
2017-04-27 14:02 ` Johannes Schindelin
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Schuberth @ 2017-04-27 9:19 UTC (permalink / raw)
To: git
+ Pat
On 2017-04-27 08:38, Sebastian Schuberth wrote:
> git-gui--askpass is not only used for SSH authentication, but also for
> HTTPS. In that context it is confusing to only rfer to "OpenSSH", also
> because another SSH client like PuTTY might be in use. So generalize
> wording and also say which parent process, i.e. Git, requires
> authentication.
>
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---
> git-gui/git-gui--askpass | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
> index 4277f30..4e3f00d 100755
> --- a/git-gui/git-gui--askpass
> +++ b/git-gui/git-gui--askpass
> @@ -2,7 +2,7 @@
> # Tcl ignores the next line -*- tcl -*- \
> exec wish "$0" -- "$@"
>
> -# This is a trivial implementation of an SSH_ASKPASS handler.
> +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.
> # Git-gui uses this script if none are already configured.
>
> package require Tk
> @@ -12,7 +12,7 @@ set yesno 0
> set rc 255
>
> if {$argc < 1} {
> - set prompt "Enter your OpenSSH passphrase:"
> + set prompt "Enter your password / passphrase:"
> } else {
> set prompt [join $argv " "]
> if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} {
> @@ -60,7 +60,7 @@ proc finish {} {
> set ::rc 0
> }
>
> -wm title . "OpenSSH"
> +wm title . "Git Authentication"
> tk::PlaceWindow .
> vwait rc
> exit $rc
>
--
Sebastian Schuberth
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] git-gui--askpass: generalize the wording
2017-04-27 9:19 ` Sebastian Schuberth
@ 2017-04-27 14:02 ` Johannes Schindelin
0 siblings, 0 replies; 8+ messages in thread
From: Johannes Schindelin @ 2017-04-27 14:02 UTC (permalink / raw)
To: Sebastian Schuberth; +Cc: git, Pat Thoyts
+ Pat
On Thu, 27 Apr 2017, Sebastian Schuberth wrote:
> + Pat
>
> On 2017-04-27 08:38, Sebastian Schuberth wrote:
>
> > git-gui--askpass is not only used for SSH authentication, but also for
> > HTTPS. In that context it is confusing to only rfer to "OpenSSH", also
> > because another SSH client like PuTTY might be in use. So generalize
> > wording and also say which parent process, i.e. Git, requires
> > authentication.
> >
> > Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> > ---
> > git-gui/git-gui--askpass | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
> > index 4277f30..4e3f00d 100755
> > --- a/git-gui/git-gui--askpass
> > +++ b/git-gui/git-gui--askpass
> > @@ -2,7 +2,7 @@
> > # Tcl ignores the next line -*- tcl -*- \
> > exec wish "$0" -- "$@"
> >
> > -# This is a trivial implementation of an SSH_ASKPASS handler.
> > +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.
> > # Git-gui uses this script if none are already configured.
> >
> > package require Tk
> > @@ -12,7 +12,7 @@ set yesno 0
> > set rc 255
> >
> > if {$argc < 1} {
> > - set prompt "Enter your OpenSSH passphrase:"
> > + set prompt "Enter your password / passphrase:"
> > } else {
> > set prompt [join $argv " "]
> > if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} {
> > @@ -60,7 +60,7 @@ proc finish {} {
> > set ::rc 0
> > }
> >
> > -wm title . "OpenSSH"
> > +wm title . "Git Authentication"
> > tk::PlaceWindow .
> > vwait rc
> > exit $rc
> >
>
>
> --
> Sebastian Schuberth
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-04-27 14:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-01 12:11 [PATCH] git-gui--askpass: generalize the window title Sebastian Schuberth
2016-02-12 9:26 ` Sebastian Schuberth
2017-03-07 15:48 ` [RESEND PATCH] " Sebastian Schuberth
2017-03-07 18:30 ` Stefan Beller
2017-03-07 18:40 ` Sebastian Schuberth
2017-04-27 6:38 ` [PATCH v2] git-gui--askpass: generalize the wording Sebastian Schuberth
2017-04-27 9:19 ` Sebastian Schuberth
2017-04-27 14:02 ` Johannes Schindelin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.