[PATCH net-next 0/5] net: wwan: t7xx: fw flashing & coredump support

[PATCH net-next 0/5] net: wwan: t7xx: fw flashing & coredump support

[m.chetan.kumar]

From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>

This patch series brings-in the support for FM350 wwan device firmware
flashing & coredump collection using devlink interface.

Below is the high level description of individual patches.
Refer to individual patch commit message for details.

PATCH1:  Enables AP CLDMA communication for firmware flashing &
coredump collection.

PATCH2: Enables the infrastructure & queue configuration required
for early ports enumeration.

PATCH3: Implements device reset and rescan logic required to enter
or exit fastboot mode.

PATCH4: Implements devlink interface & uses the fastboot protocol for
fw flashing and coredump collection.

PATCH5: t7xx devlink commands documentation.

Haijun Liu (3):
  net: wwan: t7xx: Add AP CLDMA
  net: wwan: t7xx: Infrastructure for early port configuration
  net: wwan: t7xx: PCIe reset rescan

M Chetan Kumar (2):
  net: wwan: t7xx: Enable devlink based fw flashing and coredump
    collection
  net: wwan: t7xx: Devlink documentation

 Documentation/networking/devlink/index.rst |   1 +
 Documentation/networking/devlink/t7xx.rst  | 145 +++++
 drivers/net/wwan/Kconfig                   |   1 +
 drivers/net/wwan/t7xx/Makefile             |   5 +-
 drivers/net/wwan/t7xx/t7xx_hif_cldma.c     |  55 +-
 drivers/net/wwan/t7xx/t7xx_hif_cldma.h     |  26 +-
 drivers/net/wwan/t7xx/t7xx_mhccif.h        |   1 +
 drivers/net/wwan/t7xx/t7xx_modem_ops.c     |  92 ++-
 drivers/net/wwan/t7xx/t7xx_modem_ops.h     |   3 +
 drivers/net/wwan/t7xx/t7xx_pci.c           |  65 +-
 drivers/net/wwan/t7xx/t7xx_pci.h           |   3 +
 drivers/net/wwan/t7xx/t7xx_pci_rescan.c    | 117 ++++
 drivers/net/wwan/t7xx/t7xx_pci_rescan.h    |  29 +
 drivers/net/wwan/t7xx/t7xx_port.h          |  12 +-
 drivers/net/wwan/t7xx/t7xx_port_ctrl_msg.c |   8 +-
 drivers/net/wwan/t7xx/t7xx_port_devlink.c  | 705 +++++++++++++++++++++
 drivers/net/wwan/t7xx/t7xx_port_devlink.h  |  85 +++
 drivers/net/wwan/t7xx/t7xx_port_proxy.c    | 132 +++-
 drivers/net/wwan/t7xx/t7xx_port_proxy.h    |  12 +-
 drivers/net/wwan/t7xx/t7xx_port_wwan.c     |   9 +-
 drivers/net/wwan/t7xx/t7xx_reg.h           |  31 +-
 drivers/net/wwan/t7xx/t7xx_state_monitor.c | 158 ++++-
 drivers/net/wwan/t7xx/t7xx_state_monitor.h |   4 +
 drivers/net/wwan/t7xx/t7xx_uevent.c        |  41 ++
 drivers/net/wwan/t7xx/t7xx_uevent.h        |  39 ++
 25 files changed, 1706 insertions(+), 73 deletions(-)
 create mode 100644 Documentation/networking/devlink/t7xx.rst
 create mode 100644 drivers/net/wwan/t7xx/t7xx_pci_rescan.c
 create mode 100644 drivers/net/wwan/t7xx/t7xx_pci_rescan.h
 create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.c
 create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.h
 create mode 100644 drivers/net/wwan/t7xx/t7xx_uevent.c
 create mode 100644 drivers/net/wwan/t7xx/t7xx_uevent.h

--
2.34.1

Re: [PATCH net-next 0/5] net: wwan: t7xx: fw flashing & coredump support

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 16 Aug 2022 09:53:01 +0530 you wrote:
> From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
> 
> This patch series brings-in the support for FM350 wwan device firmware
> flashing & coredump collection using devlink interface.
> 
> Below is the high level description of individual patches.
> Refer to individual patch commit message for details.
> 
> [...]

Here is the summary with links:
  - [net-next,1/5] net: wwan: t7xx: Add AP CLDMA
    https://git.kernel.org/netdev/net-next/c/d20ef656f994
  - [net-next,2/5] net: wwan: t7xx: Infrastructure for early port configuration
    https://git.kernel.org/netdev/net-next/c/007f26f0d68e
  - [net-next,3/5] net: wwan: t7xx: PCIe reset rescan
    https://git.kernel.org/netdev/net-next/c/140424d90165
  - [net-next,4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection
    https://git.kernel.org/netdev/net-next/c/87dae9e70bf7
  - [net-next,5/5] net: wwan: t7xx: Devlink documentation
    https://git.kernel.org/netdev/net-next/c/b0bc1709b768

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next 0/5] net: wwan: t7xx: fw flashing & coredump support

[Sergey Ryazanov]

Hello,

On Tue, Aug 16, 2022 at 7:11 AM <m.chetan.kumar@intel.com> wrote:
> This patch series brings-in the support for FM350 wwan device firmware
> flashing & coredump collection using devlink interface.
>
> Below is the high level description of individual patches.
> Refer to individual patch commit message for details.
>
> PATCH1:  Enables AP CLDMA communication for firmware flashing &
> coredump collection.
>
> PATCH2: Enables the infrastructure & queue configuration required
> for early ports enumeration.
>
> PATCH3: Implements device reset and rescan logic required to enter
> or exit fastboot mode.
>
> PATCH4: Implements devlink interface & uses the fastboot protocol for
> fw flashing and coredump collection.
>
> PATCH5: t7xx devlink commands documentation.

Generally the code looks good to me, but needs some cleanup. It also
has a couple of questionable parts:
* implicit fastboot mode entering;
* PCI device reset handling approach.

Please find comments in the corresponding patches.

-- 
Sergey