* agetty not show username as I input on a serial term
@ 2011-09-02 6:26 xinglp
2011-09-26 10:52 ` Karel Zak
0 siblings, 1 reply; 2+ messages in thread
From: xinglp @ 2011-09-02 6:26 UTC (permalink / raw)
To: util-linux
I'm using util-linux-2.20.
/etc/inittab has the line below:
s0:2345:respawn:/sbin/agetty ttyS0 9600 --long-hostname --noclear
When I login on a serial term, I type username, but nothing appear
on the screen, just as input password.
Only when input a wrong password, and try again, I can see the
username as I typed,
but that was done by /bin/login
It looks like the "ECHO bit in termios.c_cflag" was not properly set
before the get_logname() been called.
called at term-utils/agetty.c line 391
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: agetty not show username as I input on a serial term
2011-09-02 6:26 agetty not show username as I input on a serial term xinglp
@ 2011-09-26 10:52 ` Karel Zak
0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2011-09-26 10:52 UTC (permalink / raw)
To: xinglp; +Cc: util-linux
On Fri, Sep 02, 2011 at 02:26:17PM +0800, xinglp wrote:
> When I login on a serial term, I type username, but nothing appear
> on the screen, just as input password.
[...]
> It looks like the "ECHO bit in termios.c_cflag" was not properly set
> before the get_logname() been called.
The code incorrectly checks c_cflag, but the ECHO is c_lflag flag
constant.
See the patch below. Thanks!
Karel
>From b9261127260ff2a8efbdc6e5f9d00ec7f736b445 Mon Sep 17 00:00:00 2001
From: Karel Zak <kzak@redhat.com>
Date: Mon, 26 Sep 2011 12:34:10 +0200
Subject: [PATCH] agetty: test ECHO on c_lflag
Reported-by: xinglp <xinglp@gmail.com>
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=739522
Signed-off-by: Karel Zak <kzak@redhat.com>
---
term-utils/agetty.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/term-utils/agetty.c b/term-utils/agetty.c
index 8398015..75c2b14 100644
--- a/term-utils/agetty.c
+++ b/term-utils/agetty.c
@@ -1466,7 +1466,7 @@ static char *get_logname(struct options *op, struct termios *tp, struct chardata
case '#':
cp->erase = ascval; /* set erase character */
if (bp > logname) {
- if ((tp->c_cflag & (ECHO)) == 0)
+ if ((tp->c_lflag & ECHO) == 0)
write_all(1, erase[cp->parity], 3);
bp--;
}
@@ -1475,7 +1475,7 @@ static char *get_logname(struct options *op, struct termios *tp, struct chardata
case '@':
cp->kill = ascval; /* set kill character */
while (bp > logname) {
- if ((tp->c_cflag & (ECHO)) == 0)
+ if ((tp->c_lflag & ECHO) == 0)
write_all(1, erase[cp->parity], 3);
bp--;
}
@@ -1487,7 +1487,7 @@ static char *get_logname(struct options *op, struct termios *tp, struct chardata
break;
if ((size_t)(bp - logname) >= sizeof(logname) - 1)
log_err(_("%s: input overrun"), op->tty);
- if ((tp->c_cflag & (ECHO)) == 0)
+ if ((tp->c_lflag & ECHO) == 0)
write_all(1, &c, 1); /* echo the character */
*bp++ = ascval; /* and store it */
break;
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-26 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-02 6:26 agetty not show username as I input on a serial term xinglp
2011-09-26 10:52 ` Karel Zak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.