[bisected] no traffic on ssl vpn with 3.19rc1 - 3.19rc3

[bisected] no traffic on ssl vpn with 3.19rc1 - 3.19rc3

[Billy Shuman]

Hi,

Since 3.19rc1 I get 100% packet loss through SSL vpn.  I bisected with
the following result:

0b46d0ee9c240c7430a47e9b0365674d4a04522 is the first bad commit
commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Fri Nov 7 21:22:23 2014 +0800

    tun: Use iovec iterators

    This patch removes the use of skb_copy_datagram_const_iovec in
    favour of the iovec iterator-based skb_copy_datagram_iter.


https://bugzilla.kernel.org/show_bug.cgi?id=90901


Thanks,
Billy Shuman

Re: [bisected] no traffic on ssl vpn with 3.19rc1 - 3.19rc3

[Marcelo Ricardo Leitner]

On 07-01-2015 17:10, Billy Shuman wrote:
> Hi,
>
> Since 3.19rc1 I get 100% packet loss through SSL vpn.  I bisected with
> the following result:
>
> 0b46d0ee9c240c7430a47e9b0365674d4a04522 is the first bad commit
> commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date:   Fri Nov 7 21:22:23 2014 +0800
>
>      tun: Use iovec iterators
>
>      This patch removes the use of skb_copy_datagram_const_iovec in
>      favour of the iovec iterator-based skb_copy_datagram_iter.
>
>
> https://bugzilla.kernel.org/show_bug.cgi?id=90901

Interesting. Similar effect that I had but your version has the fix already.
http://article.gmane.org/gmane.linux.network/340700

   Marcelo

Re: [bisected] no traffic on ssl vpn with 3.19rc1 - 3.19rc3

[Herbert Xu]

Billy Shuman <wshuman3@gmail.com> wrote:
> 
> Since 3.19rc1 I get 100% packet loss through SSL vpn.  I bisected with
> the following result:
> 
> 0b46d0ee9c240c7430a47e9b0365674d4a04522 is the first bad commit
> commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date:   Fri Nov 7 21:22:23 2014 +0800
> 
>    tun: Use iovec iterators
> 
>    This patch removes the use of skb_copy_datagram_const_iovec in
>    favour of the iovec iterator-based skb_copy_datagram_iter.
> 
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=90901

This changeset is known to be buggy.  However it was fixed ages
ago by changeset 8c847d254146d32c86574a1b16923ff91bb784dd.

So please test that changeset to see if it works for you.  If it
does, then please do your bisection between that and the current
top of tree.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [bisected] no traffic on ssl vpn with 3.19rc1 - 3.19rc3

[Billy Shuman]

Changeset 8c847d254146d32c86574a1b16923ff91bb784dd did not resolve the
issue for me.

Should I target any other specific changesets?

Thanks,
Billy
William Shuman
Tel: 260-316-9300
Email: wshuman3@gmail.com


On Thu, Jan 8, 2015 at 3:57 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Billy Shuman <wshuman3@gmail.com> wrote:
>>
>> Since 3.19rc1 I get 100% packet loss through SSL vpn.  I bisected with
>> the following result:
>>
>> 0b46d0ee9c240c7430a47e9b0365674d4a04522 is the first bad commit
>> commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
>> Author: Herbert Xu <herbert@gondor.apana.org.au>
>> Date:   Fri Nov 7 21:22:23 2014 +0800
>>
>>    tun: Use iovec iterators
>>
>>    This patch removes the use of skb_copy_datagram_const_iovec in
>>    favour of the iovec iterator-based skb_copy_datagram_iter.
>>
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=90901
>
> This changeset is known to be buggy.  However it was fixed ages
> ago by changeset 8c847d254146d32c86574a1b16923ff91bb784dd.
>
> So please test that changeset to see if it works for you.  If it
> does, then please do your bisection between that and the current
> top of tree.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [bisected] no traffic on ssl vpn with 3.19rc1 - 3.19rc3

[Billy Shuman]

This patch from net-next ended up resolving my issue:

>From 957f094f221f81e457133b1f4c4d95ffa49ff731 Mon Sep 17 00:00:00 2001
From: Alex Gartrell <agartrell@fb.com>
Date: Thu, 25 Dec 2014 23:22:49 -0800
Subject: tun: return proper error code from tun_do_read

Instead of -1 with EAGAIN, read on a O_NONBLOCK tun fd will return 0.  This
fixes this by properly returning the error code from __skb_recv_datagram.

On Fri, Jan 9, 2015 at 8:13 AM, Billy Shuman <wshuman3@gmail.com> wrote:
> Changeset 8c847d254146d32c86574a1b16923ff91bb784dd did not resolve the
> issue for me.
>
> Should I target any other specific changesets?
>
> Thanks,
> Billy
> William Shuman
> Tel: 260-316-9300
> Email: wshuman3@gmail.com
>
>
> On Thu, Jan 8, 2015 at 3:57 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> Billy Shuman <wshuman3@gmail.com> wrote:
>>>
>>> Since 3.19rc1 I get 100% packet loss through SSL vpn.  I bisected with
>>> the following result:
>>>
>>> 0b46d0ee9c240c7430a47e9b0365674d4a04522 is the first bad commit
>>> commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
>>> Author: Herbert Xu <herbert@gondor.apana.org.au>
>>> Date:   Fri Nov 7 21:22:23 2014 +0800
>>>
>>>    tun: Use iovec iterators
>>>
>>>    This patch removes the use of skb_copy_datagram_const_iovec in
>>>    favour of the iovec iterator-based skb_copy_datagram_iter.
>>>
>>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=90901
>>
>> This changeset is known to be buggy.  However it was fixed ages
>> ago by changeset 8c847d254146d32c86574a1b16923ff91bb784dd.
>>
>> So please test that changeset to see if it works for you.  If it
>> does, then please do your bisection between that and the current
>> top of tree.
>>
>> Thanks,
>> --
>> Email: Herbert Xu <herbert@gondor.apana.org.au>
>> Home Page: http://gondor.apana.org.au/~herbert/
>> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt