* calls to rpc_peeraddr2str()
@ 2014-11-14 16:12 Olga Kornievskaia
2014-11-14 21:36 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Olga Kornievskaia @ 2014-11-14 16:12 UTC (permalink / raw)
To: linux-nfs
Should all calls to rpc_peeraddr2str() be protected with
rcu_read_lock(). callback_proc.c makes calls to rpc_peeraddr2str()
without acquiring such lock. Can somebody comment if this is a bug?
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: calls to rpc_peeraddr2str()
2014-11-14 16:12 calls to rpc_peeraddr2str() Olga Kornievskaia
@ 2014-11-14 21:36 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2014-11-14 21:36 UTC (permalink / raw)
To: Olga Kornievskaia; +Cc: linux-nfs
Hi Olga,
On Fri, Nov 14, 2014 at 11:12 AM, Olga Kornievskaia
<olga.kornievskaia@gmail.com> wrote:
> Should all calls to rpc_peeraddr2str() be protected with
> rcu_read_lock(). callback_proc.c makes calls to rpc_peeraddr2str()
> without acquiring such lock. Can somebody comment if this is a bug?
>
Those calls are made from inside the dprintk_rcu() macro, so they
should be safely protected by the rcu lock taken there.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-14 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-14 16:12 calls to rpc_peeraddr2str() Olga Kornievskaia
2014-11-14 21:36 ` Trond Myklebust
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.