* [chrome-os:chromeos-5.4 180/242] drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared; did you mean 'sq'?
@ 2021-04-17 3:15 kernel test robot
2021-04-17 3:52 ` Nicolas Boichat
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-04-17 3:15 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4109 bytes --]
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: 03c601082f2f279deba7e2b6923e735273c65587
commit: 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e [180/242] UPSTREAM: mt76: rely on AQL for burst size limits on tx queueing
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.4
git checkout 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Note: the chrome-os/chromeos-5.4 HEAD 03c601082f2f279deba7e2b6923e735273c65587 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/tx.c: In function 'mt76_txq_send_burst':
>> drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared (first use in this function); did you mean 'sq'?
504 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
| ^
| sq
drivers/net/wireless/mediatek/mt76/tx.c:504:7: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/mediatek/mt76/tx.c: In function 'mt76_txq_schedule_list':
drivers/net/wireless/mediatek/mt76/tx.c:547:7: error: 'q' undeclared (first use in this function); did you mean 'sq'?
547 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
| ^
| sq
vim +504 drivers/net/wireless/mediatek/mt76/tx.c
461
462 static int
463 mt76_txq_send_burst(struct mt76_phy *phy, struct mt76_sw_queue *sq,
464 struct mt76_txq *mtxq)
465 {
466 struct mt76_dev *dev = phy->dev;
467 struct ieee80211_txq *txq = mtxq_to_txq(mtxq);
468 enum mt76_txq_id qid = mt76_txq_get_qid(txq);
469 struct mt76_wcid *wcid = mtxq->wcid;
470 struct mt76_queue *hwq = sq->q;
471 struct ieee80211_tx_info *info;
472 struct sk_buff *skb;
473 int n_frames = 1;
474 bool stop = false;
475 int idx;
476
477 if (test_bit(MT_WCID_FLAG_PS, &wcid->flags))
478 return 0;
479
480 if (atomic_read(&wcid->non_aql_packets) >= MT_MAX_NON_AQL_PKT)
481 return 0;
482
483 skb = mt76_txq_dequeue(phy, mtxq, false);
484 if (!skb)
485 return 0;
486
487 info = IEEE80211_SKB_CB(skb);
488 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
489 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
490 info->control.rates, 1);
491
492 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta, &stop);
493 if (idx < 0)
494 return idx;
495
496 do {
497 if (test_bit(MT76_STATE_PM, &phy->state) ||
498 test_bit(MT76_RESET, &phy->state))
499 return -EBUSY;
500
501 if (stop)
502 break;
503
> 504 if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
505 break;
506
507 skb = mt76_txq_dequeue(phy, mtxq, false);
508 if (!skb)
509 break;
510
511 info = IEEE80211_SKB_CB(skb);
512 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
513 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
514 info->control.rates, 1);
515
516 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta, &stop);
517 if (idx < 0)
518 break;
519
520 n_frames++;
521 } while (1);
522
523 dev->queue_ops->kick(dev, hwq);
524
525 return n_frames;
526 }
527
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 51883 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [chrome-os:chromeos-5.4 180/242] drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared; did you mean 'sq'?
2021-04-17 3:15 [chrome-os:chromeos-5.4 180/242] drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared; did you mean 'sq'? kernel test robot
@ 2021-04-17 3:52 ` Nicolas Boichat
2021-04-19 3:36 ` Claire Chang
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Boichat @ 2021-04-17 3:52 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5472 bytes --]
+Claire Chang <tientzu@google.com>
On Sat, Apr 17, 2021 at 11:16 AM kernel test robot <lkp@intel.com> wrote:
> tree: https://chromium.googlesource.com/chromiumos/third_party/kernel
> chromeos-5.4
> head: 03c601082f2f279deba7e2b6923e735273c65587
> commit: 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e [180/242] UPSTREAM: mt76:
> rely on AQL for burst size limits on tx queueing
> config: nios2-allyesconfig (attached as .config)
> compiler: nios2-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git remote add chrome-os
> https://chromium.googlesource.com/chromiumos/third_party/kernel
> git fetch --no-tags chrome-os chromeos-5.4
> git checkout 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1
> ARCH=nios2
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> Note: the chrome-os/chromeos-5.4 HEAD
> 03c601082f2f279deba7e2b6923e735273c65587 builds fine.
> It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
> drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_send_burst':
> >> drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared
> (first use in this function); did you mean 'sq'?
> 504 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
> | ^
> | sq
> drivers/net/wireless/mediatek/mt76/tx.c:504:7: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_schedule_list':
> drivers/net/wireless/mediatek/mt76/tx.c:547:7: error: 'q' undeclared
> (first use in this function); did you mean 'sq'?
> 547 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
> | ^
> | sq
>
>
> vim +504 drivers/net/wireless/mediatek/mt76/tx.c
>
> 461
> 462 static int
> 463 mt76_txq_send_burst(struct mt76_phy *phy, struct mt76_sw_queue *sq,
> 464 struct mt76_txq *mtxq)
> 465 {
> 466 struct mt76_dev *dev = phy->dev;
> 467 struct ieee80211_txq *txq = mtxq_to_txq(mtxq);
> 468 enum mt76_txq_id qid = mt76_txq_get_qid(txq);
> 469 struct mt76_wcid *wcid = mtxq->wcid;
> 470 struct mt76_queue *hwq = sq->q;
> 471 struct ieee80211_tx_info *info;
> 472 struct sk_buff *skb;
> 473 int n_frames = 1;
> 474 bool stop = false;
> 475 int idx;
> 476
> 477 if (test_bit(MT_WCID_FLAG_PS, &wcid->flags))
> 478 return 0;
> 479
> 480 if (atomic_read(&wcid->non_aql_packets) >=
> MT_MAX_NON_AQL_PKT)
> 481 return 0;
> 482
> 483 skb = mt76_txq_dequeue(phy, mtxq, false);
> 484 if (!skb)
> 485 return 0;
> 486
> 487 info = IEEE80211_SKB_CB(skb);
> 488 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
> 489 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
> 490 info->control.rates, 1);
> 491
> 492 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta,
> &stop);
> 493 if (idx < 0)
> 494 return idx;
> 495
> 496 do {
> 497 if (test_bit(MT76_STATE_PM, &phy->state) ||
> 498 test_bit(MT76_RESET, &phy->state))
> 499 return -EBUSY;
> 500
> 501 if (stop)
> 502 break;
> 503
> > 504 if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
> 505 break;
> 506
> 507 skb = mt76_txq_dequeue(phy, mtxq, false);
> 508 if (!skb)
> 509 break;
> 510
> 511 info = IEEE80211_SKB_CB(skb);
> 512 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
> 513 ieee80211_get_tx_rates(txq->vif, txq->sta,
> skb,
> 514
> info->control.rates, 1);
> 515
> 516 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid,
> txq->sta, &stop);
> 517 if (idx < 0)
> 518 break;
> 519
> 520 n_frames++;
> 521 } while (1);
> 522
> 523 dev->queue_ops->kick(dev, hwq);
> 524
> 525 return n_frames;
> 526 }
> 527
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>
> --
> You received this message because you are subscribed to the Google Groups
> "cros-kernel-buildreports" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to cros-kernel-buildreports+unsubscribe(a)googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/cros-kernel-buildreports/202104171103.baCz56rh-lkp%40intel.com
> .
>
[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 7552 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [chrome-os:chromeos-5.4 180/242] drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared; did you mean 'sq'?
2021-04-17 3:52 ` Nicolas Boichat
@ 2021-04-19 3:36 ` Claire Chang
0 siblings, 0 replies; 3+ messages in thread
From: Claire Chang @ 2021-04-19 3:36 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5804 bytes --]
IIUC, this is caused by the patch order and should be fixed already. Sorry
for the inconvenience.
On Sat, Apr 17, 2021 at 11:52 AM Nicolas Boichat <drinkcat@google.com>
wrote:
> +Claire Chang <tientzu@google.com>
>
> On Sat, Apr 17, 2021 at 11:16 AM kernel test robot <lkp@intel.com> wrote:
>
>> tree: https://chromium.googlesource.com/chromiumos/third_party/kernel
>> chromeos-5.4
>> head: 03c601082f2f279deba7e2b6923e735273c65587
>> commit: 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e [180/242] UPSTREAM:
>> mt76: rely on AQL for burst size limits on tx queueing
>> config: nios2-allyesconfig (attached as .config)
>> compiler: nios2-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git remote add chrome-os
>> https://chromium.googlesource.com/chromiumos/third_party/kernel
>> git fetch --no-tags chrome-os chromeos-5.4
>> git checkout 0d7e331a785cdb87c2b4005d226bf8a22f7fd87e
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
>> W=1 ARCH=nios2
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> Note: the chrome-os/chromeos-5.4 HEAD
>> 03c601082f2f279deba7e2b6923e735273c65587 builds fine.
>> It only hurts bisectibility.
>>
>> All errors (new ones prefixed by >>):
>>
>> drivers/net/wireless/mediatek/mt76/tx.c: In function
>> 'mt76_txq_send_burst':
>> >> drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared
>> (first use in this function); did you mean 'sq'?
>> 504 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
>> | ^
>> | sq
>> drivers/net/wireless/mediatek/mt76/tx.c:504:7: note: each undeclared
>> identifier is reported only once for each function it appears in
>> drivers/net/wireless/mediatek/mt76/tx.c: In function
>> 'mt76_txq_schedule_list':
>> drivers/net/wireless/mediatek/mt76/tx.c:547:7: error: 'q' undeclared
>> (first use in this function); did you mean 'sq'?
>> 547 | if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
>> | ^
>> | sq
>>
>>
>> vim +504 drivers/net/wireless/mediatek/mt76/tx.c
>>
>> 461
>> 462 static int
>> 463 mt76_txq_send_burst(struct mt76_phy *phy, struct mt76_sw_queue
>> *sq,
>> 464 struct mt76_txq *mtxq)
>> 465 {
>> 466 struct mt76_dev *dev = phy->dev;
>> 467 struct ieee80211_txq *txq = mtxq_to_txq(mtxq);
>> 468 enum mt76_txq_id qid = mt76_txq_get_qid(txq);
>> 469 struct mt76_wcid *wcid = mtxq->wcid;
>> 470 struct mt76_queue *hwq = sq->q;
>> 471 struct ieee80211_tx_info *info;
>> 472 struct sk_buff *skb;
>> 473 int n_frames = 1;
>> 474 bool stop = false;
>> 475 int idx;
>> 476
>> 477 if (test_bit(MT_WCID_FLAG_PS, &wcid->flags))
>> 478 return 0;
>> 479
>> 480 if (atomic_read(&wcid->non_aql_packets) >=
>> MT_MAX_NON_AQL_PKT)
>> 481 return 0;
>> 482
>> 483 skb = mt76_txq_dequeue(phy, mtxq, false);
>> 484 if (!skb)
>> 485 return 0;
>> 486
>> 487 info = IEEE80211_SKB_CB(skb);
>> 488 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
>> 489 ieee80211_get_tx_rates(txq->vif, txq->sta, skb,
>> 490 info->control.rates, 1);
>> 491
>> 492 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid, txq->sta,
>> &stop);
>> 493 if (idx < 0)
>> 494 return idx;
>> 495
>> 496 do {
>> 497 if (test_bit(MT76_STATE_PM, &phy->state) ||
>> 498 test_bit(MT76_RESET, &phy->state))
>> 499 return -EBUSY;
>> 500
>> 501 if (stop)
>> 502 break;
>> 503
>> > 504 if (q->queued + MT_TXQ_FREE_THR >= q->ndesc)
>> 505 break;
>> 506
>> 507 skb = mt76_txq_dequeue(phy, mtxq, false);
>> 508 if (!skb)
>> 509 break;
>> 510
>> 511 info = IEEE80211_SKB_CB(skb);
>> 512 if (!(wcid->tx_info & MT_WCID_TX_INFO_SET))
>> 513 ieee80211_get_tx_rates(txq->vif,
>> txq->sta, skb,
>> 514
>> info->control.rates, 1);
>> 515
>> 516 idx = __mt76_tx_queue_skb(dev, qid, skb, wcid,
>> txq->sta, &stop);
>> 517 if (idx < 0)
>> 518 break;
>> 519
>> 520 n_frames++;
>> 521 } while (1);
>> 522
>> 523 dev->queue_ops->kick(dev, hwq);
>> 524
>> 525 return n_frames;
>> 526 }
>> 527
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "cros-kernel-buildreports" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to cros-kernel-buildreports+unsubscribe(a)googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/cros-kernel-buildreports/202104171103.baCz56rh-lkp%40intel.com
>> .
>>
>
[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 8075 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-19 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 3:15 [chrome-os:chromeos-5.4 180/242] drivers/net/wireless/mediatek/mt76/tx.c:504:7: error: 'q' undeclared; did you mean 'sq'? kernel test robot
2021-04-17 3:52 ` Nicolas Boichat
2021-04-19 3:36 ` Claire Chang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.