All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: zynqmp: Fix return value of board_fit_config_name_match
@ 2019-12-09 14:58 Michal Simek
  2020-01-16  7:26 ` Michal Simek
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2019-12-09 14:58 UTC (permalink / raw)
  To: u-boot

Empty implementation should not return 0 (success) because that mean that
passed name matches the board configuration.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/mach-zynqmp/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl.c
index 37f690d9b958..76bafcdd2a38 100644
--- a/arch/arm/mach-zynqmp/spl.c
+++ b/arch/arm/mach-zynqmp/spl.c
@@ -139,6 +139,6 @@ int board_fit_config_name_match(const char *name)
 	/* Just empty function now - can't decide what to choose */
 	debug("%s: %s\n", __func__, name);
 
-	return 0;
+	return -1;
 }
 #endif
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] arm64: zynqmp: Fix return value of board_fit_config_name_match
  2019-12-09 14:58 [PATCH] arm64: zynqmp: Fix return value of board_fit_config_name_match Michal Simek
@ 2020-01-16  7:26 ` Michal Simek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2020-01-16  7:26 UTC (permalink / raw)
  To: u-boot

po 9. 12. 2019 v 15:58 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> Empty implementation should not return 0 (success) because that mean that
> passed name matches the board configuration.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  arch/arm/mach-zynqmp/spl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl.c
> index 37f690d9b958..76bafcdd2a38 100644
> --- a/arch/arm/mach-zynqmp/spl.c
> +++ b/arch/arm/mach-zynqmp/spl.c
> @@ -139,6 +139,6 @@ int board_fit_config_name_match(const char *name)
>         /* Just empty function now - can't decide what to choose */
>         debug("%s: %s\n", __func__, name);
>
> -       return 0;
> +       return -1;
>  }
>  #endif
> --
> 2.24.0
>

Applied.
M

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-16  7:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 14:58 [PATCH] arm64: zynqmp: Fix return value of board_fit_config_name_match Michal Simek
2020-01-16  7:26 ` Michal Simek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.