* [PATCH] gpio: pca953x: Add missing i2c dependency
@ 2021-06-03 7:51 Michal Simek
2021-06-10 7:30 ` Michal Simek
2021-06-19 8:38 ` Heiko Schocher
0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2021-06-03 7:51 UTC (permalink / raw)
To: u-boot, git
Cc: Harm Berntsen, Heiko Schocher, Rayagonda Kokatanur,
Sheetal Tigadoli, Simon Glass, Stefan Bosch, Stefan Roese,
Suneel Garapati, Weijie Gao
pca953x also depends on i2c that's why add dependency to Kconfig.
Where GPIO is enabled but I2C compilation error pops up.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index d24884739bf2..de4dc51d4b48 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -396,7 +396,7 @@ config DM_74X164
config DM_PCA953X
bool "PCA95[357]x, PCA9698, TCA64xx, and MAX7310 I/O ports"
- depends on DM_GPIO
+ depends on DM_GPIO && DM_I2C
help
Say yes here to provide access to several register-oriented
SMBus I/O expanders, made mostly by NXP or TI. Compatible
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pca953x: Add missing i2c dependency
2021-06-03 7:51 [PATCH] gpio: pca953x: Add missing i2c dependency Michal Simek
@ 2021-06-10 7:30 ` Michal Simek
2021-06-19 8:38 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2021-06-10 7:30 UTC (permalink / raw)
To: U-Boot, git
Cc: Harm Berntsen, Heiko Schocher, Rayagonda Kokatanur,
Sheetal Tigadoli, Simon Glass, Stefan Bosch, Stefan Roese,
Suneel Garapati, Weijie Gao
čt 3. 6. 2021 v 9:51 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> pca953x also depends on i2c that's why add dependency to Kconfig.
> Where GPIO is enabled but I2C compilation error pops up.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index d24884739bf2..de4dc51d4b48 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -396,7 +396,7 @@ config DM_74X164
>
> config DM_PCA953X
> bool "PCA95[357]x, PCA9698, TCA64xx, and MAX7310 I/O ports"
> - depends on DM_GPIO
> + depends on DM_GPIO && DM_I2C
> help
> Say yes here to provide access to several register-oriented
> SMBus I/O expanders, made mostly by NXP or TI. Compatible
> --
> 2.31.1
>
Applied.
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pca953x: Add missing i2c dependency
2021-06-03 7:51 [PATCH] gpio: pca953x: Add missing i2c dependency Michal Simek
2021-06-10 7:30 ` Michal Simek
@ 2021-06-19 8:38 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2021-06-19 8:38 UTC (permalink / raw)
To: Michal Simek, u-boot, git
Cc: Harm Berntsen, Rayagonda Kokatanur, Sheetal Tigadoli,
Simon Glass, Stefan Bosch, Stefan Roese, Suneel Garapati,
Weijie Gao
Hello Michal,
On 03.06.21 09:51, Michal Simek wrote:
> pca953x also depends on i2c that's why add dependency to Kconfig.
> Where GPIO is enabled but I2C compilation error pops up.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-19 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 7:51 [PATCH] gpio: pca953x: Add missing i2c dependency Michal Simek
2021-06-10 7:30 ` Michal Simek
2021-06-19 8:38 ` Heiko Schocher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.