* [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
@ 2012-09-06 15:37 Raúl Sánchez Siles
2013-05-26 15:12 ` Samuel Martin
0 siblings, 1 reply; 7+ messages in thread
From: Raúl Sánchez Siles @ 2012-09-06 15:37 UTC (permalink / raw)
To: buildroot
In this case, autotools targets rely on $(TARGET_CONFIGURE_OPTS) which includes
ccached compiler.
Signed-off-by: Ra?l S?nchez Siles <rasasi78@gmail.com>
---
package/pkg-autotools.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index 785daab..e858ffc 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -200,6 +200,10 @@ $(2)_PRE_CONFIGURE_HOOKS += AUTORECONF_HOOK
$(2)_DEPENDENCIES += host-automake host-autoconf host-libtool
endif
+ifeq ($(BR2_CCACHE),y)
+$(2)_DEPENDENCIES += host-ccache
+endif
+
#
# Build step. Only define it if not already defined by the package .mk
# file.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
2012-09-06 15:37 [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled Raúl Sánchez Siles
@ 2013-05-26 15:12 ` Samuel Martin
2013-05-26 15:44 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Samuel Martin @ 2013-05-26 15:12 UTC (permalink / raw)
To: buildroot
Hi Raul,
2012/9/6 Ra?l S?nchez Siles <rasasi78@gmail.com>:
> In this case, autotools targets rely on $(TARGET_CONFIGURE_OPTS) which includes
> ccached compiler.
>
> Signed-off-by: Ra?l S?nchez Siles <rasasi78@gmail.com>
> ---
> package/pkg-autotools.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index 785daab..e858ffc 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -200,6 +200,10 @@ $(2)_PRE_CONFIGURE_HOOKS += AUTORECONF_HOOK
> $(2)_DEPENDENCIES += host-automake host-autoconf host-libtool
> endif
>
> +ifeq ($(BR2_CCACHE),y)
> +$(2)_DEPENDENCIES += host-ccache
> +endif
> +
This should not be necessary since host-ccache is added to the
BASE_TARGETS list in the Makefile at the root of buildroot.
Anyway, what was the issue and the 'make ...' call sequence that lead to it?
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
2013-05-26 15:12 ` Samuel Martin
@ 2013-05-26 15:44 ` Thomas Petazzoni
2013-05-26 17:00 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2013-05-26 15:44 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Sun, 26 May 2013 17:12:16 +0200, Samuel Martin wrote:
> This should not be necessary since host-ccache is added to the
> BASE_TARGETS list in the Makefile at the root of buildroot.
Maybe:
make menuconfig
make <somepackage>
i.e, not starting the complete build, but just the build of a given
package?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
2013-05-26 15:44 ` Thomas Petazzoni
@ 2013-05-26 17:00 ` Thomas Petazzoni
2013-05-26 17:44 ` Samuel Martin
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2013-05-26 17:00 UTC (permalink / raw)
To: buildroot
Samuel,
On Sun, 26 May 2013 17:44:06 +0200, Thomas Petazzoni wrote:
> Dear Samuel Martin,
>
> On Sun, 26 May 2013 17:12:16 +0200, Samuel Martin wrote:
>
> > This should not be necessary since host-ccache is added to the
> > BASE_TARGETS list in the Makefile at the root of buildroot.
>
> Maybe:
>
> make menuconfig
> make <somepackage>
>
> i.e, not starting the complete build, but just the build of a given
> package?
See also https://bugs.busybox.net/show_bug.cgi?id=5678, which seems to
be related.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
2013-05-26 17:00 ` Thomas Petazzoni
@ 2013-05-26 17:44 ` Samuel Martin
2013-05-26 17:48 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Samuel Martin @ 2013-05-26 17:44 UTC (permalink / raw)
To: buildroot
Thomas, all,
2013/5/26 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> Samuel,
>
> On Sun, 26 May 2013 17:44:06 +0200, Thomas Petazzoni wrote:
>> Dear Samuel Martin,
>>
>> On Sun, 26 May 2013 17:12:16 +0200, Samuel Martin wrote:
>>
>> > This should not be necessary since host-ccache is added to the
>> > BASE_TARGETS list in the Makefile at the root of buildroot.
>>
>> Maybe:
>>
>> make menuconfig
>> make <somepackage>
>>
>> i.e, not starting the complete build, but just the build of a given
>> package?
>
> See also https://bugs.busybox.net/show_bug.cgi?id=5678, which seems to
> be related.
Right.
In these cases, I rather suggest to build either a whole "small"
config, or at least the toolchain
before tweaking anything (packages, kernel or bootloader).
Note that if we want to allow this use case, it may require adding BASE_TARGETS
to all *-menuconfig and packages' targets.
I think we don't want to go this way.
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
2013-05-26 17:44 ` Samuel Martin
@ 2013-05-26 17:48 ` Thomas Petazzoni
2013-05-26 20:37 ` Samuel Martin
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2013-05-26 17:48 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Sun, 26 May 2013 19:44:33 +0200, Samuel Martin wrote:
> In these cases, I rather suggest to build either a whole "small"
> config, or at least the toolchain
> before tweaking anything (packages, kernel or bootloader).
>
> Note that if we want to allow this use case, it may require adding BASE_TARGETS
> to all *-menuconfig and packages' targets.
>
> I think we don't want to go this way.
Being able to do "make linux-menuconfig" right after "make menuconfig"
is a quite important use case, IMO. We should support that I believe.
linux-menuconfig already depends on "dirs" so that it can work properly
when ran after "make menuconfig" (when ccache is not enabled). But I
see that it also depends on linux-configure. Maybe we just need to make
the *-extract of all packages depend on $(BASE_TARGETS) or something
like that?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
2013-05-26 17:48 ` Thomas Petazzoni
@ 2013-05-26 20:37 ` Samuel Martin
0 siblings, 0 replies; 7+ messages in thread
From: Samuel Martin @ 2013-05-26 20:37 UTC (permalink / raw)
To: buildroot
Thomas,
2013/5/26 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> Dear Samuel Martin,
>
> On Sun, 26 May 2013 19:44:33 +0200, Samuel Martin wrote:
>
>> In these cases, I rather suggest to build either a whole "small"
>> config, or at least the toolchain
>> before tweaking anything (packages, kernel or bootloader).
>>
>> Note that if we want to allow this use case, it may require adding BASE_TARGETS
>> to all *-menuconfig and packages' targets.
>>
>> I think we don't want to go this way.
>
> Being able to do "make linux-menuconfig" right after "make menuconfig"
> is a quite important use case, IMO. We should support that I believe.
>
> linux-menuconfig already depends on "dirs" so that it can work properly
> when ran after "make menuconfig" (when ccache is not enabled). But I
> see that it also depends on linux-configure. Maybe we just need to make
> the *-extract of all packages depend on $(BASE_TARGETS) or something
> like that?
>
Indeed, something like that seems doing the tricks :)
I'll cook a patch and submit it.
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-26 20:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-06 15:37 [Buildroot] [PATCH] Depend autotools targets on host-ccache when BR2_CCACHE is enabled Raúl Sánchez Siles
2013-05-26 15:12 ` Samuel Martin
2013-05-26 15:44 ` Thomas Petazzoni
2013-05-26 17:00 ` Thomas Petazzoni
2013-05-26 17:44 ` Samuel Martin
2013-05-26 17:48 ` Thomas Petazzoni
2013-05-26 20:37 ` Samuel Martin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.