* [Buildroot] [PATCH] openocd: openjtag needs libusb-compat
@ 2015-03-24 17:49 Baruch Siach
2015-03-24 21:29 ` Samuel Martin
2015-03-24 23:43 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2015-03-24 17:49 UTC (permalink / raw)
To: buildroot
Since commit 9bdf5926 (package/openocd: depends on libftdi1 instead of
libftdi) the OpenJTAG Programmer can be built without libusb-compat, that is a
dependency of libftdi (but not libftdi1). This breaks the build, because
openjtag.c uses libusb-compat headers. Select BR2_PACKAGE_LIBUSB_COMPAT to fix
this.
Fixes:
http://autobuild.buildroot.net/results/d19/d1969e6df56835568fb908b7f252aec0915d9fa4/
http://autobuild.buildroot.net/results/f06/f06ed6df6138ab399036c397c3f72d33d64fe0a3/
http://autobuild.buildroot.net/results/bd7/bd7f90f3cc1d2b395f9849eb0630c2602a075bf5/
...
Cc: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/openocd/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/openocd/Config.in b/package/openocd/Config.in
index 2db17fa76a1a..d84aac18f08e 100644
--- a/package/openocd/Config.in
+++ b/package/openocd/Config.in
@@ -186,6 +186,7 @@ config BR2_PACKAGE_OPENOCD_PRESTO
config BR2_PACKAGE_OPENOCD_OPENJTAG
bool "OpenJTAG Programmer"
select BR2_PACKAGE_LIBFTDI1
+ select BR2_PACKAGE_LIBUSB_COMPAT # needs usb.h
depends on BR2_TOOLCHAIN_HAS_THREADS # libftdi -> libusb
depends on BR2_ARCH_HAS_ATOMICS
help
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] openocd: openjtag needs libusb-compat
2015-03-24 17:49 [Buildroot] [PATCH] openocd: openjtag needs libusb-compat Baruch Siach
@ 2015-03-24 21:29 ` Samuel Martin
2015-03-24 23:43 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Martin @ 2015-03-24 21:29 UTC (permalink / raw)
To: buildroot
Hi Baruch, all,
On Tue, Mar 24, 2015 at 6:49 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Since commit 9bdf5926 (package/openocd: depends on libftdi1 instead of
> libftdi) the OpenJTAG Programmer can be built without libusb-compat, that is a
> dependency of libftdi (but not libftdi1). This breaks the build, because
> openjtag.c uses libusb-compat headers. Select BR2_PACKAGE_LIBUSB_COMPAT to fix
> this.
>
> Fixes:
> http://autobuild.buildroot.net/results/d19/d1969e6df56835568fb908b7f252aec0915d9fa4/
> http://autobuild.buildroot.net/results/f06/f06ed6df6138ab399036c397c3f72d33d64fe0a3/
> http://autobuild.buildroot.net/results/bd7/bd7f90f3cc1d2b395f9849eb0630c2602a075bf5/
> ...
>
> Cc: Samuel Martin <s.martin49@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] openocd: openjtag needs libusb-compat
2015-03-24 17:49 [Buildroot] [PATCH] openocd: openjtag needs libusb-compat Baruch Siach
2015-03-24 21:29 ` Samuel Martin
@ 2015-03-24 23:43 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-03-24 23:43 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Tue, 24 Mar 2015 19:49:39 +0200, Baruch Siach wrote:
> Since commit 9bdf5926 (package/openocd: depends on libftdi1 instead of
> libftdi) the OpenJTAG Programmer can be built without libusb-compat, that is a
> dependency of libftdi (but not libftdi1). This breaks the build, because
> openjtag.c uses libusb-compat headers. Select BR2_PACKAGE_LIBUSB_COMPAT to fix
> this.
>
> Fixes:
> http://autobuild.buildroot.net/results/d19/d1969e6df56835568fb908b7f252aec0915d9fa4/
> http://autobuild.buildroot.net/results/f06/f06ed6df6138ab399036c397c3f72d33d64fe0a3/
> http://autobuild.buildroot.net/results/bd7/bd7f90f3cc1d2b395f9849eb0630c2602a075bf5/
> ...
>
> Cc: Samuel Martin <s.martin49@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-24 23:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-24 17:49 [Buildroot] [PATCH] openocd: openjtag needs libusb-compat Baruch Siach
2015-03-24 21:29 ` Samuel Martin
2015-03-24 23:43 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.