All of lore.kernel.org
 help / color / mirror / Atom feed
* AF_INET SOCK_RAW questions.
@ 2014-09-17 20:33 Me Registered
  0 siblings, 0 replies; only message in thread
From: Me Registered @ 2014-09-17 20:33 UTC (permalink / raw)
  To: linux-kernel

Hello,

While "reading" the kernel sources referring to AF_INET SOCK_RAW
sockets, i have stumbled upon some particular issues:

* in raw_icmp_error. why is the marked line required?
 290                         raw_err(raw_sk, skb, info);
 291                         raw_sk = sk_next(raw_sk);
*292                         iph = (const struct iphdr *)skb->data; // <<<<<<
 293                 }
 294         }

looking over raw_err, the skb is not changed and i don't think that it
is meant to since that means delivering different thinks to different
sockets, while iterating. (i have tracked this line back to
2.4.3.2->2.4.3.3).

* also in raw_bind:
why is there no lock_sock/release_sock while changing socket
attributes (like in rawv6_bind)?

Thanks,
Bogdan B.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-09-17 20:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-17 20:33 AF_INET SOCK_RAW questions Me Registered

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.