From: DaeSeok Youn <daeseok.youn@gmail.com> To: gustavo@embeddedor.com Cc: Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>, Greg KH <gregkh@linuxfoundation.org>, linux-erofs@lists.ozlabs.org, devel <devel@driverdev.osuosl.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] staging: erofs: adds a space around '*' Date: Tue, 9 Oct 2018 16:31:59 +0900 [thread overview] Message-ID: <CAHb8M2A1OSs=WmDKwy9F8H4jkLheiM89yJgzj9NnWZ7xF8RSmA@mail.gmail.com> (raw) In-Reply-To: <61b485f4-539b-0f25-cf3d-574ebb17197c@embeddedor.com> 2018년 10월 8일 (월) 오후 9:37, Gustavo A. R. Silva <gustavo@embeddedor.com>님이 작성: > > Hi, > > On 10/8/18 1:45 PM, Daeseok Youn wrote: > > fix checkpatch.pl error: > > ERROR: need consistent spacing around '*' (ctx:WxV) > > + memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE); > > > > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> > > --- > > drivers/staging/erofs/unzip_vle_lz4.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c > > index f5b665f..501cfe0 100644 > > --- a/drivers/staging/erofs/unzip_vle_lz4.c > > +++ b/drivers/staging/erofs/unzip_vle_lz4.c > > @@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages, > > for (i = 0; i < clusterpages; ++i) { > > void *t = kmap_atomic(compressed_pages[i]); > > > > - memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE); > > + memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE); > > kunmap_atomic(t); > > } > > } else if (clusterpages == 1) > > > Hi Gustavo, Thanks for letting me know the patch. > This exact fix was applied to linux-next some days ago: > > commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc yes, you're right. > > Make sure you are working from linux-next rather than from mainline. I got the linux kernel source from the staging-next tree than linux-next. I knew that the patches related to staging should be merged into staging-tree first. But I didn't update the source tree to get latest. > > See this link: https://www.kernel.org/doc/man-pages/linux-next.html > Thanks. Regards, Daeseok Youn. > Thanks > -- > Gustavo
WARNING: multiple messages have this Message-ID (diff)
From: daeseok.youn@gmail.com (DaeSeok Youn) Subject: [PATCH] staging: erofs: adds a space around '*' Date: Tue, 9 Oct 2018 16:31:59 +0900 [thread overview] Message-ID: <CAHb8M2A1OSs=WmDKwy9F8H4jkLheiM89yJgzj9NnWZ7xF8RSmA@mail.gmail.com> (raw) In-Reply-To: <61b485f4-539b-0f25-cf3d-574ebb17197c@embeddedor.com> 2018? 10? 8? (?) ?? 9:37, Gustavo A. R. Silva <gustavo at embeddedor.com>?? ??: > > Hi, > > On 10/8/18 1:45 PM, Daeseok Youn wrote: > > fix checkpatch.pl error: > > ERROR: need consistent spacing around '*' (ctx:WxV) > > + memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE); > > > > Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com> > > --- > > drivers/staging/erofs/unzip_vle_lz4.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c > > index f5b665f..501cfe0 100644 > > --- a/drivers/staging/erofs/unzip_vle_lz4.c > > +++ b/drivers/staging/erofs/unzip_vle_lz4.c > > @@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages, > > for (i = 0; i < clusterpages; ++i) { > > void *t = kmap_atomic(compressed_pages[i]); > > > > - memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE); > > + memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE); > > kunmap_atomic(t); > > } > > } else if (clusterpages == 1) > > > Hi Gustavo, Thanks for letting me know the patch. > This exact fix was applied to linux-next some days ago: > > commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc yes, you're right. > > Make sure you are working from linux-next rather than from mainline. I got the linux kernel source from the staging-next tree than linux-next. I knew that the patches related to staging should be merged into staging-tree first. But I didn't update the source tree to get latest. > > See this link: https://www.kernel.org/doc/man-pages/linux-next.html > Thanks. Regards, Daeseok Youn. > Thanks > -- > Gustavo
next prev parent reply other threads:[~2018-10-09 7:32 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-08 11:45 [PATCH] staging: erofs: adds a space around '*' Daeseok Youn 2018-10-08 11:45 ` Daeseok Youn 2018-10-08 12:36 ` Gustavo A. R. Silva 2018-10-08 12:36 ` Gustavo A. R. Silva 2018-10-09 7:31 ` DaeSeok Youn [this message] 2018-10-09 7:31 ` DaeSeok Youn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHb8M2A1OSs=WmDKwy9F8H4jkLheiM89yJgzj9NnWZ7xF8RSmA@mail.gmail.com' \ --to=daeseok.youn@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=gaoxiang25@huawei.com \ --cc=gregkh@linuxfoundation.org \ --cc=gustavo@embeddedor.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yuchao0@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.