All of lore.kernel.org
 help / color / mirror / Atom feed
From: DaeSeok Youn <daeseok.youn@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: mchehab@kernel.org, devel <devel@driverdev.osuosl.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	alan@linux.intel.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset
Date: Tue, 14 Mar 2017 00:40:01 +0900	[thread overview]
Message-ID: <CAHb8M2CwfTN-dx4ojUJCvF_jr0E1bo4KLWpZE74y45WkV_6C+A@mail.gmail.com> (raw)
In-Reply-To: <CAHb8M2BOcuW8ToYTT3EUm-GieOMz6+xUhmzwW+3hbygti11k0A@mail.gmail.com>

2017-03-13 23:07 GMT+09:00 DaeSeok Youn <daeseok.youn@gmail.com>:
> 2017-03-13 20:51 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
>> On Mon, Mar 13, 2017 at 07:54:21PM +0900, Daeseok Youn wrote:
>>> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
>>> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
>>> But using kzalloc is rather than kmalloc followed by memset with 0.
>>> (vzalloc is for same reason with kzalloc)
>>>
>>> And also atomisp_kernel_malloc() can be used with
>>> atomisp_kernel_zalloc(<size>, false);
>>>
>>
>> We should just change all the callers to kvmalloc() and kvzmalloc().
> ok. I will try to change all the callers to kvmalloc() and kvzalloc().

The kvmalloc() and kvzalloc() are not ready to use in staging-testing
branch on staging tree.
If the kvmalloc and kvzalloc are available to use, I will replace
atomisp_kernel_malloc() and atomisp_kernel_zalloc() with kvmalloc()
and kvzalloc().

Thanks.
Regards,
Daeseok Youn.


>
> Thanks.
> Regards,
> Daeseok Youn
>>
>> regards,
>> dan carpenter
>>

WARNING: multiple messages have this Message-ID (diff)
From: DaeSeok Youn <daeseok.youn@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: mchehab@kernel.org, devel <devel@driverdev.osuosl.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	alan@linux.intel.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset
Date: Mon, 13 Mar 2017 15:40:01 +0000	[thread overview]
Message-ID: <CAHb8M2CwfTN-dx4ojUJCvF_jr0E1bo4KLWpZE74y45WkV_6C+A@mail.gmail.com> (raw)
In-Reply-To: <CAHb8M2BOcuW8ToYTT3EUm-GieOMz6+xUhmzwW+3hbygti11k0A@mail.gmail.com>

2017-03-13 23:07 GMT+09:00 DaeSeok Youn <daeseok.youn@gmail.com>:
> 2017-03-13 20:51 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
>> On Mon, Mar 13, 2017 at 07:54:21PM +0900, Daeseok Youn wrote:
>>> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
>>> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
>>> But using kzalloc is rather than kmalloc followed by memset with 0.
>>> (vzalloc is for same reason with kzalloc)
>>>
>>> And also atomisp_kernel_malloc() can be used with
>>> atomisp_kernel_zalloc(<size>, false);
>>>
>>
>> We should just change all the callers to kvmalloc() and kvzmalloc().
> ok. I will try to change all the callers to kvmalloc() and kvzalloc().

The kvmalloc() and kvzalloc() are not ready to use in staging-testing
branch on staging tree.
If the kvmalloc and kvzalloc are available to use, I will replace
atomisp_kernel_malloc() and atomisp_kernel_zalloc() with kvmalloc()
and kvzalloc().

Thanks.
Regards,
Daeseok Youn.


>
> Thanks.
> Regards,
> Daeseok Youn
>>
>> regards,
>> dan carpenter
>>

  reply	other threads:[~2017-03-13 15:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 10:54 [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset Daeseok Youn
2017-03-13 10:54 ` Daeseok Youn
2017-03-13 11:51 ` Dan Carpenter
2017-03-13 11:51   ` Dan Carpenter
2017-03-13 14:07   ` DaeSeok Youn
2017-03-13 14:07     ` DaeSeok Youn
2017-03-13 15:40     ` DaeSeok Youn [this message]
2017-03-13 15:40       ` DaeSeok Youn
2017-03-13 17:54 ` Alan Cox
2017-03-14  1:15   ` DaeSeok Youn
2017-03-14  1:15     ` DaeSeok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHb8M2CwfTN-dx4ojUJCvF_jr0E1bo4KLWpZE74y45WkV_6C+A@mail.gmail.com \
    --to=daeseok.youn@gmail.com \
    --cc=alan@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.