All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: Bob Peterson <rpeterso@redhat.com>,
	Abhijith Das <adas@redhat.com>,
	cluster-devel <cluster-devel@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gfs2: Fix error handling in init_statfs()
Date: Mon, 28 Jun 2021 14:23:47 +0200	[thread overview]
Message-ID: <CAHc6FU5B_bkLyU5T5KEsOr_ds0E30MVyhVdB5ck43n9tg3PRbA@mail.gmail.com> (raw)
In-Reply-To: <20210628111450.194262-1-jingxiangfeng@huawei.com>

Hi Jing,

On Mon, Jun 28, 2021 at 1:22 PM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
> In an error path of init_statfs(), it calls iput to put pn which has been
> put. Jump to correct label to fix it.

thanks for your patch. This looks okay, but I'd rather set pn to NULL
after the iput instead. Since iput(NULL) is a no-op, we'll end up with
the same result.

Andreas


WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Fix error handling in init_statfs()
Date: Mon, 28 Jun 2021 14:23:47 +0200	[thread overview]
Message-ID: <CAHc6FU5B_bkLyU5T5KEsOr_ds0E30MVyhVdB5ck43n9tg3PRbA@mail.gmail.com> (raw)
In-Reply-To: <20210628111450.194262-1-jingxiangfeng@huawei.com>

Hi Jing,

On Mon, Jun 28, 2021 at 1:22 PM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
> In an error path of init_statfs(), it calls iput to put pn which has been
> put. Jump to correct label to fix it.

thanks for your patch. This looks okay, but I'd rather set pn to NULL
after the iput instead. Since iput(NULL) is a no-op, we'll end up with
the same result.

Andreas



  reply	other threads:[~2021-06-28 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 11:14 [PATCH] gfs2: Fix error handling in init_statfs() Jing Xiangfeng
2021-06-28 11:14 ` [Cluster-devel] " Jing Xiangfeng
2021-06-28 12:23 ` Andreas Gruenbacher [this message]
2021-06-28 12:23   ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHc6FU5B_bkLyU5T5KEsOr_ds0E30MVyhVdB5ck43n9tg3PRbA@mail.gmail.com \
    --to=agruenba@redhat.com \
    --cc=adas@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=jingxiangfeng@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.