Re: [PATCH 1/2] jfs: Clean up xattr name mapping

[Andreas Gruenbacher <agruenba@redhat.com>]

On Wed, Apr 27, 2016 at 4:29 PM, Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
> On 04/22/2016 07:43 AM, Andreas Gruenbacher wrote:
>> Instead of stripping "os2." prefixes in __jfs_setxattr, make callers
>> strip them, as __jfs_getxattr already does.  With that change, use the
>> same name mapping function in jfs_{get,set,remove}xattr.
>>
>> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
>> ---
>>  fs/jfs/xattr.c | 80 ++++++++++++++++++----------------------------------------
>>  1 file changed, 25 insertions(+), 55 deletions(-)
>>
>> diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
>> index 5becc6a..9cdf7dc 100644
>> --- a/fs/jfs/xattr.c
>> +++ b/fs/jfs/xattr.c
>
>  --- cut ---
>
>> @@ -946,18 +926,8 @@ ssize_t jfs_getxattr(struct dentry *dentry, struct inode *inode,
>>       if (!strncmp(name, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN))
>>               return generic_getxattr(dentry, inode, name, data, buf_size);
>
> Am I missing a prerequisite patch? This patch doesn't apply because
> generic_getxattr() doesn't have  an inode parameter.

This is based on the work.xattr branch of
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git, sorry. The
additional parameter is the only difference as far as jfs is
concerned.

Thanks,
Andreas