[PATCH 1/2] spi: spi-adi-v3: Remove redundant OOM message

[PATCH 1/2] spi: spi-adi-v3: Remove redundant OOM message

[Sachin Kamat]

Let memory subsystem do the error logging.

Signed-off-by: Sachin Kamat <sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-adi-v3.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-adi-v3.c b/drivers/spi/spi-adi-v3.c
index dcb2287c7f8a..19ea8fb78cc7 100644
--- a/drivers/spi/spi-adi-v3.c
+++ b/drivers/spi/spi-adi-v3.c
@@ -660,10 +660,9 @@ static int adi_spi_setup(struct spi_device *spi)
 		struct adi_spi3_chip *chip_info = spi->controller_data;
 
 		chip = kzalloc(sizeof(*chip), GFP_KERNEL);
-		if (!chip) {
-			dev_err(&spi->dev, "can not allocate chip data\n");
+		if (!chip)
 			return -ENOMEM;
-		}
+
 		if (chip_info) {
 			if (chip_info->control & ~ctl_reg) {
 				dev_err(&spi->dev,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] spi: Remove redundant OOM message in spi.c

[Sachin Kamat]

Let memory subsystem handle the error logging.

Signed-off-by: Sachin Kamat <sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index d4f9670b51bc..8bbbba5b6236 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -352,7 +352,6 @@ struct spi_device *spi_alloc_device(struct spi_master *master)
 
 	spi = kzalloc(sizeof(*spi), GFP_KERNEL);
 	if (!spi) {
-		dev_err(dev, "cannot alloc spi_device\n");
 		spi_master_put(master);
 		return NULL;
 	}
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] spi: Remove redundant OOM message in spi.c

[Naveen Krishna Ch]

Hello Sachin,

On 13 June 2014 10:17, Sachin Kamat <sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Let memory subsystem handle the error logging.
>
> Signed-off-by: Sachin Kamat <sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/spi/spi.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index d4f9670b51bc..8bbbba5b6236 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -352,7 +352,6 @@ struct spi_device *spi_alloc_device(struct spi_master *master)
>
>         spi = kzalloc(sizeof(*spi), GFP_KERNEL);
>         if (!spi) {
> -               dev_err(dev, "cannot alloc spi_device\n");
>                 spi_master_put(master);
>                 return NULL;
>         }
> --
> 1.7.9.5
Reviewed-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Shine bright,
(: Nav :)
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] spi: spi-adi-v3: Remove redundant OOM message

[Naveen Krishna Ch]

Hello Sachin,

On 13 June 2014 10:17, Sachin Kamat <sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Let memory subsystem do the error logging.
>
> Signed-off-by: Sachin Kamat <sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/spi/spi-adi-v3.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-adi-v3.c b/drivers/spi/spi-adi-v3.c
> index dcb2287c7f8a..19ea8fb78cc7 100644
> --- a/drivers/spi/spi-adi-v3.c
> +++ b/drivers/spi/spi-adi-v3.c
> @@ -660,10 +660,9 @@ static int adi_spi_setup(struct spi_device *spi)
>                 struct adi_spi3_chip *chip_info = spi->controller_data;
>
>                 chip = kzalloc(sizeof(*chip), GFP_KERNEL);
> -               if (!chip) {
> -                       dev_err(&spi->dev, "can not allocate chip data\n");
> +               if (!chip)
>                         return -ENOMEM;
> -               }
> +
>                 if (chip_info) {
>                         if (chip_info->control & ~ctl_reg) {
>                                 dev_err(&spi->dev,
> --
> 1.7.9.5
Reviewed-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Shine bright,
(: Nav :)
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] spi: spi-adi-v3: Remove redundant OOM message

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

On Fri, Jun 13, 2014 at 10:17:41AM +0530, Sachin Kamat wrote:
> Let memory subsystem do the error logging.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/2] spi: Remove redundant OOM message in spi.c

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 129 bytes --]

On Fri, Jun 13, 2014 at 10:17:42AM +0530, Sachin Kamat wrote:
> Let memory subsystem handle the error logging.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]