All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
To: Olof Johansson <olof@lixom.net>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	devicetree@vger.kernel.org, cpgs@samsung.com, broonie@kernel.org,
	Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH 08/14] i2c: exynos5: Add Kconfig dependencies
Date: Wed, 3 Sep 2014 13:13:21 +0530	[thread overview]
Message-ID: <CAHfPSqBTskQxC_HktLyPF=4cmmzZvVZO2u_Y4tXkftA1qtsR4g@mail.gmail.com> (raw)
In-Reply-To: <20140828040311.GD4972@localhost>

Hi Olof,

On 28 August 2014 09:33, Olof Johansson <olof@lixom.net> wrote:
> On Wed, Aug 27, 2014 at 03:15:40PM +0530, Naveen Krishna Chatradhi wrote:
>> The i2c-exynos5.c driver can be reused for the HSI2C controller
>> on Exynos7 SoCs from Samsung.
>>
>> This patch adds the Kconfig dependency to choose i2c-exynos5.c
>> for CONFIG_ARCH_EXYNOS7.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> To: linux-i2c@vger.kernel.org
>> Cc: Wolfram Sang <wsa@the-dreams.de>
>> ---
>>  drivers/i2c/busses/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 2ac87fa..bd18fa6 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -465,7 +465,7 @@ config I2C_EG20T
>>
>>  config I2C_EXYNOS5
>>       tristate "Exynos5 high-speed I2C driver"
>> -     depends on ARCH_EXYNOS5 && OF
>> +     depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF
>
> Ick, this will keep growing. Please use ARCH_EXYNOS instead. Yes,
> this means you need to add it to the arm64 Kconfig and select it from
> ARCH_EXYNOS7.

Ok, will repost with ARCH_EXYNOS. Thanks.

>
>
>
> -Olof

-- 
Shine bright,
(: Nav :)

WARNING: multiple messages have this Message-ID (diff)
From: naveenkrishna.ch@gmail.com (Naveen Krishna Ch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/14] i2c: exynos5: Add Kconfig dependencies
Date: Wed, 3 Sep 2014 13:13:21 +0530	[thread overview]
Message-ID: <CAHfPSqBTskQxC_HktLyPF=4cmmzZvVZO2u_Y4tXkftA1qtsR4g@mail.gmail.com> (raw)
In-Reply-To: <20140828040311.GD4972@localhost>

Hi Olof,

On 28 August 2014 09:33, Olof Johansson <olof@lixom.net> wrote:
> On Wed, Aug 27, 2014 at 03:15:40PM +0530, Naveen Krishna Chatradhi wrote:
>> The i2c-exynos5.c driver can be reused for the HSI2C controller
>> on Exynos7 SoCs from Samsung.
>>
>> This patch adds the Kconfig dependency to choose i2c-exynos5.c
>> for CONFIG_ARCH_EXYNOS7.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> To: linux-i2c at vger.kernel.org
>> Cc: Wolfram Sang <wsa@the-dreams.de>
>> ---
>>  drivers/i2c/busses/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 2ac87fa..bd18fa6 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -465,7 +465,7 @@ config I2C_EG20T
>>
>>  config I2C_EXYNOS5
>>       tristate "Exynos5 high-speed I2C driver"
>> -     depends on ARCH_EXYNOS5 && OF
>> +     depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF
>
> Ick, this will keep growing. Please use ARCH_EXYNOS instead. Yes,
> this means you need to add it to the arm64 Kconfig and select it from
> ARCH_EXYNOS7.

Ok, will repost with ARCH_EXYNOS. Thanks.

>
>
>
> -Olof

-- 
Shine bright,
(: Nav :)

  reply	other threads:[~2014-09-03  7:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  9:45 [PATCH 07/14] i2c: exynos: add support for HSI2C module on Exynos7 Naveen Krishna Chatradhi
2014-08-27  9:45 ` Naveen Krishna Chatradhi
2014-08-27  9:45 ` [PATCH 08/14] i2c: exynos5: Add Kconfig dependencies Naveen Krishna Chatradhi
2014-08-27  9:45   ` Naveen Krishna Chatradhi
     [not found]   ` <1409132740-1954-2-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-08-28  4:03     ` Olof Johansson
2014-08-28  4:03       ` Olof Johansson
2014-09-03  7:43       ` Naveen Krishna Ch [this message]
2014-09-03  7:43         ` Naveen Krishna Ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHfPSqBTskQxC_HktLyPF=4cmmzZvVZO2u_Y4tXkftA1qtsR4g@mail.gmail.com' \
    --to=naveenkrishna.ch@gmail.com \
    --cc=broonie@kernel.org \
    --cc=ch.naveen@samsung.com \
    --cc=cpgs@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.