* [lm-sensors] hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
@ 2014-06-27 8:50 ` Johannes Pointner
0 siblings, 0 replies; 13+ messages in thread
From: Johannes Pointner @ 2014-06-27 8:50 UTC (permalink / raw)
To: Guenter Roeck, Jean Delvare, Naveen Krishna Chatradhi
Cc: lm-sensors, linux-iio
As I saw in the latest patches for the ntc_thermistor, in which as
part of the patch the module description changed to :
MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
I wanted to know if it is intended to extend the driver for further
manufacturers like in my case for an epcos ntc in the future?
Of course I would create the necessary patch.
Thanks,
Hannes
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
2014-06-27 8:50 ` [lm-sensors] " Johannes Pointner
@ 2014-06-27 10:50 ` Jean Delvare
-1 siblings, 0 replies; 13+ messages in thread
From: Jean Delvare @ 2014-06-27 10:50 UTC (permalink / raw)
To: Johannes Pointner
Cc: Guenter Roeck, Naveen Krishna Chatradhi, lm-sensors, linux-iio
On Fri, 27 Jun 2014 10:50:39 +0200, Johannes Pointner wrote:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
If there is enough compatibility, then yes, of course.
> Of course I would create the necessary patch.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [lm-sensors] hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
@ 2014-06-27 10:50 ` Jean Delvare
0 siblings, 0 replies; 13+ messages in thread
From: Jean Delvare @ 2014-06-27 10:50 UTC (permalink / raw)
To: Johannes Pointner
Cc: Guenter Roeck, Naveen Krishna Chatradhi, lm-sensors, linux-iio
On Fri, 27 Jun 2014 10:50:39 +0200, Johannes Pointner wrote:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
If there is enough compatibility, then yes, of course.
> Of course I would create the necessary patch.
--
Jean Delvare
SUSE L3 Support
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
2014-06-27 8:50 ` [lm-sensors] " Johannes Pointner
@ 2014-06-27 14:15 ` Guenter Roeck
-1 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2014-06-27 14:15 UTC (permalink / raw)
To: Johannes Pointner, Jean Delvare, Naveen Krishna Chatradhi
Cc: lm-sensors, linux-iio
On 06/27/2014 01:50 AM, Johannes Pointner wrote:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
>
Sure, why not ? Better than create an entirely new driver which would
be all the same but for the tables. The comment is misleading anyway
(the driver is for Murata thermistors, not from them), so we can
always drop the "from Murata".
Guenter
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [lm-sensors] hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
@ 2014-06-27 14:15 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2014-06-27 14:15 UTC (permalink / raw)
To: Johannes Pointner, Jean Delvare, Naveen Krishna Chatradhi
Cc: lm-sensors, linux-iio
On 06/27/2014 01:50 AM, Johannes Pointner wrote:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
>
Sure, why not ? Better than create an entirely new driver which would
be all the same but for the tables. The comment is misleading anyway
(the driver is for Murata thermistors, not from them), so we can
always drop the "from Murata".
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
2014-06-27 8:50 ` [lm-sensors] " Johannes Pointner
@ 2014-06-29 14:23 ` Jan Kardell
-1 siblings, 0 replies; 13+ messages in thread
From: Jan Kardell @ 2014-06-29 14:23 UTC (permalink / raw)
To: Johannes Pointner, Guenter Roeck, Jean Delvare, Naveen Krishna Chatradhi
Cc: lm-sensors, linux-iio
Johannes Pointner skriver:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
>
> Of course I would create the necessary patch.
>
> Thanks,
> Hannes
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Why not move the table to DT? There are lots of NTC types out there, and
each type comes in an number of varietes. IMHO it seems impractical to
change the code for each one, and the tables would grow to be very large.
//Jan
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [lm-sensors] hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
@ 2014-06-29 14:23 ` Jan Kardell
0 siblings, 0 replies; 13+ messages in thread
From: Jan Kardell @ 2014-06-29 14:23 UTC (permalink / raw)
To: Johannes Pointner, Guenter Roeck, Jean Delvare, Naveen Krishna Chatradhi
Cc: lm-sensors, linux-iio
Johannes Pointner skriver:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
>
> Of course I would create the necessary patch.
>
> Thanks,
> Hannes
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Why not move the table to DT? There are lots of NTC types out there, and
each type comes in an number of varietes. IMHO it seems impractical to
change the code for each one, and the tables would grow to be very large.
//Jan
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
2014-06-29 14:23 ` [lm-sensors] " Jan Kardell
@ 2014-06-29 15:11 ` Guenter Roeck
-1 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2014-06-29 15:11 UTC (permalink / raw)
To: Jan Kardell, Johannes Pointner, Jean Delvare, Naveen Krishna Chatradhi
Cc: lm-sensors, linux-iio
On 06/29/2014 07:23 AM, Jan Kardell wrote:
> Johannes Pointner skriver:
>> As I saw in the latest patches for the ntc_thermistor, in which as
>> part of the patch the module description changed to :
>>
>> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>
>> I wanted to know if it is intended to extend the driver for further
>> manufacturers like in my case for an epcos ntc in the future?
>>
>> Of course I would create the necessary patch.
>>
>> Thanks,
>> Hannes
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Why not move the table to DT? There are lots of NTC types out there, and each type comes in an number of varietes. IMHO it seems impractical to change the code for each one, and the tables would grow to be very large.
>
I would not mandate it, but I would he happy to accept a patch.
Guenter
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [lm-sensors] hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
@ 2014-06-29 15:11 ` Guenter Roeck
0 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2014-06-29 15:11 UTC (permalink / raw)
To: Jan Kardell, Johannes Pointner, Jean Delvare, Naveen Krishna Chatradhi
Cc: lm-sensors, linux-iio
On 06/29/2014 07:23 AM, Jan Kardell wrote:
> Johannes Pointner skriver:
>> As I saw in the latest patches for the ntc_thermistor, in which as
>> part of the patch the module description changed to :
>>
>> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>
>> I wanted to know if it is intended to extend the driver for further
>> manufacturers like in my case for an epcos ntc in the future?
>>
>> Of course I would create the necessary patch.
>>
>> Thanks,
>> Hannes
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Why not move the table to DT? There are lots of NTC types out there, and each type comes in an number of varietes. IMHO it seems impractical to change the code for each one, and the tables would grow to be very large.
>
I would not mandate it, but I would he happy to accept a patch.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
2014-06-29 15:11 ` [lm-sensors] " Guenter Roeck
@ 2014-06-30 3:51 ` Naveen Krishna Ch
-1 siblings, 0 replies; 13+ messages in thread
From: Naveen Krishna Ch @ 2014-06-30 3:48 UTC (permalink / raw)
To: Guenter Roeck
Cc: Jan Kardell, Johannes Pointner, Jean Delvare,
Naveen Krishna Chatradhi, lm-sensors, linux-iio
Hello Johannes Pointner skriver,
On 29 June 2014 20:41, Guenter Roeck <linux@roeck-us.net> wrote:
> On 06/29/2014 07:23 AM, Jan Kardell wrote:
>>
>> Johannes Pointner skriver:
>>>
>>> As I saw in the latest patches for the ntc_thermistor, in which as
>>> part of the patch the module description changed to :
>>>
>>> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>>
>>> I wanted to know if it is intended to extend the driver for further
>>> manufacturers like in my case for an epcos ntc in the future?
The ntc_thermistor.c currently, supports ncpXXXX
(all thermistors from Murata). Thus, My assumption.
Please post your patches for supporting other thermistors. If there
is enough compatibility.
We can drop off the "from Murata" in MODULE_DESCRIPTION()
and In the Kconfig file.
I can submit a change for the same.
>>>
>>> Of course I would create the necessary patch.
>>>
>>> Thanks,
>>> Hannes
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>> Why not move the table to DT? There are lots of NTC types out there, and
>> each type comes in an number of varietes. IMHO it seems impractical to
>> change the code for each one, and the tables would grow to be very large.
>>
>
> I would not mandate it, but I would he happy to accept a patch.
>
> Guenter
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks & Regards,
(: Nav :)
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [lm-sensors] hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
@ 2014-06-30 3:51 ` Naveen Krishna Ch
0 siblings, 0 replies; 13+ messages in thread
From: Naveen Krishna Ch @ 2014-06-30 3:51 UTC (permalink / raw)
To: Guenter Roeck
Cc: Jan Kardell, Johannes Pointner, Jean Delvare,
Naveen Krishna Chatradhi, lm-sensors, linux-iio
Hello Johannes Pointner skriver,
On 29 June 2014 20:41, Guenter Roeck <linux@roeck-us.net> wrote:
> On 06/29/2014 07:23 AM, Jan Kardell wrote:
>>
>> Johannes Pointner skriver:
>>>
>>> As I saw in the latest patches for the ntc_thermistor, in which as
>>> part of the patch the module description changed to :
>>>
>>> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>>
>>> I wanted to know if it is intended to extend the driver for further
>>> manufacturers like in my case for an epcos ntc in the future?
The ntc_thermistor.c currently, supports ncpXXXX
(all thermistors from Murata). Thus, My assumption.
Please post your patches for supporting other thermistors. If there
is enough compatibility.
We can drop off the "from Murata" in MODULE_DESCRIPTION()
and In the Kconfig file.
I can submit a change for the same.
>>>
>>> Of course I would create the necessary patch.
>>>
>>> Thanks,
>>> Hannes
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>> Why not move the table to DT? There are lots of NTC types out there, and
>> each type comes in an number of varietes. IMHO it seems impractical to
>> change the code for each one, and the tables would grow to be very large.
>>
>
> I would not mandate it, but I would he happy to accept a patch.
>
> Guenter
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks & Regards,
(: Nav :)
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [lm-sensors] hwmon: ntc_thermistor: Add another ntc(epcos) to the driver
2014-06-27 8:50 ` [lm-sensors] " Johannes Pointner
` (3 preceding siblings ...)
(?)
@ 2014-07-01 7:04 ` Johannes Pointner
-1 siblings, 0 replies; 13+ messages in thread
From: Johannes Pointner @ 2014-07-01 7:04 UTC (permalink / raw)
To: lm-sensors
Hello Naveen,
I already sent a patch.
Thank you for your suggestions.
2014-06-30 5:48 GMT+02:00 Naveen Krishna Ch <naveenkrishna.ch@gmail.com>:
> Hello Johannes Pointner skriver,
>
>
> On 29 June 2014 20:41, Guenter Roeck <linux@roeck-us.net> wrote:
> > On 06/29/2014 07:23 AM, Jan Kardell wrote:
> >>
> >> Johannes Pointner skriver:
> >>>
> >>> As I saw in the latest patches for the ntc_thermistor, in which as
> >>> part of the patch the module description changed to :
> >>>
> >>> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
> >>>
> >>> I wanted to know if it is intended to extend the driver for further
> >>> manufacturers like in my case for an epcos ntc in the future?
>
> The ntc_thermistor.c currently, supports ncpXXXX
> (all thermistors from Murata). Thus, My assumption.
>
> Please post your patches for supporting other thermistors. If there
> is enough compatibility.
>
> We can drop off the "from Murata" in MODULE_DESCRIPTION()
> and In the Kconfig file.
> I can submit a change for the same.
>
> >>>
> >>> Of course I would create the necessary patch.
> >>>
> >>> Thanks,
> >>> Hannes
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> >>> the body of a message to majordomo@vger.kernel.org
> >>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
> >>
> >> Why not move the table to DT? There are lots of NTC types out there, and
> >> each type comes in an number of varietes. IMHO it seems impractical to
> >> change the code for each one, and the tables would grow to be very
> large.
> >>
> >
> > I would not mandate it, but I would he happy to accept a patch.
> >
> > Guenter
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Thanks & Regards,
> (: Nav :)
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 13+ messages in thread