[morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp

[morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp

[George McCollister]

Add imp to python3-importlib. Make gdb-cross-canadian depend on
nativesdk-python3-importlib when python is enabled.

The following changes since commit c8d96b10ee3bc2eae0fd269d2564286fd0bc82ed:

  rm_work: Ensure we don't remove sigbasedata files (2016-11-16 10:34:34 +0000)

are available in the git repository at:

  git://github.com/gmccollister/openembedded-core morty-gdb-cross-canadian
  https://github.com/gmccollister/openembedded-core/tree/morty-gdb-cross-canadian

George McCollister (2):
  python-3.5-manifest: Add imp to importlib
  gdb-cross-canadian: Depend on nativesdk-python3-importlib

 meta/recipes-devtools/gdb/gdb-cross-canadian.inc     | 3 ++-
 meta/recipes-devtools/python/python-3.5-manifest.inc | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.9.3

[morty][PATCH 1/2] python-3.5-manifest: Add imp to importlib

[George McCollister]

The imp python module is the forerunner of importlib. Include imp in
the importlib subpackage instead of the misc subpackage so that it can
be depended on without bringing in a bunch of unrelated, unused modules.

Signed-off-by: George McCollister <george.mccollister@gmail.com>
---
 meta/recipes-devtools/python/python-3.5-manifest.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/python/python-3.5-manifest.inc b/meta/recipes-devtools/python/python-3.5-manifest.inc
index 3046114..6c690db 100644
--- a/meta/recipes-devtools/python/python-3.5-manifest.inc
+++ b/meta/recipes-devtools/python/python-3.5-manifest.inc
@@ -115,7 +115,7 @@ FILES_${PN}-image="${libdir}/python3.5/colorsys.* ${libdir}/python3.5/imghdr.* $
 
 SUMMARY_${PN}-importlib="Python import implementation library"
 RDEPENDS_${PN}-importlib="${PN}-core ${PN}-lang"
-FILES_${PN}-importlib="${libdir}/python3.5/importlib "
+FILES_${PN}-importlib="${libdir}/python3.5/importlib ${libdir}/python3.5/imp.* "
 
 SUMMARY_${PN}-io="Python low-level I/O"
 RDEPENDS_${PN}-io="${PN}-core ${PN}-math"
-- 
2.9.3

[morty][PATCH 2/2] gdb-cross-canadian: Depend on nativesdk-python3-importlib

[George McCollister]

Add missing dependency on nativesdk-python3-importlib so the imp Python
module is installed.

Before this patch, running gdb from the sdk would give the following
error:

Python Exception <class 'ImportError'> No module named 'imp':

Signed-off-by: George McCollister <george.mccollister@gmail.com>
---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
index e53081d..3ff1989 100644
--- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
@@ -14,7 +14,8 @@ GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 PACKAGECONFIG ??= "python readline"
 PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,nativesdk-python3, \
                          nativesdk-python3-core nativesdk-python3-lang nativesdk-python3-re \
-                         nativesdk-python3-codecs nativesdk-python3-netclient"
+                         nativesdk-python3-codecs nativesdk-python3-netclient \
+                         nativesdk-python3-importlib"
 PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,nativesdk-readline"
 
 SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"
-- 
2.9.3

Re: [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp

[George McCollister]

Any chance we can get this applied to morty?

Re: [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On 8 February 2017 at 22:06, George McCollister <
george.mccollister@gmail.com> wrote:

> Any chance we can get this applied to morty?
>

You should add [morty] tag to subject and CC the maintainer (
akuster808@gmail.com) to improve chances of this happening. I'm sure Armin
would also appreciate explicit confirmation that the patches apply to morty
branch.

Before that some review though (sorry I missed this in Dec) ... it looks
like the "Add imp to importlib" commit only modified manifest.inc: this is
a generated file and your changes will be overwritten next time someone
runs the generator. You should modify scripts/contrib/python/
generate-manifest-3.5.py and run that to generate the new manifest.inc file.

It would be nice if we did not store noth the source and the generated
files in git but that's how it's currently setup...

Jussi

[-- Attachment #2: Type: text/html, Size: 1481 bytes --]

Re: [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp

[George McCollister]

On Thu, Feb 9, 2017 at 2:46 AM, Jussi Kukkonen <jussi.kukkonen@intel.com> wrote:
> On 8 February 2017 at 22:06, George McCollister
> <george.mccollister@gmail.com> wrote:
>>
>> Any chance we can get this applied to morty?
>
>
> You should add [morty] tag to subject and CC the maintainer
> (akuster808@gmail.com) to improve chances of this happening. I'm sure Armin
> would also appreciate explicit confirmation that the patches apply to morty
> branch.

[morty] was in the subject but I didn't CC the maintainer. Now I know
who the maintainer is.

>
> Before that some review though (sorry I missed this in Dec) ... it looks
> like the "Add imp to importlib" commit only modified manifest.inc: this is a
> generated file and your changes will be overwritten next time someone runs
> the generator. You should modify
> scripts/contrib/python/generate-manifest-3.5.py and run that to generate the
> new manifest.inc file.

Yes, I messed that up. Someone else fixed it in master here:
http://git.openembedded.org/openembedded-core/commit/scripts/contrib/python/generate-manifest-3.5.py?id=bfe1d948ab034017622110c8365be7026e139fbf

>
> It would be nice if we did not store noth the source and the generated files
> in git but that's how it's currently setup...

I'll resend my two patches with the patch that fixes
generate-manifest-3.5.py for morty.

>
> Jussi