[PATCH v3 0/2] target mips: Misc fixes and improvements

[PATCH v3 0/2] target mips: Misc fixes and improvements

[Aleksandar Markovic]

A collection of pending fixes and improvements.

v2->v3:

    - minor content and commit message changes

v1->v2:

    - minor content and commit message changes

Aleksandar Markovic (2):
  target/mips: Remove identical if/else branches
  MAINTAINERS: Adjust MIPS maintainership

 MAINTAINERS              | 11 +++++------
 target/mips/cp0_helper.c |  9 +--------
 2 files changed, 6 insertions(+), 14 deletions(-)

-- 
2.20.1

[PATCH v3 1/2] target/mips: Remove identical if/else branches

[Aleksandar Markovic]

Remove the segment:

      if (other_tc == other->current_tc) {
          tccause = other->CP0_Cause;
      } else {
          tccause = other->CP0_Cause;
      }

Original contributor can't remember what was his intention.

Fixes: 5a25ce9487 ("mips: Hook in more reg accesses via mttr/mftr")
Buglink: https://bugs.launchpad.net/qemu/+bug/1885718
Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
---
 target/mips/cp0_helper.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/target/mips/cp0_helper.c b/target/mips/cp0_helper.c
index bbf12e4a97..de64add038 100644
--- a/target/mips/cp0_helper.c
+++ b/target/mips/cp0_helper.c
@@ -375,16 +375,9 @@ target_ulong helper_mftc0_entryhi(CPUMIPSState *env)
 target_ulong helper_mftc0_cause(CPUMIPSState *env)
 {
     int other_tc = env->CP0_VPEControl & (0xff << CP0VPECo_TargTC);
-    int32_t tccause;
     CPUMIPSState *other = mips_cpu_map_tc(env, &other_tc);
 
-    if (other_tc == other->current_tc) {
-        tccause = other->CP0_Cause;
-    } else {
-        tccause = other->CP0_Cause;
-    }
-
-    return tccause;
+    return other->CP0_Cause;
 }
 
 target_ulong helper_mftc0_status(CPUMIPSState *env)
-- 
2.20.1

[PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

[Aleksandar Markovic]

Paul Burton and Aurelien Jarno removed for not being present.
A polite email was sent to them with question whether they
intend to actively participate, but there was no response.
In cases where needed, other persons step in instead.

Huacai Chen and Jiaxun Yang step in as new energy.

CC: Paul Burton <paulburton@kernel.org>
CC: Aurelien Jarno <aurelien@aurel32.net>
CC: Huacai Chen <chenhc@lemote.com>
CC: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
---
 MAINTAINERS | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5d8acf8d31..6f96c03f3e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -213,7 +213,8 @@ F: disas/microblaze.c
 
 MIPS TCG CPUs
 M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
-R: Aurelien Jarno <aurelien@aurel32.net>
+R: Huacai Chen <chenhc@lemote.com>
+R: Jiaxun Yang <jiaxun.yang@flygoat.com>
 R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
 S: Maintained
 F: target/mips/
@@ -377,6 +378,7 @@ F: target/arm/kvm.c
 
 MIPS KVM CPUs
 M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
+M: Huacai Chen <chenhc@lemote.com>
 S: Odd Fixes
 F: target/mips/kvm.c
 
@@ -1061,7 +1063,6 @@ F: hw/dma/rc4030.c
 Malta
 M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
 M: Philippe Mathieu-Daudé <f4bug@amsat.org>
-R: Aurelien Jarno <aurelien@aurel32.net>
 S: Maintained
 F: hw/isa/piix4.c
 F: hw/acpi/piix4.c
@@ -1080,7 +1081,6 @@ F: hw/net/mipsnet.c
 
 R4000
 M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
-R: Aurelien Jarno <aurelien@aurel32.net>
 R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
 S: Obsolete
 F: hw/mips/r4k.c
@@ -1103,8 +1103,7 @@ S: Maintained
 F: hw/intc/loongson_liointc.c
 
 Boston
-M: Paul Burton <pburton@wavecomp.com>
-R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
+M: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
 S: Maintained
 F: hw/core/loader-fit.c
 F: hw/mips/boston.c
@@ -2677,7 +2676,7 @@ F: disas/i386.c
 
 MIPS TCG target
 M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
-R: Aurelien Jarno <aurelien@aurel32.net>
+R: Jiaxun Yang <jiaxun.yang@flygoat.com>
 R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
 S: Maintained
 F: tcg/mips/
-- 
2.20.1

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

[Paul Burton]

Hi Aleksandar,

On Wed, Jul 1, 2020 at 11:26 AM Aleksandar Markovic
<aleksandar.qemu.devel@gmail.com> wrote:
> Paul Burton and Aurelien Jarno removed for not being present.
> A polite email was sent to them with question whether they
> intend to actively participate, but there was no response.

It was 2 days ago, not 2 months :)

I'm fine with being removed though - I no longer have access to modern
MIPS CPUs or Boston hardware, and wouldn't currently have time to
spend on them if I did. So as far as removing me goes:

  Acked-by: Paul Burton <paulburton@kernel.org>

> In cases where needed, other persons step in instead.
>
> Huacai Chen and Jiaxun Yang step in as new energy.

All the best with it moving forwards, and thanks to Huacai & Jiaxun
for stepping up!

Paul

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

[Aleksandar Markovic]

On Wed, Jul 1, 2020 at 8:43 PM Paul Burton <paulburton@kernel.org> wrote:
>
> Hi Aleksandar,
>
> On Wed, Jul 1, 2020 at 11:26 AM Aleksandar Markovic
> <aleksandar.qemu.devel@gmail.com> wrote:
> > Paul Burton and Aurelien Jarno removed for not being present.
> > A polite email was sent to them with question whether they
> > intend to actively participate, but there was no response.
>
> It was 2 days ago, not 2 months :)
>

:) Haha, but nobody said 2 months ago. What do you need - 2 years notice? :)

Paul, you know I would like you be with me here more than anything
else. I still feel the excitement of working together with you - can
you believe it? Some people here even (so wrongfully) think I have
some bad feelings about you, while the truth is the total opposite,
and I am sure you know too. All doors are open to you, if you want to
get involved, and wherever I will be. You are among the best
engineers, actually, now I am thinking, probably the very best, I
worked with!

I long our path cross again!

All the best on your pursuits!

Aleksandar

> I'm fine with being removed though - I no longer have access to modern
> MIPS CPUs or Boston hardware, and wouldn't currently have time to
> spend on them if I did. So as far as removing me goes:
>
>   Acked-by: Paul Burton <paulburton@kernel.org>
>
> > In cases where needed, other persons step in instead.
> >
> > Huacai Chen and Jiaxun Yang step in as new energy.
>
> All the best with it moving forwards, and thanks to Huacai & Jiaxun
> for stepping up!
>
> Paul

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

[Aurelien Jarno]

NACK

On 2020-07-01 20:25, Aleksandar Markovic wrote:
> Paul Burton and Aurelien Jarno removed for not being present.
> A polite email was sent to them with question whether they
> intend to actively participate, but there was no response.

I indeed received a polite email, but it was sent less than 12 hours ago
(Peter Maydell was Cc:ed and can confirm). I didn't even got time to
answer it, I am still processing my emails after coming back from paid
work.

I don't understand this sudden need to rush things in adjusting the
MIPS maintainership.

Regards,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

[Aleksandar Markovic]

On Wed, Jul 1, 2020 at 8:55 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
>
> NACK
>
> On 2020-07-01 20:25, Aleksandar Markovic wrote:
> > Paul Burton and Aurelien Jarno removed for not being present.
> > A polite email was sent to them with question whether they
> > intend to actively participate, but there was no response.
>
> I indeed received a polite email, but it was sent less than 12 hours ago
> (Peter Maydell was Cc:ed and can confirm). I didn't even got time to
> answer it, I am still processing my emails after coming back from paid
> work.
>
> I don't understand this sudden need to rush things in adjusting the
> MIPS maintainership.
>

Well, from time to time it happens - there is nor rush.

Good, I am glad. Welcome back! :)

> Regards,
> Aurelien
>
> --
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net                 http://www.aurel32.net

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

[Aurelien Jarno]

On 2020-07-01 20:55, Aurelien Jarno wrote:
> NACK

This NACK was because I find inacceptable to claim that you got not
answer from Paul or from myself after very few time.

Now about the content of the patch, QEMU used to be a fun ride, but it
happens that interactions are now hurtful, especially on the MIPS side.
It's time for me to leave this community and say goodbye.

So as far as removing me goes:

  Acked-by: Aurelien Jarno <aurelien@aurel32.net> 

Regards,
Aurelien

> On 2020-07-01 20:25, Aleksandar Markovic wrote:
> > Paul Burton and Aurelien Jarno removed for not being present.
> > A polite email was sent to them with question whether they
> > intend to actively participate, but there was no response.
> 
> I indeed received a polite email, but it was sent less than 12 hours ago
> (Peter Maydell was Cc:ed and can confirm). I didn't even got time to
> answer it, I am still processing my emails after coming back from paid
> work.
> 
> I don't understand this sudden need to rush things in adjusting the
> MIPS maintainership.
> 
> Regards,
> Aurelien
> 
> -- 
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net                 http://www.aurel32.net

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

[Paolo Bonzini]

On 02/07/20 07:09, Aurelien Jarno wrote:
> On 2020-07-01 20:55, Aurelien Jarno wrote:
>> NACK
> This NACK was because I find inacceptable to claim that you got not
> answer from Paul or from myself after very few time.
> 
> Now about the content of the patch, QEMU used to be a fun ride, but it
> happens that interactions are now hurtful, especially on the MIPS side.
> It's time for me to leave this community and say goodbye.
> 
> So as far as removing me goes:
> 
>   Acked-by: Aurelien Jarno <aurelien@aurel32.net> 

So long, and thanks for all the fish, Aurelien. :)

Aleksandar, I strongly suggest that you take a break from MIPS
maintainership.  To be clear: this is not a reprimand or a retaliation
of any kind, just a suggestion to improve the interactions on the MIPS side.

Let Philippe, and Aurelien if he changes his mind now or at any time in
the future, do their job; act as a "regular contributor" for some time.
 You'll see that the world will not end and learn to appreciate the
effort that other people put in making MIPS support in QEMU a little
better, a step at a time.

Thanks,

Paolo

Re: [PATCH v3 0/2] target mips: Misc fixes and improvements

[Philippe Mathieu-Daudé]

On 7/1/20 8:25 PM, Aleksandar Markovic wrote:
> A collection of pending fixes and improvements.
> 
> v2->v3:
> 
>     - minor content and commit message changes
> 
> v1->v2:
> 
>     - minor content and commit message changes
> 
> Aleksandar Markovic (2):
>   target/mips: Remove identical if/else branches
>   MAINTAINERS: Adjust MIPS maintainership

Thanks, added to mips-next, splitting the 2nd patch in 3:
MAINTAINERS: Adjust MIPS maintainership (remove Aurelien Jarno)
MAINTAINERS: Adjust MIPS maintainership (remove Paul Burton)
MAINTAINERS: Adjust MIPS maintainership (Add Huacai Chen & Jiaxun Yang)