Re: [bug report] system panic at nfit_get_smbios_id+0x6e/0xf0 [nfit] during boot

[Yi Zhang <yi.zhang@redhat.com>]

On Fri, May 7, 2021 at 5:17 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Thu, May 6, 2021 at 10:28 AM Kaneda, Erik <erik.kaneda@intel.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Yi Zhang <yi.zhang@redhat.com>
> > > Sent: Wednesday, May 5, 2021 8:05 PM
> > > To: Williams, Dan J <dan.j.williams@intel.com>; Moore, Robert
> > > <robert.moore@intel.com>
> > > Cc: linux-nvdimm <linux-nvdimm@lists.01.org>; Kaneda, Erik
> > > <erik.kaneda@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>
> > > Subject: Re: [bug report] system panic at nfit_get_smbios_id+0x6e/0xf0
> > > [nfit] during boot
> > >
> > > On Sat, May 1, 2021 at 2:05 PM Dan Williams <dan.j.williams@intel.com>
> > > wrote:
> > > >
> > > > On Fri, Apr 30, 2021 at 7:28 PM Yi Zhang <yi.zhang@redhat.com> wrote:
> > > > >
> > > > > Hi
> > > > >
> > > > > With the latest Linux tree, my DCPMM server boot failed with the
> > > > > bellow panic log, pls help check it, let me know if you need any test
> > > > > for it.
> > > >
> > > > So v5.12 is ok but v5.12+ is not?
> > > >
> > > > Might you be able to bisect?
> > >
> > > Hi Dan
> > > This issue was introduced with this patch, let me know if you need more info.
> > >
> > > commit cf16b05c607bd716a0a5726dc8d577a89fdc1777
> > > Author: Bob Moore <robert.moore@intel.com>
> > > Date:   Tue Apr 6 14:30:15 2021 -0700
> > >
> > >     ACPICA: ACPI 6.4: NFIT: add Location Cookie field
> > >
> > >     Also, update struct size to reflect these changes in nfit core driver.
> > >
> > >     ACPICA commit af60199a9a1de9e6844929fd4cc22334522ed195
> > >
> > >     Link: https://github.com/acpica/acpica/commit/af60199a
> > >     Cc: Dan Williams <dan.j.williams@intel.com>
> > >     Signed-off-by: Bob Moore <robert.moore@intel.com>
> > >     Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
> > >     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >
> >
> > It's likely that this change forced the nfit driver's code to parse the ACPI table so that it assumes that the location cookie field is always enabled and the NFIT was parsed incorrectly. Does the NFIT table on this platform contain a valid cookie field?
> >
>
> This was my fault. When I saw the size change fly by, I should have
> remembered to go update all the places that do "sizeof(struct
> acpi_nfit_system_address)".
>
> Yi Zhang, can you give the attached patch a try:

Hi Dan
My DCPMM server boots up now with this patch, feel free to add:
Tested-by: Yi Zhang <yi.zhang@redhat.com>