* [bug report]unhandled identify cns 6 on qid 0
@ 2021-04-29 1:44 Yi Zhang
2021-04-29 3:23 ` Keith Busch
0 siblings, 1 reply; 2+ messages in thread
From: Yi Zhang @ 2021-04-29 1:44 UTC (permalink / raw)
To: kbusch; +Cc: linux-nvme
Hi Keith
I found this error log during blktests[2] on linux-block/for-next, it
was introduced with [1] and seems no handler for NVME_ID_CNS_CS_CTRL,
could you help check it?
[1]
commit 5befc7c26e5a98cd49789fb1beb52c62bd472dba
Author: Keith Busch <kbusch@kernel.org>
Date: Wed Mar 24 16:18:05 2021 -0700
nvme: implement non-mdts command limits
+ c.identify.cns = NVME_ID_CNS_CS_CTRL;
static void nvmet_execute_identify(struct nvmet_req *req)
{
if (!nvmet_check_transfer_len(req, NVME_IDENTIFY_DATA_SIZE))
return;
switch (req->cmd->identify.cns) {
case NVME_ID_CNS_NS:
return nvmet_execute_identify_ns(req);
case NVME_ID_CNS_CTRL:
return nvmet_execute_identify_ctrl(req);
case NVME_ID_CNS_NS_ACTIVE_LIST:
return nvmet_execute_identify_nslist(req);
case NVME_ID_CNS_NS_DESC_LIST:
return nvmet_execute_identify_desclist(req);
}
pr_err("unhandled identify cns %d on qid %d\n",
req->cmd->identify.cns, req->sq->qid);
[2]
#./check nvme/010
[ 493.632730] run blktests nvme/010 at 2021-04-28 04:19:28
[ 493.669330] loop0: detected capacity change from 0 to 2097152
[ 493.685798] nvmet: adding nsid 1 to subsystem blktests-subsystem-1
[ 493.689397] nvmet: creating controller 1 for subsystem
blktests-subsystem-1 for NQN
nqn.2014-08.org.nvmexpress:uuid:48741e3a-3c7e-428b-877f-b78897ab0f61.
[ 493.689439] nvmet: unhandled identify cns 6 on qid 0
[ 493.694412] nvme nvme0: creating 32 I/O queues.
[ 493.695351] nvme nvme0: new ctrl: "blktests-subsystem-1"
[ 497.870910] nvme nvme0: Removing ctrl: NQN "blktests-subsystem-1"
Thanks
Yi
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report]unhandled identify cns 6 on qid 0
2021-04-29 1:44 [bug report]unhandled identify cns 6 on qid 0 Yi Zhang
@ 2021-04-29 3:23 ` Keith Busch
0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2021-04-29 3:23 UTC (permalink / raw)
To: Yi Zhang; +Cc: linux-nvme
On Thu, Apr 29, 2021 at 09:44:05AM +0800, Yi Zhang wrote:
> Hi Keith
> I found this error log during blktests[2] on linux-block/for-next, it
> was introduced with [1] and seems no handler for NVME_ID_CNS_CS_CTRL,
> could you help check it?
Thanks for the report.
Just to confirm: the only problem is that a new error has been logged,
but the test passes otherwise, correct? If yes, I believe the error
message is harmless, but I will look into suppressing it because these
are alarming, and it is not a target error when a host requests an
unsupported identification anyway.
> [1]
> commit 5befc7c26e5a98cd49789fb1beb52c62bd472dba
> Author: Keith Busch <kbusch@kernel.org>
> Date: Wed Mar 24 16:18:05 2021 -0700
>
> nvme: implement non-mdts command limits
>
>
> + c.identify.cns = NVME_ID_CNS_CS_CTRL;
>
> static void nvmet_execute_identify(struct nvmet_req *req)
> {
> if (!nvmet_check_transfer_len(req, NVME_IDENTIFY_DATA_SIZE))
> return;
>
> switch (req->cmd->identify.cns) {
> case NVME_ID_CNS_NS:
> return nvmet_execute_identify_ns(req);
> case NVME_ID_CNS_CTRL:
> return nvmet_execute_identify_ctrl(req);
> case NVME_ID_CNS_NS_ACTIVE_LIST:
> return nvmet_execute_identify_nslist(req);
> case NVME_ID_CNS_NS_DESC_LIST:
> return nvmet_execute_identify_desclist(req);
> }
>
> pr_err("unhandled identify cns %d on qid %d\n",
> req->cmd->identify.cns, req->sq->qid);
>
> [2]
> #./check nvme/010
> [ 493.632730] run blktests nvme/010 at 2021-04-28 04:19:28
> [ 493.669330] loop0: detected capacity change from 0 to 2097152
> [ 493.685798] nvmet: adding nsid 1 to subsystem blktests-subsystem-1
> [ 493.689397] nvmet: creating controller 1 for subsystem
> blktests-subsystem-1 for NQN
> nqn.2014-08.org.nvmexpress:uuid:48741e3a-3c7e-428b-877f-b78897ab0f61.
> [ 493.689439] nvmet: unhandled identify cns 6 on qid 0
> [ 493.694412] nvme nvme0: creating 32 I/O queues.
> [ 493.695351] nvme nvme0: new ctrl: "blktests-subsystem-1"
> [ 497.870910] nvme nvme0: Removing ctrl: NQN "blktests-subsystem-1"
>
> Thanks
> Yi
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-29 3:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 1:44 [bug report]unhandled identify cns 6 on qid 0 Yi Zhang
2021-04-29 3:23 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.