All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH blktests] block/002: remove debugfs check while blktests is running
@ 2022-07-29  6:04 Yi Zhang
  2022-07-29 13:22 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Yi Zhang @ 2022-07-29  6:04 UTC (permalink / raw)
  To: shinichiro.kawasaki; +Cc: linux-block, hch, ming.lei

Seem commit: 99d055b4fd4b ("block: remove per-disk debugfs files in blk_unregister_queue")

Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
 tests/block/002 | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/block/002 b/tests/block/002
index 9b183e7..15b47a6 100755
--- a/tests/block/002
+++ b/tests/block/002
@@ -25,9 +25,6 @@ test() {
 	blktrace -D "$TMP_DIR" "/dev/${SCSI_DEBUG_DEVICES[0]}" >"$FULL" 2>&1 &
 	sleep 0.5
 	echo 1 > "/sys/block/${SCSI_DEBUG_DEVICES[0]}/device/delete"
-	if [[ ! -d /sys/kernel/debug/block/${SCSI_DEBUG_DEVICES[0]} ]]; then
-		echo "debugfs directory deleted with blktrace active"
-	fi
 	{ kill $!; wait; } >/dev/null 2>/dev/null
 	if [[ -d /sys/kernel/debug/block/${SCSI_DEBUG_DEVICES[0]} ]]; then
 		echo "debugfs directory leaked"
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH blktests] block/002: remove debugfs check while blktests is running
  2022-07-29  6:04 [PATCH blktests] block/002: remove debugfs check while blktests is running Yi Zhang
@ 2022-07-29 13:22 ` Christoph Hellwig
  2022-07-30  8:01   ` Yi Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2022-07-29 13:22 UTC (permalink / raw)
  To: Yi Zhang; +Cc: shinichiro.kawasaki, linux-block, hch, ming.lei

On Fri, Jul 29, 2022 at 02:04:11PM +0800, Yi Zhang wrote:
> Seem commit: 99d055b4fd4b ("block: remove per-disk debugfs files in blk_unregister_queue")

s/Seem/see/ ?

But yes, this should go in.  I thought I already submitted that, but
it seems like I didn't.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH blktests] block/002: remove debugfs check while blktests is running
  2022-07-29 13:22 ` Christoph Hellwig
@ 2022-07-30  8:01   ` Yi Zhang
  0 siblings, 0 replies; 3+ messages in thread
From: Yi Zhang @ 2022-07-30  8:01 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Shinichiro Kawasaki, linux-block, Ming Lei

On Fri, Jul 29, 2022 at 9:22 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Fri, Jul 29, 2022 at 02:04:11PM +0800, Yi Zhang wrote:
> > Seem commit: 99d055b4fd4b ("block: remove per-disk debugfs files in blk_unregister_queue")
>
> s/Seem/see/ ?
Yes, just send v2 for this patch, thanks for the review.

>
> But yes, this should go in.  I thought I already submitted that, but
> it seems like I didn't.
>


-- 
Best Regards,
  Yi Zhang


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-30  8:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29  6:04 [PATCH blktests] block/002: remove debugfs check while blktests is running Yi Zhang
2022-07-29 13:22 ` Christoph Hellwig
2022-07-30  8:01   ` Yi Zhang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.