From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Xu <peterx@redhat.com>
Cc: Linux-MM <linux-mm@kvack.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>, Maya Gokhale <gokhale2@llnl.gov>,
Jerome Glisse <jglisse@redhat.com>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Martin Cracauer <cracauer@cons.org>,
Marty McFadden <mcfadden8@llnl.gov>, Shaohua Li <shli@fb.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Mel Gorman <mgorman@suse.de>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 0/7] mm: Page fault enhancements
Date: Thu, 5 Sep 2019 14:06:04 -0700 [thread overview]
Message-ID: <CAHk-=wgSwiRsT4=q71jnF_5JrUn5qg76VBw+oMJ-e7SQ17Q1QA@mail.gmail.com> (raw)
In-Reply-To: <20190905101534.9637-1-peterx@redhat.com>
On Thu, Sep 5, 2019 at 3:15 AM Peter Xu <peterx@redhat.com> wrote:
>
> This series is split out of userfaultfd-wp series to only cover the
> general page fault changes, since it seems to make sense itself.
The series continues to look sane to me, but I'd like VM people to
take a look. I see a few reviewed-by's, it would be nice to see more
comments from people. I'd like to see Andrea in particular say "yeah,
this looks all good to me".
Also a question on how this will get to me - it smells like Andrew's
-mm tree to me, both from a VM and a userfaultfd angle (and looking
around, at least a couple of previous patches by Peter have gone that
way).
And it would be lovely to have actual _numbers_ for the alleged
latency improvements. I 100% believe them, but still, numbers rule.
Talking about latency, what about that retry loop in gup()? That's the
one I'm not at all convinced about. It doesn't check for signals, so
if there is some retry logic, it loops forever. Hmm?
Linus
next prev parent reply other threads:[~2019-09-05 21:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 10:15 [PATCH v2 0/7] mm: Page fault enhancements Peter Xu
2019-09-05 10:15 ` [PATCH v2 1/7] mm/gup: Rename "nonblocking" to "locked" where proper Peter Xu
2019-09-06 8:50 ` David Hildenbrand
2019-09-05 10:15 ` [PATCH v2 2/7] mm: Introduce FAULT_FLAG_DEFAULT Peter Xu
2019-09-06 8:51 ` David Hildenbrand
2019-09-05 10:15 ` [PATCH v2 3/7] mm: Introduce FAULT_FLAG_INTERRUPTIBLE Peter Xu
2019-09-06 9:02 ` David Hildenbrand
2019-09-06 12:38 ` Peter Xu
2019-09-06 12:53 ` David Hildenbrand
2019-09-05 10:15 ` [PATCH v2 4/7] mm: Return faster for non-fatal signals in user mode faults Peter Xu
2019-09-05 10:15 ` [PATCH v2 5/7] userfaultfd: Don't retake mmap_sem to emulate NOPAGE Peter Xu
2019-09-05 10:15 ` [PATCH v2 6/7] mm: Allow VM_FAULT_RETRY for multiple times Peter Xu
2019-09-05 10:15 ` [PATCH v2 7/7] mm/gup: " Peter Xu
2019-09-05 21:06 ` Linus Torvalds [this message]
2019-09-05 21:06 ` [PATCH v2 0/7] mm: Page fault enhancements Linus Torvalds
2019-09-06 6:39 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgSwiRsT4=q71jnF_5JrUn5qg76VBw+oMJ-e7SQ17Q1QA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=cracauer@cons.org \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=gokhale2@llnl.gov \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcfadden8@llnl.gov \
--cc=mgorman@suse.de \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shli@fb.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.