From: Linus Torvalds <torvalds@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: Cgroups <cgroups@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] cgroup changes for v5.14-rc1
Date: Thu, 1 Jul 2021 17:25:59 -0700 [thread overview]
Message-ID: <CAHk-=wgcyjLGcoRho5iw7b3Yx+R05rXwyJmP_LhOqsHgjiZugQ@mail.gmail.com> (raw)
In-Reply-To: <YN4rzCdUR+/2LgaP@mtj.duckdns.org>
On Thu, Jul 1, 2021 at 1:55 PM Tejun Heo <tj@kernel.org> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-5.14
I've pulled it, but let me vent about this history a bit.
Look at commit c2a11971549b ("Merge branch 'for-5.13-fixes' into for-5.14").
Now tell me how that commit explains why it exists.
Merge commits need commit messages too.
In particular, they need commit messages that *explain* why they exist
in the first place, not just a one-liner that says what it does (and
does so badly at that).
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [GIT PULL] cgroup changes for v5.14-rc1
Date: Thu, 1 Jul 2021 17:25:59 -0700 [thread overview]
Message-ID: <CAHk-=wgcyjLGcoRho5iw7b3Yx+R05rXwyJmP_LhOqsHgjiZugQ@mail.gmail.com> (raw)
In-Reply-To: <YN4rzCdUR+/2LgaP-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
On Thu, Jul 1, 2021 at 1:55 PM Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-5.14
I've pulled it, but let me vent about this history a bit.
Look at commit c2a11971549b ("Merge branch 'for-5.13-fixes' into for-5.14").
Now tell me how that commit explains why it exists.
Merge commits need commit messages too.
In particular, they need commit messages that *explain* why they exist
in the first place, not just a one-liner that says what it does (and
does so badly at that).
Linus
next prev parent reply other threads:[~2021-07-02 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 20:55 [GIT PULL] cgroup changes for v5.14-rc1 Tejun Heo
2021-07-01 20:55 ` Tejun Heo
2021-07-02 0:25 ` Linus Torvalds [this message]
2021-07-02 0:25 ` Linus Torvalds
2021-07-02 0:32 ` Tejun Heo
2021-07-02 0:32 ` Tejun Heo
2021-07-02 0:46 ` pr-tracker-bot
2021-07-02 0:46 ` pr-tracker-bot-DgEjT+Ai2ygdnm+yROfE0A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgcyjLGcoRho5iw7b3Yx+R05rXwyJmP_LhOqsHgjiZugQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.