All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ACPI: Drop ACPI_USE_BUILTIN_STDARG ifdef from acgcc.h
@ 2021-11-03 18:46 Rafael J. Wysocki
  2021-11-03 18:48 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2021-11-03 18:46 UTC (permalink / raw)
  To: Linux ACPI; +Cc: LKML, Linus Torvalds

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The ACPI_USE_BUILTIN_STDARG symbol is never set in the kernel build,
so stop checking it in include/acpi/platform/acgcc.h and drop all of
the macros depending on it (which appear to duplicate the analogous
macros from linux/stdarg.h, but in fact are never used). 

Link: https://lore.kernel.org/linux-acpi/CAHk-=whCammRsz8PEbrft3M6vGjF506gkxtyGw81uGOUUvD51g@mail.gmail.com/
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 include/acpi/platform/acgcc.h |   13 -------------
 1 file changed, 13 deletions(-)

Index: linux-pm/include/acpi/platform/acgcc.h
===================================================================
--- linux-pm.orig/include/acpi/platform/acgcc.h
+++ linux-pm/include/acpi/platform/acgcc.h
@@ -10,25 +10,12 @@
 #ifndef __ACGCC_H__
 #define __ACGCC_H__
 
-/*
- * Use compiler specific <stdarg.h> is a good practice for even when
- * -nostdinc is specified (i.e., ACPI_USE_STANDARD_HEADERS undefined.
- */
 #ifndef va_arg
-#ifdef ACPI_USE_BUILTIN_STDARG
-typedef __builtin_va_list va_list;
-#define va_start(v, l)          __builtin_va_start(v, l)
-#define va_end(v)               __builtin_va_end(v)
-#define va_arg(v, l)            __builtin_va_arg(v, l)
-#define va_copy(d, s)           __builtin_va_copy(d, s)
-#else
 #ifdef __KERNEL__
 #include <linux/stdarg.h>
 #else
-/* Used to build acpi tools */
 #include <stdarg.h>
 #endif /* __KERNEL__ */
-#endif /* ACPI_USE_BUILTIN_STDARG */
 #endif /* ! va_arg */
 
 #define ACPI_INLINE             __inline__




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI: Drop ACPI_USE_BUILTIN_STDARG ifdef from acgcc.h
  2021-11-03 18:46 [PATCH] ACPI: Drop ACPI_USE_BUILTIN_STDARG ifdef from acgcc.h Rafael J. Wysocki
@ 2021-11-03 18:48 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2021-11-03 18:48 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Linux ACPI, LKML

On Wed, Nov 3, 2021 at 11:46 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> The ACPI_USE_BUILTIN_STDARG symbol is never set in the kernel build,
> so stop checking it in include/acpi/platform/acgcc.h and drop all of
> the macros depending on it (which appear to duplicate the analogous
> macros from linux/stdarg.h, but in fact are never used).

Ack. Thanks,

                Linus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-03 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 18:46 [PATCH] ACPI: Drop ACPI_USE_BUILTIN_STDARG ifdef from acgcc.h Rafael J. Wysocki
2021-11-03 18:48 ` Linus Torvalds

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.