All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Airlie <airlied@gmail.com>,
	Mikita Lipski <mikita.lipski@amd.com>,
	Sun peng Li <Sunpeng.Li@amd.com>,
	Qingqing Zhuo <qingqing.zhuo@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for 5.13-rc1
Date: Wed, 28 Apr 2021 15:21:57 -0700	[thread overview]
Message-ID: <CAHk-=wh3x4Q4pCkYe7__OAnvOyPqdZLN5ha0z4U035FwT5G57w@mail.gmail.com> (raw)
In-Reply-To: <CAPM=9txMo5f9QvPqdzt8g3CmUpyDFf2Q_0XS4V1FyjHX8WQPRA@mail.gmail.com>

On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie <airlied@gmail.com> wrote:
>
> This is the main drm pull request for 5.13. The usual lots of work all
> over the place. [...]
>
> Mikita Lipski:
>       drm/amd/display: Add MST capability to trigger_hotplug interface

Hmm. I've already merged this, but my clang build shows that this looks buggy:

drivers/gpu/drm/amd/amdgpu/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53:
warning: address of 'aconnector->mst_port->mst_mgr' will always
evaluate to 'true' [-Wpointer-bool-conversion]
                        if (!(aconnector->port &&
&aconnector->mst_port->mst_mgr))
                                               ~~  ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

and yeah, checking for the address of a member of a structure benign
NULL doesn't really work.

I'm assuming the '&' is just a left-over cut-and-paste error or something.

Please fix after reviewing (I'm not going to blindly just remove the
'&' just to silence the warning, since I don't know the code).

                Linus

WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Airlie <airlied@gmail.com>,
	Mikita Lipski <mikita.lipski@amd.com>,
	 Sun peng Li <Sunpeng.Li@amd.com>,
	Qingqing Zhuo <qingqing.zhuo@amd.com>,
	 Alex Deucher <alexander.deucher@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [git pull] drm for 5.13-rc1
Date: Wed, 28 Apr 2021 15:21:57 -0700	[thread overview]
Message-ID: <CAHk-=wh3x4Q4pCkYe7__OAnvOyPqdZLN5ha0z4U035FwT5G57w@mail.gmail.com> (raw)
In-Reply-To: <CAPM=9txMo5f9QvPqdzt8g3CmUpyDFf2Q_0XS4V1FyjHX8WQPRA@mail.gmail.com>

On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie <airlied@gmail.com> wrote:
>
> This is the main drm pull request for 5.13. The usual lots of work all
> over the place. [...]
>
> Mikita Lipski:
>       drm/amd/display: Add MST capability to trigger_hotplug interface

Hmm. I've already merged this, but my clang build shows that this looks buggy:

drivers/gpu/drm/amd/amdgpu/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53:
warning: address of 'aconnector->mst_port->mst_mgr' will always
evaluate to 'true' [-Wpointer-bool-conversion]
                        if (!(aconnector->port &&
&aconnector->mst_port->mst_mgr))
                                               ~~  ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

and yeah, checking for the address of a member of a structure benign
NULL doesn't really work.

I'm assuming the '&' is just a left-over cut-and-paste error or something.

Please fix after reviewing (I'm not going to blindly just remove the
'&' just to silence the warning, since I don't know the code).

                Linus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-04-28 22:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  3:31 [git pull] drm for 5.13-rc1 Dave Airlie
2021-04-28  3:31 ` Dave Airlie
2021-04-28 17:07 ` Linus Torvalds
2021-04-28 17:07   ` Linus Torvalds
2021-04-28 18:14   ` Daniel Vetter
2021-04-28 18:14     ` Daniel Vetter
2021-04-28 18:16     ` Linus Torvalds
2021-04-28 18:16       ` Linus Torvalds
2021-04-28 17:33 ` pr-tracker-bot
2021-04-28 17:33   ` pr-tracker-bot
2021-04-28 22:21 ` Linus Torvalds [this message]
2021-04-28 22:21   ` Linus Torvalds
2021-04-29  0:14   ` Mikita Lipski
2021-04-29  0:14     ` Mikita Lipski
2021-04-29  2:09     ` Alex Deucher
2021-04-29  2:09       ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wh3x4Q4pCkYe7__OAnvOyPqdZLN5ha0z4U035FwT5G57w@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=Sunpeng.Li@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikita.lipski@amd.com \
    --cc=qingqing.zhuo@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.