From: Linus Torvalds <torvalds@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] XArray for 5.8
Date: Wed, 22 Jul 2020 11:40:13 -0700 [thread overview]
Message-ID: <CAHk-=whC-GKFoBGRSnTnD6VxL_J+5xs4BzEhEfyhGMcT8Mga7g@mail.gmail.com> (raw)
In-Reply-To: <20200722141151.GO15516@casper.infradead.org>
On Wed, Jul 22, 2020 at 7:11 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> XArray updates for 5.8
>
> - Fix the test suite after introduction of the local_lock
What? No.
Now you broke the actual kernel build:
In file included from ./include/linux/local_lock.h:5,
from ./include/linux/radix-tree.h:14,
from ./include/linux/idr.h:15,
from lib/idr.c:5:
./include/linux/local_lock_internal.h: In function ‘local_lock_acquire’:
./include/linux/local_lock_internal.h:41:13: error: ‘current’
undeclared (first use in this function)
41 | l->owner = current;
| ^~~~~~~
./include/linux/local_lock_internal.h:41:13: note: each undeclared
identifier is reported only once for each function it appears in
How the hell did you not see this, and why did you think it was a good
idea to mess with kernel headers and make them alphabetically ordered?
Headers need to be ordered by _contents_, not by some "sort alphabetically".
Do you sort your bookcases by color and size of the book too?
Linus
next prev parent reply other threads:[~2020-07-22 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:11 [GIT PULL] XArray for 5.8 Matthew Wilcox
2020-07-22 18:40 ` Linus Torvalds [this message]
2020-07-22 18:46 ` Matthew Wilcox
2020-07-22 19:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whC-GKFoBGRSnTnD6VxL_J+5xs4BzEhEfyhGMcT8Mga7g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.