From: Linus Torvalds <torvalds@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] XArray for 5.8
Date: Wed, 22 Jul 2020 12:01:04 -0700 [thread overview]
Message-ID: <CAHk-=whW+M5kBwdNX2mLyGEDSGq=Bu7i=M5FUh+E1ZSTwsrEAw@mail.gmail.com> (raw)
In-Reply-To: <20200722184636.GQ15516@casper.infradead.org>
On Wed, Jul 22, 2020 at 11:46 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> But I think the real problem is that local_lock_internal.h doesn't include
> <linux/sched.h>. Header files shouldn't depend on other headers to be
> included first.
The big hint is that name: "internal".
Also, we often violate the "shouldn't depend on other headers" rule.
Some basic headers are just that - basic. And some headers are not.
Things like the uapi headers need to be independent, but we've had
circular ordering problems with kernel headers, and sometimes it's
just better to say "you need to just get the basic header first".
Linus
prev parent reply other threads:[~2020-07-22 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:11 [GIT PULL] XArray for 5.8 Matthew Wilcox
2020-07-22 18:40 ` Linus Torvalds
2020-07-22 18:46 ` Matthew Wilcox
2020-07-22 19:01 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whW+M5kBwdNX2mLyGEDSGq=Bu7i=M5FUh+E1ZSTwsrEAw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.